Help with coding Linq Query

I'm trying to fill a gridview using a linq query and a contain statement. I am positive I have a lot more code than I need. I'd love a little help. Right now my error is I can't add ToString on p.DepartmentID.

 var C = (from x in ctx.tblDepartments orderby x.Department select x);
                System.Collections.Generic.List<string> CustomerIdList = new System.Collections.Generic.List<string>();
                List<tblDepartment> bb = new List<tblDepartment>();
                bb = C.ToList();
                foreach (tblDepartment item in bb)
                {
                    CustomerIdList.Add(item.DepartmentID.ToString());
                }
                string CustomerCsvList = string.Join(", ", CustomerIdList.Select(o => o.ToString()).ToArray());
                List<vw_EquipmentType> blist = (from p in ctx.vw_EquipmentType where CustomerIdList.Contains(p.DepartmentID.ToString()) select p).ToList();
                grdView.DataSource = blist;
NickMalloySystems LeadAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Richard LeeSoftware EnthusiastCommented:
I can reduce your query and still maintain readability to this:

var CustomerIdList = from x in ctx.tblDepartments 
				orderby x.Department 
				select x.DepartmentID;
				
 grdView.DataSource = (from p in ctx.vw_EquipmentType 
 		where CustomerIdList.Contains(p.DepartmentID.ToString()) 
							select p).ToList();

Open in new window


A better approach however would be to simply inner join the departments to vw_EquipmentType and get the result.

grdView.DataSource = (from dept in ctx.tblDepartments
join equip in ctx.vw_EquipmentType
	on dept.DepartmentID equals equip.DepartmentID
	select equip).ToList();

Open in new window


DaTribe
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
C#

From novice to tech pro — start learning today.