How can I improve the foreach to possibly a linq for bettter performance for large number of rows over 500000

foreach (DataRow item in priceTable.Rows)
            {
                  DataRow[] drow = dtPrices.Select("ID = '" + item["ID"].ToString() + "' AND " + "Date = '" + item["Date"].ToString() + "'");
                  drow[0]["TotalReturn"] = Convert.ToDecimal(item["TotalReturn"]);
            }
LVL 1
countrymeisterAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Jacques Bourgeois (James Burger)PresidentCommented:
Always to as much of the job as you need in the database before fetching the data. Databases are optimized for that type of job.

You have 500000 rows in your computer memory, there is not much memory left. And you are doing a lot of concatenations, which are costly in time and resources.

Instead of looping and concatenating in your application, do the job in the query that fetch the data.
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Bob LearnedCommented:
What are you doing with the data?  

Can you convert this to a function that returns IEnumerable<T>, and then you can use the yield return statement to return each element in the iterator individually?
0
countrymeisterAuthor Commented:
Just a general suggestion
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
.NET Programming

From novice to tech pro — start learning today.