Solved

Looping problem

Posted on 2013-10-22
6
130 Views
Last Modified: 2013-10-22
Folks,
The code below is failing me. Here's my objective. In the Range D5:E12 if the value is "Correct" then I execute a module "FormulasOK". If a value <> "Correct" then I execute a module "CheckFormulaFunction".

Dim lRowLoop As Long

For lRowLoop = 5 To 12

 If Cells(lRowLoop, 4).Text = "Correct" Then
     Next lRowLoop
     Else
        CheckFormulaFunction
        Exit Sub
    End If

Open in new window

0
Comment
Question by:Frank Freese
  • 3
  • 2
6 Comments
 
LVL 24

Assisted Solution

by:Steve
Steve earned 100 total points
ID: 39591177
try:

Dim lRowLoop As Long
For lRowLoop = 5 To 12
 If Cells(lRowLoop, 4).value = "Correct" Then
        call FormulasOK
     Else
        call CheckFormulaFunction
    End If 
 Next lRowLoop

Open in new window

The above code only loops through D5:D12
If you want E5 to E12 you would repeat using Cells(lRowLoop, 5).value

you will need subs or functions called FormulasOK and CheckFormulaFunction
but this should sort out the code logic for you.
0
 
LVL 81

Accepted Solution

by:
byundt earned 400 total points
ID: 39591189
Did you mean to call FormulasOK only if all cells are Correct?
Sub FormulaChecker()
Dim lRowLoop As Long
For lRowLoop = 5 To 12
    If Cells(lRowLoop, 4).Text <> "Correct" Then
        CheckFormulaFunction
        Exit Sub
    End If
Next
FormulasOK
End Sub

Open in new window

0
 
LVL 24

Assisted Solution

by:Steve
Steve earned 100 total points
ID: 39591212
Ahh, Brad, you may be right there, in that case I would tend to use a Boolean...

Sub FormulaChecker()
Dim lRowLoop As Long
Dim bCorrect as Boolean: bCorrect = True

For lRowLoop = 5 To 12
    If Cells(lRowLoop, 4).Value <> "Correct" Then bCorrect = False
Next
        
If bCorrect then
    FormulasOK
else
    CheckFormulaFunction
end if

End Sub

Open in new window

0
Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 

Author Comment

by:Frank Freese
ID: 39591341
I've changed Brad's suggestion some. As I read my changes below, what happens is that the first Loop checks for the "Correct" from 5 - 12 column 4. If there's not a "Correct" then CheckFormulaFunction is executed and I execute the sub.
The same thing happens in the seond Loop except it checks column 5. If everything is "Correct" then it executes FormulasOK. Is this new code correct then?

Dim lRowLoop As Long
For lRowLoop = 5 To 12
 If Cells(lRowLoop, 4).value = "Correct" Then
             Else
             CheckFormulaFunction
             Exit sub
    End If 
 Next lRowLoop

For lRowLoop = 5 To 12
 If Cells(lRowLoop, 5).value = "Correct" Then
             Else
             CheckFormulaFunction
             Exit Sub
    End If 
 Next lRowLoop

FormulasOK

Open in new window

0
 

Author Comment

by:Frank Freese
ID: 39591411
The revised code I posted did what I was looking for.
With a few changes to Brads code I felt like he deserved the majority of the points.
But I am grateful for all that chimed in.
0
 

Author Closing Comment

by:Frank Freese
ID: 39591419
thanks everyone.
0

Featured Post

Free Tool: IP Lookup

Get more info about an IP address or domain name, such as organization, abuse contacts and geolocation.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Combine like values in a graph excel 2016 7 35
Turn date into age 17 33
MS Excel Formula Help 3 35
Excel 2007 VB Code for GCF 7 18
Workbook link problems after copying tabs to a new workbook? David Miller (dlmille) Intro Have you either copied sheets to a new workbook, and after having saved and opened that workbook, you find that there are links back to the original sou…
Some code to ensure data integrity when using macros within Excel. Also included code that helps secure your data within an Excel workbook.
This Micro Tutorial will demonstrate how to create pivot charts out of a data set. I also added a drop-down menu which allows to choose from different categories in the data set and the chart will automatically update.
Although Jacob Bernoulli (1654-1705) has been credited as the creator of "Binomial Distribution Table", Gottfried Leibniz (1646-1716) did his dissertation on the subject in 1666; Leibniz you may recall is the co-inventor of "Calculus" and beat Isaac…

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question