Solved

# Calculation within Macro

Posted on 2013-10-24
Medium Priority
300 Views
Attached is my actual template file, the Master macro is intended to run a calculation for Amount, but what I would like to also do is add a forumla that calculates the Alloc %, the columns in green show the calculations but I am not sure how the code would look with this revision....

``````Public Sub HoursCalculation_V2()
'---------------------------------------------------------------------------------------
' Procedure : Update Percentage HoursCalculation
' Purpose   : This Procedure will walk through the columns and insert a formula instead
'             of the content of the asset is included in the vendor list
'---------------------------------------------------------------------------------------
Dim intNumber   As Integer
Dim intMonth    As Integer
Dim intColumns  As Integer
Dim rngEach     As Range
Dim rngData     As Range
Dim i           As Long
Dim lngRows     As Long

ThisWorkbook.Worksheets("InputFcst").Activate
lngRows = ActiveSheet.UsedRange.Cells(1, 1).Row + ActiveSheet.UsedRange.Rows.Count - 1
If lngRows < 4 Then
MsgBox ("No data found - run cancelled.")
Exit Sub
End If

'State how many columns you have for each month
' THE NUMBER 4 REPRESENTS HOW MANY COLUMNS THE CODE SHOULD SKIP FROM THE STARTING FROM THE COLUMN THAT RECEIVES THE FIRST FORMULA IN THIS CASE H4
intColumns = 4

'States the first cell that will be tested
' H4 RAPRESENT THE FIRST CELL THAT WILL RECEIVE THIS FORMULA
Set rngEach = Range("H4")

'States how many times you should change columns. In your workbook how many month that would be in the sheet
' THIS IS THE AMOUNT OF MONTHS, IN THIS CASE I AM UPDATING 12 MONTHS IF THE TEMPLATE CHANGES WE NEED TO UPDATE THIS VALUE
For intMonth = 1 To 12

Set rngData = rngEach.Offset(-1, (intMonth - 1) * intColumns).Resize(lngRows + 2, 1).Find(What:="", After:=rngEach.Offset(-1, (intMonth - 1) * intColumns), LookIn:=xlFormulas, _
LookAt:=xlWhole, SearchOrder:=xlByRows, SearchDirection:=xlNext, MatchCase:=False, SearchFormat:=False)
If rngData Is Nothing Then
MsgBox ("No data found for " & rngEach.Offset(-1, (intMonth - 1) * intColumns) & " - month skipped.")
MsgBox ("No data found for " & rngEach.Offset(-1, (intMonth - 1) * intColumns) & " - month skipped.")
Else
Range(rngEach.Offset(0, (intMonth - 1) * intColumns), rngData.Offset(-1, 0)).FormulaR1C1 _
= "=8*RC[2]*HLOOKUP(MID(R3C,1,3),WorkingDays!R1C1:R2C12,2,0)"
End If

Next

End Sub

Public Sub Forecast_Actual_Calc()
'---------------------------------------------------------------------------------------
' Procedure : Forecast_Actual_Calc
' Purpose   : This macro reads the headers and wherever it finds "Amount" at the end it
'             fills the rows below with the formula
'---------------------------------------------------------------------------------------

' THE CODE FINDS EVERYTHING WITH A HEADING OF "AMOUNT" AND CHANGES THE VALUE IN A CALCULATED FORMULAT OF (HOURS * RATE)
' IF COLUMN HEADINGS CHANGE OR THE POSITION OF THE HOURS AND RATE CHANGE THEN THE CODE MUST BE ADJUSTED
Dim cel As Range
For Each cel In Range("3:3").SpecialCells(xlCellTypeConstants)
If Right(cel, 6) = "Amount" Then
cel.Offset(1).Select
cel.Offset(1).Resize(cel.End(xlDown).Row - cel.Row).FormulaR1C1 = "=rc[-3]*rc[-2]"
End If
Next cel
End Sub

Public Sub Master_Macro()
Application.Run ("Forecast_Actual_Calc")
Application.Run ("HoursCalculation_V2()")
Application.Run ("Vlookup_for_ProjectCode")
End Sub
``````
Hours-Input.xlsm
0
Question by:joeserrone
• 2

LVL 14

Accepted Solution

Faustulus earned 1500 total points
ID: 39599629
Hello Joe,
Do you ralise that your little procedure 'Forecast_Actual_Calc pastes a formula into all of the following cells?
\$K\$4:\$K\$1048576
\$O\$4:\$O\$1048576
\$S\$4:\$S\$1048576
\$W\$4:\$W\$1048576
\$AA\$4:\$AA\$1048576
\$AE\$4:\$AE\$1048576
\$AI\$4:\$AI\$1048576
\$AM\$4:\$AM\$1048576
\$AQ\$4:\$AQ\$1048576
\$AU\$4:\$AU\$6
\$AY\$4:\$AY\$6
\$BC\$4:\$BC\$6
That are almost 10 million formulas, and they will make a difference to the size of your workbook and its speed. It will also take you a long time to delete them - or lose all the work you put into creating your workbook.

And all of this without mentioning that your code doesn't specify which worksheet to add these formulas to. It could be any one, even one in another workbook. All you got to do is press F5.

The long and the short of it is that it isn't a good idea to use code to write formulas. You should design one row with all the formulas the way you want them and then simply copy this row to as many other rows as you may need. If you want to use code for this purpose the code should be designed to add one row at a time, because that is all you need at any one time.

I shall be glad to help you re-design your workbook. Helping you write code to write formulas is no help for you and no fun for me. It just wastes both our time.
0

LVL 14

Expert Comment

ID: 39602271
Thank you Joe!
To help me keep my side of the bargain please post a link to your next question here so that I will be sure to see it.
All the best,
Faustulus
0

## Featured Post

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.