Solved

VBA To Change Cell Values If Certain Criteria Met

Posted on 2013-11-04
13
533 Views
Last Modified: 2013-11-13
Hello Experts -

I have the attached code that I need to update and I am not sure how to do it.

I need to change the pieces that look for the .001 or .999.

I need to look for any instance where the cell value rounded to the 3rd decimal place ends in .001 or .999.  If it does, then I need to change it end with either .002 or .998.

The number might be a positive or a negative number and may not be rounded at all, it could be .0008954 or something like that.

    For Each cell In rgsearch
        If IsError(cell.Value) Then
            xlws.Range(pbcol & cell.Row & ":" & pecol & cell.Row).ClearContents
        End If
        If Not IsNumeric(cell.Value) Or (cell.Value = "") Then
            'Debug.Print cell.Row
            xlws.Range(pbcol & cell.Row & ":" & pecol & cell.Row).ClearContents
        End If
        If (cell.Value > 0) And (cell.Value <= 0.001) Then
            cell.Value = 0.002
        End If
        If (cell.Value > 100) And (cell.Value <= 100.001) Then
            cell.Value = 100.002
        End If
        If (cell.Value < 0) And (cell.Value >= -0.001) Then
           cell.Value = -0.002
        End If
        If (cell.Value > 99.998) And (cell.Value <= 99.999) Then
            cell.Value = 99.998
        End If
    Next cell

Open in new window

0
Comment
Question by:rsburge
  • 8
  • 5
13 Comments
 
LVL 61

Expert Comment

by:mbizup
Comment Utility
What you're describing sounds like string manipulation.

Try adding this where you need the formatting done:


Dim s as string

s = Right(FormatNumber(cell.Value, 3), 3)
If  s = "999" then Cell.Value = "" & Left(cell.Value, instr(1, Cell.Value, ".") & "998"
if s = "001" then Cell.Value = "" & Left(cell.Value, instr(1, Cell.Value, ".") & "002"

Open in new window

0
 

Author Comment

by:rsburge
Comment Utility
Hi - This actually isn't working.

A specific example is the cell value is 0.000083549.  Rounded to the 3rd decimal place, this would be 0.001.

I need to change the cell value completely from 0.000083549 to 0.002.

Or, if the cell value were 100.999000201, then the cell value would need to change to 100.998.
0
 
LVL 61

Expert Comment

by:mbizup
Comment Utility
Okay - see if this works (read the inline comments for my train of thought):

dim x as double

' round the cell value to three decimal places
x = round(cell.Value, 3)

'  x - int(x) gives you the decimal portion
select case (x - int(x))

     ' If the decimal portion is .999 update the cell to the int part + .998 decimal
     Case .999
          cell.Value = int(x) + .998

     ' If the decimal portion is .001 update the cell to the int part + .002 decimal
     Case .001
           cell.Value = int(x) + .002

     ' If it is neither, do nothing.  Select case block gives you room for more options
     Case Else
            ' do nothing

End Select

Open in new window

0
 
LVL 61

Expert Comment

by:mbizup
Comment Utility
Just a note --

Your example doesn't look quite right:

<<
A specific example is the cell value is 0.000083549.  Rounded to the 3rd decimal place, this would be 0.001.
>>

 0.000083549 rounded to the 3rd decimal is actually zero.  Double-check your data and requirements - you'll have to use Round(x, 4) if you are really looking for .0001 for this number.
0
 

Author Comment

by:rsburge
Comment Utility
Thank you.  The select case works if the cell value rounded to the 3rd place is exactly 0.001 or 0.999.

However, if the cell value rounded to the 3rd place is anything else, say 99.001 or 102.001 or 2.001 or 98.999, it doesn't work.
0
 
LVL 61

Assisted Solution

by:mbizup
mbizup earned 500 total points
Comment Utility
Aha!  There's a floating point arithmetic error creeping in on the line that subtracts out the integer portion... so we need to round that expression to 3 decimal points too.

I've modified it below...

dim x as double

' round the cell value to three decimal places
x = round(cell.Value, 3)

'  x - int(x) gives you the decimal portion --- *** we need to round this result too.
select case  Round((x - int(x)), 3)

     ' If the decimal portion is .999 update the cell to the int part + .998 decimal
     Case .999
          cell.Value = int(x) + .998

     ' If the decimal portion is .001 update the cell to the int part + .002 decimal
     Case .001
           cell.Value = int(x) + .002

     ' If it is neither, do nothing.  Select case block gives you room for more options
     Case Else
            ' do nothing

End Select

Open in new window

0
Enabling OSINT in Activity Based Intelligence

Activity based intelligence (ABI) requires access to all available sources of data. Recorded Future allows analysts to observe structured data on the open, deep, and dark web.

 

Author Comment

by:rsburge
Comment Utility
Thank you!  I need to go to a meeting, but will test it when I get back in a few hours.
0
 
LVL 61

Expert Comment

by:mbizup
Comment Utility
Sounds good
0
 
LVL 61

Accepted Solution

by:
mbizup earned 500 total points
Comment Utility
Actually, the two rounds might be overkill.  You could probably do just this, only rounding after extracting the decimal portion:


dim x as double

' set x to hold the cell value
x =  cell.Value

'  x - int(x) gives you the decimal portion --- *** we need to round this to 3 decimal places
select case  Round((x - int(x)), 3)

     ' If the decimal portion is .999 update the cell to the int part + .998 decimal
     Case .999
          cell.Value = int(x) + .998

     ' If the decimal portion is .001 update the cell to the int part + .002 decimal
     Case .001
           cell.Value = int(x) + .002

     ' If it is neither, do nothing.  Select case block gives you room for more options
     Case Else
            ' do nothing

End Select

Open in new window

0
 

Author Comment

by:rsburge
Comment Utility
I am so sorry for the delay.  We found out my mother in law has lung cancer and I completely forgot about this question.

The 2nd solution is working, but will try the last solution as well, then I will close this question.

Thank you for your help!
0
 
LVL 61

Expert Comment

by:mbizup
Comment Utility
I'm very sorry to hear that!  Take your time, and no worries.
0
 

Author Closing Comment

by:rsburge
Comment Utility
Thank you so much for your help and for your patience.

Both solutions work perfectly and there really is no difference in the amount of time it takes to run one versus the other.
0
 
LVL 61

Expert Comment

by:mbizup
Comment Utility
Glad to help out :)
0

Featured Post

Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

Join & Write a Comment

When trying to find the cause of a problem in VBA or VB6 it's often valuable to know what procedures were executed prior to the error. You can use the Call Stack for that but it is often inadequate because it may show procedures you aren't intereste…
When designing a form there are several BorderStyles to choose from, all of which can be classified as either 'Fixed' or 'Sizable' and I'd guess that 'Fixed Single' or one of the other fixed types is the most popular choice. I assume it's the most p…
Familiarize people with the process of utilizing SQL Server views from within Microsoft Access. Microsoft Access is a very powerful client/server development tool. One of the SQL Server objects that you can interact with from within Microsoft Access…
In Microsoft Access, learn different ways of passing a string value within a string argument. Also learn what a “Type Mis-match” error is about.

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

9 Experts available now in Live!

Get 1:1 Help Now