Solved

BlockingQueue thread-safe?

Posted on 2013-11-06
2
481 Views
Last Modified: 2013-11-21
Am I passing the BlockingQueue to frame2 properly?
Am I utilizing BlockingQueue in a thread-safe way?

frame1.java....

package package1;

import java.awt.BorderLayout;

public class frame1 extends JFrame {

	private JPanel contentPane;
	private BlockingQueue<String> queue = new ArrayBlockingQueue<String>(10);
	private JTextField textField;

	/**
	 * Launch the application.
	 */
	public static void main(String[] args) {
		EventQueue.invokeLater(new Runnable() {
			public void run() {
				try {
					frame1 frame = new frame1();
					frame.setVisible(true);
					frame.Go();
				} catch (Exception e) {
					e.printStackTrace();
				}
			}

		
		});
	}

	private void Go() {
		// TODO Auto-generated method stub
		SwingWorker<String,String> sw = new SwingWorker<String,String>() {

			@Override
			protected String doInBackground() throws Exception {
				// TODO Auto-generated method stub
				while(true)
					{
					publish(queue.take());
					}

			}

			@Override
			protected void done() {
				// TODO Auto-generated method stub
				super.done();
			}

			@Override
			protected void process(List<String> arg0) {
				// TODO Auto-generated method stub
				textField.setText(arg0.get(0));
				super.process(arg0);
			}
		};
		sw.execute();
		
	}

	/**
	 * Create the frame.
	 */
	public frame1() {
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		setBounds(100, 100, 450, 300);
		contentPane = new JPanel();
		contentPane.setBorder(new EmptyBorder(5, 5, 5, 5));
		contentPane.setLayout(new BorderLayout(0, 0));
		setContentPane(contentPane);
		
		JPanel panel = new JPanel();
		contentPane.add(panel, BorderLayout.CENTER);
		
		textField = new JTextField();
		panel.add(textField);
		textField.setColumns(10);
		
		JButton btnLaunchFrame = new JButton("Launch frame2");
		btnLaunchFrame.addActionListener(new ActionListener() {
			public void actionPerformed(ActionEvent e) {
				frame2 f = new frame2(queue);
				f.setVisible(true);
			}
		});
		panel.add(btnLaunchFrame);
	}

}

Open in new window


frame2.java...

package package1;

import java.awt.BorderLayout;

public class frame2 extends JFrame {

	private JPanel contentPane;


	/**
	 * Create the frame.
	 */
	public frame2(final BlockingQueue<String> queue) {
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		setBounds(100, 100, 244, 146);
		contentPane = new JPanel();
		contentPane.setBorder(new EmptyBorder(5, 5, 5, 5));
		contentPane.setLayout(new BorderLayout(0, 0));
		setContentPane(contentPane);
		
		JPanel panel = new JPanel();
		contentPane.add(panel, BorderLayout.CENTER);
		
		JButton btnClose = new JButton("Close and update queue");
		btnClose.addActionListener(new ActionListener() {
			public void actionPerformed(ActionEvent arg0) {
				try {
					queue.put("hello");
				} catch (InterruptedException e) {
					// TODO Auto-generated catch block
					e.printStackTrace();
				}
				setVisible(false);
			}
		});
		panel.add(btnClose);
	}

}

Open in new window

0
Comment
Question by:pdering
2 Comments
 
LVL 35

Expert Comment

by:mccarl
Comment Utility
Am I passing the BlockingQueue to frame2 properly?
Yes, that appears fine to me.

Am I utilizing BlockingQueue in a thread-safe way?
Yes, that also is fine. The idea of a BlockingQueue is to be able to use it across multiple threads in the way that you have done.
0
 
LVL 26

Accepted Solution

by:
dpearson earned 500 total points
Comment Utility
I agree this code looks basically fine.

One small suggestion is to consider using:

poll()

instead of:

take()

You may find it makes shutdown easier to handle.

E.g. You could have poll() with a timeout of 1 second and then check to see if a flag is set to indicate "shutdown please".  If not, then loop around and wait for the next object.

take() blocks forever, so the only way to handle shutdown there is either to completely kill the thread (not always what you want) or use a custom 'shutdown' task that you add to the queue - although that won't be seen until all other tasks ahead of it are completed.

As I say, just something to consider.

Doug
0

Featured Post

How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

Join & Write a Comment

Suggested Solutions

Are you developing a Java application and want to create Excel Spreadsheets? You have come to the right place, this article will describe how you can create Excel Spreadsheets from a Java Application. For the purposes of this article, I will be u…
Basic understanding on "OO- Object Orientation" is needed for designing a logical solution to solve a problem. Basic OOAD is a prerequisite for a coder to ensure that they follow the basic design of OO. This would help developers to understand the b…
Viewers learn how to read error messages and identify possible mistakes that could cause hours of frustration. Coding is as much about debugging your code as it is about writing it. Define Error Message: Line Numbers: Type of Error: Break Down…
This theoretical tutorial explains exceptions, reasons for exceptions, different categories of exception and exception hierarchy.

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now