Still celebrating National IT Professionals Day with 3 months of free Premium Membership. Use Code ITDAY17

x
Solved

# If file exists and is older

Posted on 2013-11-26
Medium Priority
632 Views
I'm trying to create a batch file or vbs script that will check to see if there is a new version of a map file on our server, if there is a newer version then I would like it to copy the file off the server to a local c drive, then rename the old file on the local drive to mapfile.old. I also need the batch file or script to ensure I only have one version of the mapfile.old. So at any given time there should only be two files on the local c drive, mapfile.map and mapfile.old. I Know that I can use xcopy to copy the file only if the source is new than the destination but I'm out of thoughts on how to make the rename and deletion only occur if a new file was copied.  The xcopy I am using look like this: xcopy \\x\ManifoldUserUpdates\FisherUS\Maps\nolinkcwpkey.m
ap "c:\fisherus\program files\fisherus\maps"
0
Question by:cwpower
[X]
###### Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

• Help others & share knowledge
• Earn cash & points
• 3
• 2
• 2
• +2

LVL 57

Expert Comment

ID: 39677762
So, you only want to copy the .MAP file to the .OLD file when a new .MAP file exists on the server, and will be copied down via XCOPY?

How large is the .MAP file, one approach would be to just always copy the existing .MAP to the .OLD (overwriting), but that is a bit less efficient.

~bp
0

Author Comment

ID: 39677782
Correct the local .map should only be renamed to .old if a new file is copied down. I always need the newest file to have its original name as my end users have shortcut to it on their desktop. The file is currently copied down via xcopy but if there is a more efficient way to do so that would be ok. The file is about 1 GB in size and this batch will run on around 20 computers.
0

LVL 35

Accepted Solution

Dan Craciun earned 668 total points
ID: 39677795
Can't test it now, but this should work:

$localCopy = Get-ChildItem "\path\to\file.map"$localBackup = Get-ChildItem "\path\to\file.old"
$networkCopy = Get-ChildItem "\\path\to\file.map"$localCopyTime = $localCopy.LastWriteRime$networkCopyTime = $networkCopy.LastWriteTime if ($networkCopyTime -gt $localCopyTime) { Copy-Item$localCopy -Destination $localBackup Copy-Item$networkCopy -Destination $localCopy } Replace the paths with your paths. It simply compares last modified date from the file on the server with the local copy. HTH, Dan 0 LVL 35 Expert Comment ID: 39677807 Yes, it's better to simply delete and rename the backup, so you can use instead of Copy-Item$localCopy -Destination $localBackup Remove-Item$localBackup
Rename-Item $localCopy$localBackup
0

LVL 43

Assisted Solution

Steve Knight earned 668 total points
ID: 39677832
Various ways, one of which I thought of involves checking the source and dest time stamps and file sizes and comparing:

Steve

@echo off
set dest=c:\fisherus\program files\fisherus\maps

for %%A in (%source%\%filename%.map) do set sourcefile=%%~tA#%%~zA
for %%A in (%dest%\%filename%.map) do set destfile=%%~tA#%%~zA

echo Source file is %sourcefile%
echo Dest file is %destfile%

if "%sourcefile%"=="%destfile%" (
echo Nothing to change
) ELSE (
echo copying new version
IF EXIST "%dest%\%filename%.old" del "%dest%\%filename%.old"
IF EXIST "%dest%\%filename%.map" rename "%dest%\%filename%.map" "%filename%.old"
xcopy "%source%\%filename%.map" "%dest%" /y
)
0

LVL 85

Assisted Solution

oBdA earned 664 total points
ID: 39677840
Plain batch; for security reasons, it only deletes the original after the file has been successfully copied. If it fails, it will leave with errorlevel 1:
@echo off
setlocal
set SourceFile=\\Server\share\mapfile.map
set TargetFile=D:\temp\mapfile.map
for %%a in ("%SourceFile%") do (set SourceDate=%%~ta)
for %%a in ("%TargetFile%") do (
set TargetDate=%%~ta
set TargetFolder=%%~dpa
set TargetName=%%~na
set TargetExt=%%~xa
)
if "%SourceDate%"=="%TargetDate%" (
echo Both files have the same time stamp of %SourceDate%; leaving.
exit /b 1
)
REM When we're here, the file dates differ. Backup the old file and copy the new one from the serverlist
echo The files differ:
echo Source date: %SourceDate%
echo Target date: %TargetDate%
echo Copying '%SourceFile%', this might take a while ...
copy "%SourceFile%" "%TargetFolder%%TargetName%.new"
if errorlevel 1 (
echo Could not copy the source file '%SourceFile%'; leaving.
if exist "%TargetFolder%\%TargetName%.new" del "%TargetFolder%\%TargetName%.new"
exit /b 1
)
REM When we're here, we now have three file versions: .ext, .new, .old
if exist "%TargetFolder%%TargetName%.old" del "%TargetFolder%%TargetName%.old"
if exist "%TargetFile%" "%TargetName%.old" ren "%TargetFile%" "%TargetName%.old"
ren "%TargetFolder%%TargetName%.new" "%TargetName%%TargetExt%"
echo Done.

0

Author Comment

ID: 39677961
Thanks to everyone for the help! Multiple solutions are viable and work as intended.
0

LVL 85

Expert Comment

ID: 39677999
For the sake of completeness, I just saw an error in line 29 (you probably found it, but if somebody else finds it useful) in http:a39677840; the first "%TargetName%.old" should of course not be there and needs to be removed:
if exist "%TargetFile%" "%TargetName%.old" ren "%TargetFile%" "%TargetName%.old"
0

LVL 35

Expert Comment

ID: 39678020
oBdA, your solution was the only one that checked to see if the file was actually copied from the server. Good job.
0

LVL 43

Expert Comment

ID: 39678804
No problem, always lots of ways to solve things.

Steve
0

## Featured Post

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

If like me you are one who spends a lot of time working and scripting with cmd.exe, sometimes it is handy to be able to quickly view a calendar for a given month and year. This script will quickly do just that!  Save the code posted below to a .bat …
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
Do you want to know how to make a graph with Microsoft Access? First, create a query with the data for the chart. Then make a blank form and add a chart control. This video also shows how to change what data is displayed on the graph as well as form…
In this video, Percona Director of Solution Engineering Jon Tobin discusses the function and features of Percona Server for MongoDB. How Percona can help Percona can help you determine if Percona Server for MongoDB is the right solution for …
###### Suggested Courses
Course of the Month4 days, 8 hours left to enroll