Solved

LOWORD/HIWORD vs GET_X_LPARAM/GET_Y_LPARAM and MAKELONG vs MAKELPARAM

Posted on 2013-11-28
3
1,410 Views
Last Modified: 2013-11-29
Hi!

While searching for something else, I ran across the statement that in Windows functions interpreting coordinates, one should use GET_X_LPARAM/GET_Y_LPARAM instead of LOWORD/HIWORD on the lParam parameter. Also it seems one should use MAKELPARAM instead of MAKELONG.

I do understand the difference, but feel a little uncertain about the benefits and pitfalls by simply replacing:

- LOWORD -> GET_X_LPARAM
- HIWORD -> GET_Y_LPARAM
- MAKELONG -> MAKELPARAM

in all of my company's code.

First about the need to do this: is it correct that the only problem with not changing this is that things might (or certainly will?) not work if your multiple monitor setup is different from having the main monitor to the left and others as extensions to the right of it?

Or does it even then work as long as you avoid some very specific functions?

Then to the pitfalls: if we simply do the replacements above in all our code, is there any reason to believe something that works correct now doesn't work the same afterwards?

I am guessing not, but I would like to be very sure before I suggest such a change in all our code.

Thank you for any insight into this!
0
Comment
Question by:Knut Hunstad
3 Comments
 
LVL 51

Accepted Solution

by:
Ted Bouskill earned 250 total points
ID: 39684757
It will definitely cause problems with many functions if there are multiple monitors.  There is no harm to making the change.  I'd do it.
0
 
LVL 33

Assisted Solution

by:sarabande
sarabande earned 250 total points
ID: 39684806
#define GET_X_LPARAM(lp)  ((int)(short)LOWORD(lp))

Open in new window

in vs2010 both macros are identically beside that the result is int or short. because of that you could use the GET_X_LPARAM if you don't use short (16-bit) integers.

generally all those macros are helpers only. you can trust that for existing API the results will not change. for new api things are different. for example LPARAM turned to a 64-bit integer type what allows to pass a 64-bit pointer (address). for newer code you probably would avoid bit masking and pass pointers or handles which may point to larger objects and structures. then you would not use those macros at all but use your own functions to resolve the parameters.

Sara
0
 
LVL 8

Author Comment

by:Knut Hunstad
ID: 39684865
Actually, I have now tested with some weird 2 monitor setups and confirmed that HIWORD/LOWORD don't work correctly! I'll go for a global replace in all our code.

Thanks for the input reassuring me that this is risk free and necessary!
0

Featured Post

Free Tool: Postgres Monitoring System

A PHP and Perl based system to collect and display usage statistics from PostgreSQL databases.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

What my article will show is if you ever had to do processing to a listbox without being able to just select all the items in it. My software Visual Studio 2008 crystal report v11 My issue was I wanted to add crystal report to a form and show…
A theme is a collection of property settings that allow you to define the look of pages and controls, and then apply the look consistently across pages in an application. Themes can be made up of a set of elements: skins, style sheets, images, and o…
This is Part 3 in a 3-part series on Experts Exchange to discuss error handling in VBA code written for Excel. Part 1 of this series discussed basic error handling code using VBA. http://www.experts-exchange.com/videos/1478/Excel-Error-Handlin…
This video shows how to quickly and easily add an email signature for all users on Exchange 2016. The resulting signature is applied on a server level by Exchange Online. The email signature template has been downloaded from: www.mail-signatures…

820 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question