Link to home
Start Free TrialLog in
Avatar of dzash2000
dzash2000Flag for United States of America

asked on

How do I change the border around a fancybox/vimeo video??

Hi-

I'm using Fancybox to display videos hosted on Vimeo.  The problem is that when the videos open they have this thick border around them.  The border is imposed by fancybox - not Vimeo.  

I want to remove this border completely.

I've used "Inspect Element" and it always indicates that
.fancybox-skin

Open in new window

is the correct selector to change but when I make the changes on the actual mark up - nothing happens.

I can change the color of it using
.fancybox-skin {background:#; }

Open in new window

but if I add
border:0;

Open in new window

in the same class no change will be seen.

Please take a look at the web page showing what I'm talking about here and provide some instructions on how I can remove that thick white border around the video.

Thanks.
Avatar of QuinnDex
QuinnDex

the white border isnt a border, its padding

change this line

<div class="fancybox-wrap fancybox-desktop fancybox-type-iframe fancybox-opened" tabindex="-1" style="width: 830px; height: auto; position: absolute; top: 69px; left: 523px; opacity: 1; overflow:

Open in new window


to

<div class="fancybox-wrap fancybox-desktop fancybox-type-iframe fancybox-opened" tabindex="-1" style="width: 800px; height: auto; position: absolute; top: 69px; left: 523px; opacity: 1; overflow:

Open in new window


and this line

<div class="fancybox-skin" style="padding: 15px; width: auto; height: auto;">

Open in new window


to

<div class="fancybox-skin" style="padding: 0px; width: auto; height: auto;">

Open in new window

Avatar of dzash2000

ASKER

QuinnDex - thanks for the reply.

I understand that the white border is the result of padding.

I can't find the lines you're instructing me to change.

I opened jquery.fancybox.css and changed .fancybox-skin so that padding:0px.

I could not find all the selectors you list in your first instruction grouped together anywhere but where ever I did find one of them I made sure that any padding was "0px;".  Then I included your exact change within style tags at the top of the page.  

I tried putting your CSS inline around the link to the vimeo player link, and then the div around it, and then the div around that.

None of these steps even remotely achieved the effect I'm looking for.

Perhaps if you can explain where your suggested changes should be made - that might help me.

Thanks.
that i cant say, all i can see is what is in the page  the first line is the video container and its 30px larger than the actual video.

the video div itself has a 15px padding creating a 15px border


using firebug i was able to change these values and remove the border, you will need to look through your code and locate where these lines are or where they are generated and make the changes. the values ar not in the css they are in the code itself
You basically handed over the styling on the page to fancybox.  If you want to get rid of its bloated scripted presentation you will either need to got through the fancybox script files to find the spot where it is overriding, or toss it out and do your own presentation.

When you use third party code it is great until you want to do something the author either did not anticipate or does not have the skills to put in the hooks.  So when you commit to a plugin you need to make sure it allows access to ALL the code easily, or you learn to do things yourself so you don't have to overcome limitations imposed by someone else.

Cd&
It is frustrating to get a piece of information from Firebug that cannot be acted upon - but that is the situation that prompted me to ask the question in the first place.
Fancybox is like a lot of other third party junk.  It assumes that you are using a plugin because you are not capable of the complexity of DOM manipulation.  Based on that assumption hacks and junk code that ignores best practice can be used because you don't need to do maintenance to change the author's "perfect design".

The worst of it is that after you find the script fragment and make a change, you will now have a new problem.  You will no longer be able to rely on an update of the plugin.  An update will either knock out your change; or you will be forever stuck with the version you have.

Cd&
You've described the world I live in.  In order to build something for the web on a budget (time & money) I rely on 3rd party code.  Once I do finish something I never upgrade any JS - for exactly the reason you state.
ASKER CERTIFIED SOLUTION
Avatar of Robert Schutt
Robert Schutt
Flag of Netherlands image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
An elegant solution.  Thanks for looking and responding.