Zip selected files

Forgot to mention that I have 'winrar' installed on the computer

This is bad style:

   if InStr(strfile.datecreated, strdate) > 0 then

Select allOpen in new window

You should always compare dates with dates. Using string comparision provokes issues.

I take it the target ZIP files do not exist yet, and you want to create a single ZIP for each source file. I'm not clear about whether you want to copy or move the files, however.

' Isalogs & Export are shared folders

Dim dt, strSrc, strDst, fso, srcFile, dstFile

dt        = Date() 
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"

Set fso  = CreateObject("Scripting.FileSystemObject") 
set shApp= CreateObject("Shell.Application")

For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then
    dstFile = strDst + srcFile.BaseName + '.zip'
    If not fso.FileExists(dstFile) Then
      With fso.CreateTextFile(dstFile, True)
        .Write "PK" + chr(5) + char(6) + String(18, chr(0))
      End With
    shApp.NameSpace(dstFile).CopyHere srcFile.FullName
    WScript.Sleep 250
  End If
Next

Select allOpen in new window

This copies the files. The sleep is recommended as the compression is done in the background, and the code not waiting for completion. If you do not wait, you'll start a compression thread for each file (almost) simultanously, slowing down all file operations.

Ah, WinRAR, but you do not need it here, as you can see.

Hi,

Thanks for your answer...I have done some changes to your script as it was coming with some errors. I also modifi3ed the date check for testing purposes. Now I'm getting an error message

Object required shApp.NameSpace(...).

Also , I forgot to say that I want all selected file to be zipped together.


I will really appreciate if I can also have the script lines if I wanted to use winrar.

Thanks
Cheers




Dim dt, strSrc, strDst, fso, srcFile, dstFile

dt        = Date() - 1
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"
Newname    = replace(date,"/","")
ZipFile    = "Isalogs" & newname & ".zip"

Set fso  = CreateObject("Scripting.FileSystemObject")
set shApp= CreateObject("Shell.Application")


For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then
     If not fso.FileExists(zipfile) Then
      With fso.CreateTextFile(strdst & zipfile, True)
        .Write "PK" + chr(5) + chr(6) + String(18, chr(0))
      End With
     End if
     shApp.NameSpace(zipFile).CopyHere srcFile.Name
     WScript.Sleep 250
  End If
Next

For the integrated ZIP folder feature you need to use full paths; zipfile is only the filename. Further you used date instead of dt

Dim dt, strSrc, strDst, fso, srcFile, dstFile, ZipFile

dt        = Date() - 1
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"
ZipFile    = strDst + "Isalogs" + replace(dt,"/","") + ".zip"

Set fso  = CreateObject("Scripting.FileSystemObject") 
set shApp= CreateObject("Shell.Application")

For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then
     If not fso.FileExists(zipfile) Then
      With fso.CreateTextFile(zipfile, True)
        .Write "PK" + chr(5) + chr(6) + String(18, chr(0))
      End With
     End if
     shApp.NameSpace(zipFile).CopyHere srcFile.FullName
     WScript.Sleep 250
  End If
Next

Select allOpen in new window

Using WinRAR would look like (you might have to tweak the options):

Dim dt, strSrc, strDst, fso, srcFile, dstFile, ZipFile, shell

dt        = Date() - 1
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"
ZipFile    = strDst + "Isalogs" + replace(dt,"/","") + ".zip"

Set fso  = CreateObject("Scripting.FileSystemObject") 
set shell= CreateObject("WScript.Shell")

For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then strFiles = strFiles + " " + srcFile.FullName
Next
If strFile != "" Then
  shell.Run "winrar a -afzip " + ZipFile + strFiles
End If

Select allOpen in new window

Qlemo,

In the revised script, I have a problem with Line 18

Object doesn't support the property or method of  ;'Fullname'

Good job. Thanks a lot

Cool man. Thanks again

Cheers