Solved

Zip selected files

Posted on 2013-12-08
10
278 Views
Last Modified: 2013-12-11
I have this script that checks for selected files in "strsource". From there I need to be able to zip these files to "strdest".  I really don't know how to do that.


' Isalogs & Export are shared folders

Dim Strdate, StrSource, StrDest, Fso, objFolder, colFiles, objFile, strFile

Set fso = CreateObject("Scripting.FileSystemObject")

set wshshell = wscript.createobject("wscript.shell")

strDate = Date()
strSource = "\\isaserver\isalogs\"
strDest   = "\\isaserver\export\"

If fso.FolderExists(strSource) Then
   Set objFolder = fso.GetFolder(strSource)
   Set colFiles = objFolder.Files
End if
 
For Each strFile in colFiles
    if InStr(strfile.datecreated, strdate) > 0 then
   ??????????????????      
    end if
Next
0
Comment
Question by:Bianchi928
  • 5
  • 4
10 Comments
 

Author Comment

by:Bianchi928
Comment Utility
Forgot to mention that I have 'winrar' installed on the computer
0
 
LVL 68

Expert Comment

by:Qlemo
Comment Utility
This is bad style:
   if InStr(strfile.datecreated, strdate) > 0 then

Open in new window

You should always compare dates with dates. Using string comparision provokes issues.

I take it the target ZIP files do not exist yet, and you want to create a single ZIP for each source file. I'm not clear about whether you want to copy or move the files, however.
' Isalogs & Export are shared folders

Dim dt, strSrc, strDst, fso, srcFile, dstFile

dt        = Date() 
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"

Set fso  = CreateObject("Scripting.FileSystemObject") 
set shApp= CreateObject("Shell.Application")

For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then
    dstFile = strDst + srcFile.BaseName + '.zip'
    If not fso.FileExists(dstFile) Then
      With fso.CreateTextFile(dstFile, True)
        .Write "PK" + chr(5) + char(6) + String(18, chr(0))
      End With
    shApp.NameSpace(dstFile).CopyHere srcFile.FullName
    WScript.Sleep 250
  End If
Next

Open in new window

This copies the files. The sleep is recommended as the compression is done in the background, and the code not waiting for completion. If you do not wait, you'll start a compression thread for each file (almost) simultanously, slowing down all file operations.
0
 
LVL 68

Expert Comment

by:Qlemo
Comment Utility
Ah, WinRAR, but you do not need it here, as you can see.
0
 

Author Comment

by:Bianchi928
Comment Utility
Hi,

Thanks for your answer...I have done some changes to your script as it was coming with some errors. I also modifi3ed the date check for testing purposes. Now I'm getting an error message

Object required shApp.NameSpace(...).

Also , I forgot to say that I want all selected file to be zipped together.


I will really appreciate if I can also have the script lines if I wanted to use winrar.

Thanks
Cheers




Dim dt, strSrc, strDst, fso, srcFile, dstFile

dt        = Date() - 1
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"
Newname    = replace(date,"/","")
ZipFile    = "Isalogs" & newname & ".zip"

Set fso  = CreateObject("Scripting.FileSystemObject")
set shApp= CreateObject("Shell.Application")


For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then
     If not fso.FileExists(zipfile) Then
      With fso.CreateTextFile(strdst & zipfile, True)
        .Write "PK" + chr(5) + chr(6) + String(18, chr(0))
      End With
     End if
     shApp.NameSpace(zipFile).CopyHere srcFile.Name
     WScript.Sleep 250
  End If
Next
0
Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

 
LVL 68

Expert Comment

by:Qlemo
Comment Utility
For the integrated ZIP folder feature you need to use full paths; zipfile is only the filename. Further you used date instead of dt
Dim dt, strSrc, strDst, fso, srcFile, dstFile, ZipFile

dt        = Date() - 1
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"
ZipFile    = strDst + "Isalogs" + replace(dt,"/","") + ".zip"

Set fso  = CreateObject("Scripting.FileSystemObject") 
set shApp= CreateObject("Shell.Application")

For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then
     If not fso.FileExists(zipfile) Then
      With fso.CreateTextFile(zipfile, True)
        .Write "PK" + chr(5) + chr(6) + String(18, chr(0))
      End With
     End if
     shApp.NameSpace(zipFile).CopyHere srcFile.FullName
     WScript.Sleep 250
  End If
Next

Open in new window

Using WinRAR would look like (you might have to tweak the options):
Dim dt, strSrc, strDst, fso, srcFile, dstFile, ZipFile, shell

dt        = Date() - 1
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"
ZipFile    = strDst + "Isalogs" + replace(dt,"/","") + ".zip"

Set fso  = CreateObject("Scripting.FileSystemObject") 
set shell= CreateObject("WScript.Shell")

For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then strFiles = strFiles + " " + srcFile.FullName
Next
If strFile != "" Then
  shell.Run "winrar a -afzip " + ZipFile + strFiles
End If

Open in new window

0
 

Author Comment

by:Bianchi928
Comment Utility
Qlemo,

In the revised script, I have a problem with Line 18

Object doesn't support the property or method of  ;'Fullname'
0
 
LVL 68

Accepted Solution

by:
Qlemo earned 300 total points
Comment Utility
Sorry for that, this part was taken over from a PowerShell script, which is different here. I see we have to use Path instead:
Dim dt, strSrc, strDst, fso, srcFile, dstFile, ZipFile

dt        = Date() - 1
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"
ZipFile    = strDst + "Isalogs" + replace(dt,"/","") + ".zip"

Set fso  = CreateObject("Scripting.FileSystemObject") 
set shApp= CreateObject("Shell.Application")

For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then
     If not fso.FileExists(zipfile) Then
      With fso.CreateTextFile(zipfile, True)
        .Write "PK" + chr(5) + chr(6) + String(18, chr(0))
      End With
     End if
     shApp.NameSpace(zipFile).CopyHere srcFile.Path
     WScript.Sleep 250
  End If
Next

Open in new window

respective
Dim dt, strSrc, strDst, fso, srcFile, dstFile, ZipFile, shell

dt        = Date() - 1
strSrc = "\\isaserver\isalogs\"
strDst = "\\isaserver\export\"
ZipFile    = strDst + "Isalogs" + replace(dt,"/","") + ".zip"

Set fso  = CreateObject("Scripting.FileSystemObject") 
set shell= CreateObject("WScript.Shell")

For Each srcFile in fso.GetFolder(strSrc).Files
  If srcFile.DateCreated >= dt Then strFiles = strFiles + " " + srcFile.Path
Next
If strFile != "" Then
  shell.Run "winrar a -afzip " + ZipFile + strFiles
End If

Open in new window

0
 

Author Comment

by:Bianchi928
Comment Utility
Good job. Thanks a lot
0
 

Author Comment

by:Bianchi928
Comment Utility
Cool man. Thanks again

Cheers
0

Featured Post

How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

Join & Write a Comment

I met Paul Devereux (@pdevereux) today when I responded to his tweet asking “Anybody know how to automate adding files from disk to a folder in #outlook  ?”.  I replied back and told Paul that using automation, in this case scripting, to add files t…
Deploying a Microsoft Access application in a Citrix environment is not difficult but takes a few steps. However, Citrix system people are often of little help, as they typically know next to nothing about Access. The script provided here will take …
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.
In this seventh video of the Xpdf series, we discuss and demonstrate the PDFfonts utility, which lists all the fonts used in a PDF file. It does this via a command line interface, making it suitable for use in programs, scripts, batch files — any pl…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

9 Experts available now in Live!

Get 1:1 Help Now