Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 795
  • Last Modified:

open xls workbook, check if already open

In MS Access I want to first check to see if Excel is open.  If so, check to see if a certain workbook is already open.  If not open it, otherwise set the open workbook as the active workbook.

Here is what I have so far.  Almost there but if it is already open it gives a warning about re-opening an open workbook.

Private Function UpdateCrisisChart()
Dim xls As Object
Dim wrk As Object
Dim Sheet As Object
Dim strExcelFile As String
        
    If IsExcelRunning Then
        Set xls = GetObject(, "Excel.Application")
    Else
        Set xls = CreateObject("Excel.Application")
    End If
    
    xls.Visible = True
    
    strExcelFile = GetExcelFilename(Me.SDate, "Adult")
    Set wrk = xls.Workbooks.Open(strExcelFile)
        
End Function

Open in new window

0
KCTechNet
Asked:
KCTechNet
  • 2
  • 2
2 Solutions
 
Rey Obrero (Capricorn1)Commented:
< but if it is already open it gives a warning about re-opening an open workbook.>

if you can get the error number from the warning message, grab that error code and
use it in your code to divert to the open workbook.
0
 
KCTechNetAuthor Commented:
Sounds good.  So on error trap, what do I use instead of .Open in:  
          Set wrk = xls.Workbooks.Open(strExcelFile)
0
 
KCTechNetAuthor Commented:
I should mention I am concerned if they have multiple workbooks open,  one of which is the one I need.  How do I set the one I want as active?
0
 
mbizupCommented:
You need to
1. error check to see if an existing instance of excel is open and respond accordingly
2. Check for the desired workbook and activate, create or open it accordingly

Try this, and read the inline explanations:

Sub DoStuffInExcel()


Dim xlApp As Excel.Application
Dim xlWB As Excel.Workbook
Dim xlWS As Excel.Worksheet
Dim wb As Excel.Workbook
Dim strPath As String
Dim blFound As Boolean

' This is the path/file we're working with -- change as needed
strPath = "c:\Test\TestXYZ.XLS"

On Error Resume Next
    Set xlApp = Nothing
    
    ' Try to use currently open application
    Set xlApp = GetObject(, "Excel.Application")
    
    ' If that fails, create a new application
    If Err = 429 Then
      Set xlApp = CreateObject("Excel.Application")
    End If
    
    On Error GoTo EH
    
    ' See if the workbook you need is currently open.  If so, set it as the workbook object.
    For Each wb In xlApp.Workbooks
        If wb.Name = Mid(strPath, InStrRev(strPath, "\") + 1) Then
            Set xlWB = wb
            blFound = True
            Exit For
        End If
    Next
    
    ' If not, then see if the file exists
    If blFound = False Then
        If Dir(strPath) = "" Then
            ' If it doesnt exist then create it
            Set xlWB = xlApp.Workbooks.Add
            xlWB.SaveAs strPath
        Else
            ' Otherwise open it
            Set xlWB = xlApp.Workbooks.Open(strPath)
        End If
    End If
    xlApp.Visible = True
    xlWB.Activate
    
    '  The rest of your code goes here
    
    
    
    
    ' Use the close and quit commands if needed.  If now, remove those lines but keep the = nothing lines.
    ' Close the workbook and clean up the objects
    xlWB.Close
    Set xlWB = Nothing
    ' Quit Excel and clean up the object
    xlApp.Quit
    Set xlApp = Nothing
    
    Exit Sub
    
EH:
    MsgBox "Error " & Err.Number & ": " & Err.Description
 
End Sub

Open in new window

0
 
mbizupCommented:
As an aside, I'm using "Early Binding" in my code, declaring the excel objects like this:

Dim xlApp As Excel.Application
Dim xlWB As Excel.Workbook
Dim xlWS As Excel.Worksheet
Dim wb As Excel.Workbook

Open in new window


This makes for easy programming, because you get auto completion of your commands in the VB Editor,

However, if compatibility across multiple versions of Office is a concern, use late binding instead - declaring these as generic Objects:

Dim xlApp As Object
Dim xlWB As Object
Dim xlWS As Object
Dim wb As Object

Open in new window


The downside to Late Binding is that you lose the intellisense/autocompletion in programming, and possibly take a slight performance hit.

I typically keep both versions in my code and switch between them - commenting out the late binding in favor of early binding to get auto completion, and then switching back to late binding before deploying an application so that it will work regardless of Office version.
0

Featured Post

Veeam Disaster Recovery in Microsoft Azure

Veeam PN for Microsoft Azure is a FREE solution designed to simplify and automate the setup of a DR site in Microsoft Azure using lightweight software-defined networking. It reduces the complexity of VPN deployments and is designed for businesses of ALL sizes.

  • 2
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now