Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 3572
  • Last Modified:

Copy and paste data between workbooks using VBA

Dear Experts:

below code ...
... prompts the user to open an excel file (source file)
... copies the data from the first worksheet of the source file
... pastes this data into the first worksheet of the currently active workbook (target file)

I would like somebody to tweak this code so that ...
(1) '/// The targetSheet is to be inserted as a separate sheet right at the very beginning.
(2) '/// Everything has to be copied, i.e. values, formulas, column and row widths
(3) '/// If a sheet with the same name already exists in the target workbook, a Msgbox has to say so and the macro is to abort!

Help is much appreciated. Thank you very much in advance.

Regards, Andreas


Private Sub Import_Data_Into_Current_Workbook()
Dim customerFilename As String
Dim customerWorkbook As Workbook
Dim targetWorkbook As Workbook

' active workbook is the target
Set targetWorkbook = Application.ActiveWorkbook

With Application.fileDialog(msoFileDialogOpen)

    .ButtonName = "&Open"
    .InitialFileName = "C:\MyFile\Data"
    .Filters.Clear
    .Filters.Add "Excel files (*.xls; *.xlsm; *.xlsx)", "*.xls;*.xlsm;*.xlsx", 1
    .Title = "Please Select an input file"
    .AllowMultiSelect = False
End With

  If Not (Application.fileDialog(msoFileDialogOpen).Show) Then
     MsgBox "No File specified!.", vbExclamation, "Cancel has been pressed!"
     Exit Sub
  Else
     customerFilename = Application.fileDialog(msoFileDialogOpen).SelectedItems(1)

Set customerWorkbook = Application.Workbooks.Open(customerFilename)

' copy data from customer to target workbook
'/// to be incorporated (1) The targetSheet is to be inserted as a separate sheet right at the very beginning.
Dim targetSheet As Worksheet
Set targetSheet = targetWorkbook.Worksheets(1)
Dim sourceSheet As Worksheet
Set sourceSheet = customerWorkbook.Worksheets(1)

'/// To be incorporated (2): Everything has to be copied, i.e. values, formulas, column and row widths
Intersect(sourceSheet.UsedRange, sourceSheet.UsedRange.Offset(0, 0)).Copy targetSheet.Range("A1")
'/// To be incorporated (3): If a sheet with the same name already exists in the target workbook, a msgbox has to say so and the macro is to abort!
targetSheet.Name = sourceSheet.Name

  End If

customerWorkbook.Close

End Sub

Open in new window

0
Andreas Hermle
Asked:
Andreas Hermle
  • 2
2 Solutions
 
Saqib Husain, SyedEngineerCommented:
Try replacing

Intersect(sourceSheet.UsedRange, sourceSheet.UsedRange.Offset(0, 0)).Copy targetSheet.Range("A1")

with

sourceSheet.Copy before:=targetWorkbook.Sheets(1)
If targetWorkbook.Sheets(1).Name <> sourceSheet.Name Then
    targetWorkbook.Sheets(1).Delete
    MsgBox ("That name already exists in target workbook")
    Exit Sub
End If
0
 
Rgonzo1971Commented:
Hi,

pls try

Private Sub Import_Data_Into_Current_Workbook()
Dim customerFilename As String
Dim customerWorkbook As Workbook
Dim targetWorkbook As Workbook

' active workbook is the target
Set targetWorkbook = Application.ActiveWorkbook

With Application.FileDialog(msoFileDialogOpen)

    .ButtonName = "&Open"
    .InitialFileName = "C:\MyFile\Data"
    .Filters.Clear
    .Filters.Add "Excel files (*.xls; *.xlsm; *.xlsx)", "*.xls;*.xlsm;*.xlsx", 1
    .Title = "Please Select an input file"
    .AllowMultiSelect = False
End With

  If Not (Application.FileDialog(msoFileDialogOpen).Show) Then
     MsgBox "No File specified!.", vbExclamation, "Cancel has been pressed!"
     Exit Sub
  Else
     customerFilename = Application.FileDialog(msoFileDialogOpen).SelectedItems(1)

Set customerWorkbook = Application.Workbooks.Open(customerFilename)


Dim sourceSheet As Worksheet
Set sourceSheet = customerWorkbook.Worksheets(1)

On Error Resume Next
Set srcSht = targetWorkbook.Sheets(sourceSheet.Name)
On Error GoTo 0
    If IsEmpty(srcSht) Then
    sourceSheet.Copy Before:=targetWorkbook.Sheets(1)
    Else
        MsgBox "Sheet name already there"
        Exit Sub

    End If
End If

customerWorkbook.Close

End Sub

Open in new window

Regards
0
 
Andreas HermleTeam leaderAuthor Commented:
Hi ssaqibh,

seems to work just great. I will do some more testing and then let you know.

Thank you very much for your great help.

Regards, Andreas
0
 
Andreas HermleTeam leaderAuthor Commented:
Dear both,

works just great, I can use both codes. Thank you very much for your great and professional help. Regards, Andreas
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now