Declaring variables

I'm having trouble with my declarations I think.
I can never decide if it should be a Long or Range or Cell etc etc.

I am struggling to get the attached code working as I keep getting "application defined or object defined error", which I presume means I got it wrong again regarding my declarations.  

As always any pointers are greatly appreciated, and maybe someone could point me in the right direction of any articles helping me understand Excel VBA declarations.

Thanks
Dim x As Range
Dim ws As Worksheet
Dim lr As Long
Set ws = ThisWorkbook.Sheets("Data")

lr = ws.Range("T1048576").End(xlUp).Row
    For Each x In ws.Range("T3:T" & lr).Cells
        If x.Value <> 0 Then
            ws.Range("AL1048576").End(xlUp).Offset(1).vlaue = x.Offset(1).Value
        End If
    Next x

Open in new window


I have tried a number of variations of the Range,Cell,Long etc etc to no avail.
LVL 1
Stephen ByromWarehouse/ShippingAsked:
Who is Participating?
 
Rory ArchibaldConnect With a Mentor Commented:
You have misspelled Value here:
ws.Range("AL1048576").End(xlUp).Offset(1).vlaue

Is this your actual code? If not, can you copy and paste the actual code here?
0
 
Alexander Eßer [Alex140181]Connect With a Mentor Software DeveloperCommented:
Do you mind sharing the Excel file or maybe a part of it?!
0
 
Saqib Husain, SyedEngineerCommented:
It looks ok to me. Which line are you getting the error?
0
Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

 
Saqib Husain, SyedConnect With a Mentor EngineerCommented:
Good catch rorya but that would not give the "Application...." error. Unless the error is wrongly reported here.
0
 
Rory ArchibaldCommented:
I know - hence my follow-up questions. :)
0
 
Stephen ByromWarehouse/ShippingAuthor Commented:
Sorry, I had to step out for a while......

I've been developing this workbook for some time now and I am starting to miss the obvious. Thanks rorya, and thanks to the rest for taking the time to comment.

regarding attaching the workbook for better clarity;
I have the slowest of connection speeds :( and attaching the file would have probably taken a week. (rural Ireland is not hot on technology) :)
0
All Courses

From novice to tech pro — start learning today.