Solved

jquery slideup slidedown shows twice

Posted on 2013-12-13
15
853 Views
Last Modified: 2013-12-21
Hi,

I have this website http://goo.gl/beU48M, I use jquery slideup slidedown to display error. I dont know why it run twice, could you please help me to fix it?

To show error, you can buy 1 deal, on the shopping cart, check remove and click update. Then you will see the yelow error bar on top of page, it runs twice.

Thank you
0
Comment
Question by:tkien
15 Comments
 
LVL 22

Expert Comment

by:Mrunal
ID: 39716298
Hi
Can you show your code?

Add debugger in your code and check yourself is that code is running twice.
0
 
LVL 82

Expert Comment

by:leakim971
ID: 39716353
Check this : http://validator.w3.org/check?uri=http%3A%2F%2Fv2.wpgroupbuy.com%2F&charset=%28detect+automatically%29&doctype=Inline&group=0

You've tons of errors in your page.
Especially duplicate ID attributes.
ID attributes must be unique in a page.
0
 

Author Comment

by:tkien
ID: 39716898
This is the Js file. The error id is #notification

jQuery(window).load(function() {
	jQuery('body').addClass("loaded");
	jQuery('#notification').has('.wg-message').slideDown('medium');
	jQuery('#notification').delay(5000).slideUp('fast');
	
	var sidebar_container = jQuery('.sidebar');
	if ( sidebar_container.width() > 600 ) {
		
		sidebar_container.masonry({
			itemSelector: '.widget',
			isResizable: true,
			gutterWidthInteger: 20,
			// set columnWidth a fraction of the container width
			columnWidth: sidebar_container.width() / 2
		});
	};
});

Open in new window

0
Master Your Team's Linux and Cloud Stack!

The average business loses $13.5M per year to ineffective training (per 1,000 employees). Keep ahead of the competition and combine in-person quality with online cost and flexibility by training with Linux Academy.

 
LVL 43

Expert Comment

by:Rob
ID: 39722600
You've got the wrong event to initialize this it should be

JQuery(document).ready(function() {
...
});

If you wrap the window.load event then it will call twice as you've seen and animate twice
0
 

Author Comment

by:tkien
ID: 39722970
I tried with tagit's solution but it still show message twice.
0
 
LVL 35

Assisted Solution

by:Robert Schutt
Robert Schutt earned 50 total points
ID: 39722973
In your page I find:
<script type="text/javascript" src="http://v2.wpgroupbuy.com/wp-content/themes/WPGroupbuy/js/jquery.template.js"></script>

Open in new window

*and*
<script type='text/javascript' src='http://v2.wpgroupbuy.com/wp-content/themes/WPGroupbuy/js/jquery.template.js?ver=2.0'></script>

Open in new window

This seems to be essentially the same script and the code that shows the notification is in there, and is indeed being executed twice.

So I would say, delete one of those references and it should be ok, but still of course you should take notice of the earlier remarks about creating valid html and deciding on right event to trigger on.
0
 
LVL 43

Assisted Solution

by:Rob
Rob earned 150 total points
ID: 39722993
Additionally to what robert_shutt has said, you're also including jQuery twice:

view-source:http://v2.wpgroupbuy.com/cart/

line 28: <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js"></script>

line 48: <script type='text/javascript' src='http://v2.wpgroupbuy.com/wp-includes/js/jquery/jquery.js?ver=1.10.2'></script>
0
 
LVL 43

Assisted Solution

by:Rob
Rob earned 150 total points
ID: 39722995
jquery UI twice

line 29: <script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jqueryui/1.8.23/jquery-ui.js"></script>

line 70-72:
<script type='text/javascript' src='http://v2.wpgroupbuy.com/wp-includes/js/jquery/ui/jquery.ui.core.min.js?ver=1.10.3'></script>
<script type='text/javascript' src='http://v2.wpgroupbuy.com/wp-includes/js/jquery/ui/jquery.ui.widget.min.js?ver=1.10.3'></script>
<script type='text/javascript' src='http://v2.wpgroupbuy.com/wp-includes/js/jquery/ui/jquery.ui.tabs.min.js?ver=1.10.3'></script>
0
 
LVL 43

Expert Comment

by:Rob
ID: 39722996
All these are going to cause conflicts unless you're separating them with .noConflict and assigning the returned object to a variable (other than jQuery)
0
 
LVL 43

Assisted Solution

by:Rob
Rob earned 150 total points
ID: 39723005
You've also got <script> tags all through your <body>.  This is something you should be aware of and how it affects the execution and redering of the page.
I personally have everything in the head.  If I need script to load after the page is ready then I do that with script.  the defer and async attributes can also be used for this purpose but I see no advantage to putting script tags in the <body>
0
 

Accepted Solution

by:
tkien earned 0 total points
ID: 39723008
thank you for comments, I found the issue, just add .not(":animated")

jQuery('#notification').has('.wg-message').not(":animated").slideDown('medium');

Open in new window


and it works :)
0
 
LVL 43

Expert Comment

by:Rob
ID: 39723017
That's called a hack :-). In other words you're masking an issue instead of fixing it.
you will still find other issues with your site unless you fix the issues listed here.
0
 

Author Closing Comment

by:tkien
ID: 39733422
Thank you all for support :) I've found other issues from your comments.
0

Featured Post

Networking for the Cloud Era

Join Microsoft and Riverbed for a discussion and demonstration of enhancements to SteelConnect:
-One-click orchestration and cloud connectivity in Azure environments
-Tight integration of SD-WAN and WAN optimization capabilities
-Scalability and resiliency equal to a data center

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Binding a Grid in Javascript 5 44
Explain this javascript function to me 2 27
Insert Button on a table 16 38
Wordpress Hacked 1 33
This article describes how to create custom column layout styles for Bootstrap. The article uses 5 columns to illustrate the concept, but the principle can be extended to any number of columns.
The article shows the basic steps of integrating an HTML theme template into an ASP.NET MVC project
The viewer will receive an overview of the basics of CSS showing inline styles. In the head tags set up your style tags: (CODE) Reference the nav tag and set your properties.: (CODE) Set the reference for the UL element and styles for it to ensu…
The viewer will learn how to create a basic form using some HTML5 and PHP for later processing. Set up your basic HTML file. Open your form tag and set the method and action attributes.: (CODE) Set up your first few inputs one for the name and …

829 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question