Solved

c++ std::mismatch problem with vector<string>

Posted on 2013-12-13
3
1,366 Views
Last Modified: 2013-12-14
ref: std::mismatch
http://www.cplusplus.com/reference/algorithm/mismatch/?kw=mismatch

In this reference is sample code that uses std::vector<int>. When I modify the program to use std::vector<std::string>, the mismatch() returns two bad pointers in the pair. I added a std::equal() and it appears to work correctly. I also modified the sample program for  set_intersection to use std::vector<std::string>,  and it worked ok.
http://www.cplusplus.com/reference/algorithm/set_intersection/

How do you fix this program using std::mismatch? I am actually using std::set<std::string> so I don't need to sort it. (I would like to keep this in the non-C++11 domain as the OS is older and does not support this.)


// mismatch algorithm example
#include <iostream>     // std::cout
#include <algorithm>    // std::mismatch
#include <vector>       // std::vector
#include <string>
#include <utility>      // std::pair

bool mypredicate (std::string i, std::string j) {
  return (i==j);
}

int main () {

  bool isSame=false;
  std::string myStrs[] = {"10","20","80","320","1024"};   // myStrs: 10 20 80 320 1024
  std::vector<std::string> myvector(myStrs, myStrs + 5);
  std::vector<std::string> myvector1(myvector.begin(), myvector.end());

  // std::equal works, but std::mismatch returns bad pointers
  isSame = std::equal(myvector.begin(), myvector.end(), myvector1.begin());
  std::pair< std::vector<std::string>::iterator,std::vector<std::string>::iterator> mypair;
  mypair = std::mismatch (myvector.begin(), myvector.end(), myvector1.begin());
  std::cout << "First mismatching elements: " << *mypair.first;
  std::cout << " and " << *mypair.second << '\n';

  ++mypair.first; ++mypair.second;

  // using predicate comparison:
  mypair = std::mismatch (myvector.begin(), myvector.end(), myvector1.begin(), mypredicate);
  std::cout << "Second mismatching elements: " << *mypair.first;
  std::cout << " and " << *mypair.second << '\n';

  return 0;
}

Open in new window

0
Comment
Question by:phoffric
  • 3
3 Comments
 
LVL 32

Author Comment

by:phoffric
ID: 39718244
Update: Although the intersection program worked with vector<string>, it did not compile with set<string>. But that can be another question. In case you are interested, the compiler error is on the std::set_intersection line. But when I make v (in line 12) a std::vector<std::string>, then it compiles, but gives an exception.
#include <iostream>     // std::cout
#include <algorithm>    // std::set_intersection, std::sort
#include <set>       // std::set
#include <vector>
#include <string>

int main () {
  std::string first[] = {"5","10","15","20","25"};
  std::string second[] = {"50","40","30","20","10"};
  std::set<std::string> f1(first, first+5);
  std::set<std::string> f2(second, second+5);
  std::set<std::string> v;
//  std::set<std::string>::iterator it;

  std::set_intersection (f1.begin(), f1.end(), f2.begin(), f2.end(), v.begin());

The compiler error is:
 error C2678: binary '=' : no operator found which takes a left-hand operand of type 'const std::basic_string<_Elem,_Traits,_Ax>' (or there is no acceptable conversion)

or

/usr/lib/gcc/i686-pc-cygwin/4.7.3/include/c++/bits/stl_algo.h: In instantiation of ‘_OIter std::set_intersection(_IIter1, _IIter1, _IIter2, _IIter2, _OIter) [with _IIter1 = std::_Rb_tree_const_iterator<std::basic_string<char> >; _IIter2 = std::_Rb_tree_const_iterator<std::basic_string<char> >; _OIter = std::_Rb_tree_const_iterator<std::basic_string<char> >]’:
set_intersection.cpp:17:79:   required from here
/usr/lib/gcc/i686-pc-cygwin/4.7.3/include/c++/bits/stl_algo.h:5914:6: error: passing ‘const std::basic_string<char>’ as ‘this’ argument of ‘std::basic_string<_CharT, _Traits, _Alloc>& std::basic_string<_CharT, _Traits, _Alloc>::operator=(const std::basic_string<_CharT, _Traits, _Alloc>&) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::basic_string<_CharT, _Traits, _Alloc> = std::basic_string<char>]’ discards qualifiers [-fpermissive]

Open in new window

0
 
LVL 32

Author Comment

by:phoffric
ID: 39718291
UPDATE #2: Got intersection program in my previous post to work by making line 12 std::vector<std::string> v(10);
0
 
LVL 32

Accepted Solution

by:
phoffric earned 0 total points
ID: 39719118
I added this code to the OP and now it works with vector<string>
  if (mypair.first == myvector.end()) {
     std::cout << "mypair.first == myvector.end()" << std::endl;
     exit(0);
  }

Open in new window

I will try using set<string> to see if that works.

Update: After changing to set<string> and testing for the no-mismatch case, the program does not crash. The bad ptr that I referred to in the OP was actually myvector.end() which cannot be dereferenced.
0

Featured Post

3 Use Cases for Connected Systems

Our Dev teams are like yours. They’re continually cranking out code for new features/bugs fixes, testing, deploying, testing some more, responding to production monitoring events and more. It’s complex. So, we thought you’d like to see what’s working for us.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
SendMessage fails while PostMessage works 2 114
C Language combined operators 28 109
thread-safe code in c++ 2 103
c++ syntax question 9 49
When writing generic code, using template meta-programming techniques, it is sometimes useful to know if a type is convertible to another type. A good example of when this might be is if you are writing diagnostic instrumentation for code to generat…
Errors will happen. It is a fact of life for the programmer. How and when errors are detected have a great impact on quality and cost of a product. It is better to detect errors at compile time, when possible and practical. Errors that make their wa…
The goal of the video will be to teach the user the concept of local variables and scope. An example of a locally defined variable will be given as well as an explanation of what scope is in C++. The local variable and concept of scope will be relat…
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.

803 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question