Solved

visual basic scripting

Posted on 2013-12-14
8
725 Views
Last Modified: 2013-12-15
I need to use a visual basic script to add a printer then change the default printer to the added printer in windows 7. I CAN'T use the usual method of going to devices and printers, and I CAN'T use group policies. PLEASE, do not suggest group policies! let's just say this HAS to be done through a visual basic script.
From googleing - Since I am NOT a scripting person - I have constructed this so far

Dim printer, UNCpath1, slash1, slash2

slash1 ="\"

slash2 ="\\"

printer = InputBox("What printer do you want to be the default? ", "Create

Default Printer")

UNCpath1 = InputBox("What server is this printer on? ", "Server")

Set printer = CreateObject("WScript.Network")
 
printer.AddWindowsPrinterConnection slash2 & UNCpath1 & slash1 & printer

printer.SetDefaultPrinter slash2 & UNCpath1 & slash1 & printer

WScript.Quit

however when the script runs I get this.
Error: Object doesn't support this property of method
and says the error is at line 13 char 1
so I'm guessing it doesn't like the slashes, however, if I take the slashes out, the script looks like this

Dim printer, UNCpath1, slash1, slash2

printer = InputBox("What printer do you want to be the default? ", "Create

Default Printer")

UNCpath1 = InputBox("What server is this printer on? ", "Server")

Set printer = CreateObject("WScript.Network")
 
printer.AddWindowsPrinterConnection  UNCpath1 & printer

printer.SetDefaultPrinter UNCpath1 & printer

WScript.Quit

and the error is
error: object doesn't support this property or method
and the line number is 9 character 1

 I can't even qualify as a noobie at scripting so I thought I would ask for some help, because I am completely guessing at what is wrong.  My guess is it doesn't want the slashes but if I don't have them, there seems to be another syntax error? ( not even sure how plausible that sounds). Or maybe it does need the slashed but I'm just adding them wrong. Also, I'm stuck on the whole slash thing because these are network printers, and usually I would add them using the UNC, for example

\\servsername\printershare

So, any ideas on how to fix my script?
0
Comment
Question by:JeffBeall
  • 5
  • 3
8 Comments
 
LVL 67

Expert Comment

by:sirbounty
Comment Utility
I think you're simply a victim of copy/paste...
try this - all I've done is combine the lines as needed...
Dim printer, UNCpath1, slash1, slash2
slash1 ="\"
slash2 ="\\"
printer = InputBox("What printer do you want to be the default? ", "Create Default Printer")
UNCpath1 = InputBox("What server is this printer on? ", "Server")
Set printer = CreateObject("WScript.Network")
printer.AddWindowsPrinterConnection slash2 & UNCpath1 & slash1 & printer
printer.SetDefaultPrinter slash2 & UNCpath1 & slash1 & printer
WScript.Quit

Open in new window

0
 
LVL 67

Expert Comment

by:sirbounty
Comment Utility
Whoops - nevermind - I see the problem...you're using printer twice...try this:

Dim printer, UNCpath1, slash1, slash2
slash1 ="\"
slash2 ="\\"
printername = InputBox("What printer do you want to be the default? ", "Create Default Printer")
UNCpath1 = InputBox("What server is this printer on? ", "Server")
Set printer = CreateObject("WScript.Network")
printer.AddWindowsPrinterConnection slash2 & UNCpath1 & slash1 & printername
printer.SetDefaultPrinter slash2 & UNCpath1 & slash1 & printername
WScript.Quit

Open in new window

0
 
LVL 67

Accepted Solution

by:
sirbounty earned 500 total points
Comment Utility
Here's a slight modification - avoids empty responses and presents the user one last chance to change their mind if the data was input incorrectly...
do
  printername = InputBox("What printer do you want to be the default? ", "Create Default Printer")
loop until printername <> ""

do
  server = InputBox("On what server is " & printername & " located?", "Server Name")
loop until server <> ""

uncpath = "\\" & server & "\" & printername

intResponse = Msgbox("Ready to add new printer, " & uncpath & "?", vbYesNo, "Confirm printer")

If intResponse = vbYes Then
  Set objNet = CreateObject("WScript.Network")
  objNet.AddWindowsPrinterConnection uncpath
  objNet.SetDefaultPrinter uncpath
Else
    Msgbox "No changes were made."
End If

Open in new window

0
 
LVL 1

Author Comment

by:JeffBeall
Comment Utility
wow, thank you so much for the help. but for the shorter script, it's not setting the default printer. Did I do something wrong there?
0
Enabling OSINT in Activity Based Intelligence

Activity based intelligence (ABI) requires access to all available sources of data. Recorded Future allows analysts to observe structured data on the open, deep, and dark web.

 
LVL 1

Author Comment

by:JeffBeall
Comment Utility
hang on a second, it's working, I think the problem was I was using remote desktop on a test pc, and under local resources, printers were checked.
Once I unchecked printers, it worked fine.
thanks so much again for the help.
I'm so new to scripting, I would have never have thought to put
printername =  
on that one line, especially since I didn't declare it at the DIM statement.
0
 
LVL 67

Expert Comment

by:sirbounty
Comment Utility
you DIM statement is generally an optional item.  You don't have to declare your variables upfront, unless you're script contains Option Explicit.
I rarely declare any variables in my shorter script, but it is considered good practice.
Typically anytime you declare an object that's going to have the potential to consume a lot of resources, you want to make sure you destroy it when you're done (objVariable = Nothing).
But vbscript does that upon exit/quit anyway, so again, it's mostly just good coding practice.
0
 
LVL 1

Author Closing Comment

by:JeffBeall
Comment Utility
thank you for the help, it's working exactly how I need it to work. You were very helpful,
0
 
LVL 67

Expert Comment

by:sirbounty
Comment Utility
Glad I could help - thanx for the grade! :^)
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Suggested Solutions

Over the years I have built up my own little library of code snippets that I refer to when programming or writing a script.  Many of these have come from the web or adaptations from snippets I find on the Web.  Periodically I add to them when I come…
This article is the result of a quest to better understand Task Scheduler 2.0 and all the newer objects available in vbscript in this version over  the limited options we had scripting in Task Scheduler 1.0.  As I started my journey of knowledge I f…
This Micro Tutorial will give you a basic overview of Windows DVD Burner through its features and interface. This will be demonstrated using Windows 7 operating system.
The viewer will learn how to successfully download and install the SARDU utility on Windows 7, without downloading adware.

763 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now