Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 755
  • Last Modified:

visual basic scripting

I need to use a visual basic script to add a printer then change the default printer to the added printer in windows 7. I CAN'T use the usual method of going to devices and printers, and I CAN'T use group policies. PLEASE, do not suggest group policies! let's just say this HAS to be done through a visual basic script.
From googleing - Since I am NOT a scripting person - I have constructed this so far

Dim printer, UNCpath1, slash1, slash2

slash1 ="\"

slash2 ="\\"

printer = InputBox("What printer do you want to be the default? ", "Create

Default Printer")

UNCpath1 = InputBox("What server is this printer on? ", "Server")

Set printer = CreateObject("WScript.Network")
 
printer.AddWindowsPrinterConnection slash2 & UNCpath1 & slash1 & printer

printer.SetDefaultPrinter slash2 & UNCpath1 & slash1 & printer

WScript.Quit

however when the script runs I get this.
Error: Object doesn't support this property of method
and says the error is at line 13 char 1
so I'm guessing it doesn't like the slashes, however, if I take the slashes out, the script looks like this

Dim printer, UNCpath1, slash1, slash2

printer = InputBox("What printer do you want to be the default? ", "Create

Default Printer")

UNCpath1 = InputBox("What server is this printer on? ", "Server")

Set printer = CreateObject("WScript.Network")
 
printer.AddWindowsPrinterConnection  UNCpath1 & printer

printer.SetDefaultPrinter UNCpath1 & printer

WScript.Quit

and the error is
error: object doesn't support this property or method
and the line number is 9 character 1

 I can't even qualify as a noobie at scripting so I thought I would ask for some help, because I am completely guessing at what is wrong.  My guess is it doesn't want the slashes but if I don't have them, there seems to be another syntax error? ( not even sure how plausible that sounds). Or maybe it does need the slashed but I'm just adding them wrong. Also, I'm stuck on the whole slash thing because these are network printers, and usually I would add them using the UNC, for example

\\servsername\printershare

So, any ideas on how to fix my script?
0
JeffBeall
Asked:
JeffBeall
  • 5
  • 3
1 Solution
 
sirbountyCommented:
I think you're simply a victim of copy/paste...
try this - all I've done is combine the lines as needed...
Dim printer, UNCpath1, slash1, slash2
slash1 ="\"
slash2 ="\\"
printer = InputBox("What printer do you want to be the default? ", "Create Default Printer")
UNCpath1 = InputBox("What server is this printer on? ", "Server")
Set printer = CreateObject("WScript.Network")
printer.AddWindowsPrinterConnection slash2 & UNCpath1 & slash1 & printer
printer.SetDefaultPrinter slash2 & UNCpath1 & slash1 & printer
WScript.Quit

Open in new window

0
 
sirbountyCommented:
Whoops - nevermind - I see the problem...you're using printer twice...try this:

Dim printer, UNCpath1, slash1, slash2
slash1 ="\"
slash2 ="\\"
printername = InputBox("What printer do you want to be the default? ", "Create Default Printer")
UNCpath1 = InputBox("What server is this printer on? ", "Server")
Set printer = CreateObject("WScript.Network")
printer.AddWindowsPrinterConnection slash2 & UNCpath1 & slash1 & printername
printer.SetDefaultPrinter slash2 & UNCpath1 & slash1 & printername
WScript.Quit

Open in new window

0
 
sirbountyCommented:
Here's a slight modification - avoids empty responses and presents the user one last chance to change their mind if the data was input incorrectly...
do
  printername = InputBox("What printer do you want to be the default? ", "Create Default Printer")
loop until printername <> ""

do
  server = InputBox("On what server is " & printername & " located?", "Server Name")
loop until server <> ""

uncpath = "\\" & server & "\" & printername

intResponse = Msgbox("Ready to add new printer, " & uncpath & "?", vbYesNo, "Confirm printer")

If intResponse = vbYes Then
  Set objNet = CreateObject("WScript.Network")
  objNet.AddWindowsPrinterConnection uncpath
  objNet.SetDefaultPrinter uncpath
Else
    Msgbox "No changes were made."
End If

Open in new window

0
Keep up with what's happening at Experts Exchange!

Sign up to receive Decoded, a new monthly digest with product updates, feature release info, continuing education opportunities, and more.

 
JeffBeallAuthor Commented:
wow, thank you so much for the help. but for the shorter script, it's not setting the default printer. Did I do something wrong there?
0
 
JeffBeallAuthor Commented:
hang on a second, it's working, I think the problem was I was using remote desktop on a test pc, and under local resources, printers were checked.
Once I unchecked printers, it worked fine.
thanks so much again for the help.
I'm so new to scripting, I would have never have thought to put
printername =  
on that one line, especially since I didn't declare it at the DIM statement.
0
 
sirbountyCommented:
you DIM statement is generally an optional item.  You don't have to declare your variables upfront, unless you're script contains Option Explicit.
I rarely declare any variables in my shorter script, but it is considered good practice.
Typically anytime you declare an object that's going to have the potential to consume a lot of resources, you want to make sure you destroy it when you're done (objVariable = Nothing).
But vbscript does that upon exit/quit anyway, so again, it's mostly just good coding practice.
0
 
JeffBeallAuthor Commented:
thank you for the help, it's working exactly how I need it to work. You were very helpful,
0
 
sirbountyCommented:
Glad I could help - thanx for the grade! :^)
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 5
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now