We value your feedback.
Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!
Solved
error C2146: syntax error : missing ';' before identifier 'value_type'
Posted on 2013-12-22
I'm trying to work on the C++ iterator example at https://secweb.cs.odu.edu/
#pragma once
class iterator
{
public:
typedef std::forward_iterator_tag iterator_category;
typedef T value_type;
typedef ptrdiff_t difference_type;
typedef T* pointer;
typedef T& reference;
iterator();
// Get the data element at this position
reference operator*() const;
pointer operator->() const;
// Move position forward 1 place
iterator& operator++();
iterator operator++(int);
// Comparison operators
bool operator== (const iterator&) const;
bool operator!= (const iterator&) const;
private:
};
error C2146: syntax error : missing ';' before identifier 'value_type'Is there an #include I need to add to make this work?
[X]
Welcome to Experts Exchange
Add your voice to the tech community where 5M+ people just like you are talking about what matters.
- Help others & share knowledge
- Earn cash & points
- Learn & ask questions
-
5
3
2
10 Comments
>>Is there an #include I need to add to make this work?
Yes, you are most likely to need to add
You could as well try to only use 'xutility' (which introduces it), but that way it's IMHO safer.
Yes, you are most likely to need to add
#include <iterator>
You could as well try to only use 'xutility' (which introduces it), but that way it's IMHO safer.
Sorry for not noting that right away, but that source snippet is pseudocode and is just meant to illustrate the concept. Just look at the lines 15 and 19, neither 'reference' nor 'pointer' are valid keywords in C++. You will find the actual implementation in <iterator>.
OK I started a new C++ window forms project, added a blank class Author, and a class Book.
(Also complains lines 48,49 about Name. Is there supposed to be a class named Name? I would think that would just be a string? Does it really need its own class? Or is there some sort of TypeDef thing I'm missing?)
#pragma once
#include <string>
#include "Author.h"
#include <iterator>
class Book
{
struct AuthorListNode {
Author data;
AuthorListNode* next;
};
public:
Book (std::string theTitle,
Author theAuthor,
std::string theIdentifier);
Book (std::string theTitle, int numberOfAuthors,
Author* theAuthors, std::string theIdentifier);
Book (const Book& b);
~Book();
Book& operator= (const Book&);
typedef AuthorIterator iterator;
typedef ConstAuthorIterator const_iterator;
std::string getTitle() const {return title;}
void putTitle(std::string theTitle) {title = theTitle;}
int getNumberOfAuthors() const {return numAuthors;}
void addAuthor (Author);
void removeAuthor (Author);
std::string getIdentifier() const {return identifier;}
void putIdentifier(std::string id) {identifier = id;}
iterator begin();
const_iterator begin() const;
iterator end();
const_iterator end() const;
iterator findAuthor (Name n);
const_iterator findAuthor (Name n) const;
private:
std::string title;
int numAuthors;
AuthorListNode* authors; // linked list of pointers to authors
std::string identifier;
friend class AuthorIterator;
friend class ConstAuthorIterator;
};
Book.h(27): error C2146: syntax error : missing ';' before identifier 'iterator'Also complains about lines 28, 42, 43, 45, 46, 48, 49.
(Also complains lines 48,49 about Name. Is there supposed to be a class named Name? I would think that would just be a string? Does it really need its own class? Or is there some sort of TypeDef thing I'm missing?)
You will either have to add
(not recommended in a header file, though) or refer to these identifiers as 'std::iterator' etc.
using namespace std;
(not recommended in a header file, though) or refer to these identifiers as 'std::iterator' etc.
I changed line 27 to read
typedef AuthorIterator std::iterator;
error C2955: 'std::iterator' : use of class template requires template argument list
Active 4 days ago
here your typedef seems wrong.
It should be:
typedef std::iterator AuthorIterator ;
It should be:
typedef std::iterator AuthorIterator ;
Ok I switched it around to read:
typedef std::iterator AuthorIterator;
error C2955: 'std::iterator' : use of class template requires template argument list
Active 4 days ago
Generally typedef is used to define a type.For a longer syntax we prefer doing typedef.
Ex: if I want unsigned long int to be used as ULINT then my declaration should be as follows.
typedef unsigned long int ULINT;
For iterator, we need to define the type of container upon which it'll work.
Lets we have a vector of ints. I want to traverse using iterator, So I can do declaration of iterator as follows.
typedef std::vector<int>::iterator
But in your case what exactly u want, I don't know.
If possible, share the entire source code.
Ex: if I want unsigned long int to be used as ULINT then my declaration should be as follows.
typedef unsigned long int ULINT;
For iterator, we need to define the type of container upon which it'll work.
Lets we have a vector of ints. I want to traverse using iterator, So I can do declaration of iterator as follows.
typedef std::vector<int>::iterator
But in your case what exactly u want, I don't know.
If possible, share the entire source code.
Featured Post
Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.
Question has a verified solution.
If you are experiencing a similar issue, please ask a related question
When writing generic code, using template meta-programming techniques, it is sometimes useful to know if a type is convertible to another type. A good example of when this might be is if you are writing diagnostic instrumentation for code to generat…
Often, when implementing a feature, you won't know how certain events should be handled at the point where they occur and you'd rather defer to the user of your function or class. For example, a XML parser will extract a tag from the source code, wh…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The goal of the video will be to teach the user the difference and consequence of passing data by value vs passing data by reference in C++. An example of passing data by value as well as an example of passing data by reference will be be given. Bot…
Suggested Courses
Course of the Month9 days, 23 hours left to enroll
610 members asked questions and received personalized solutions in the past 7 days.
Join the community of 500,000 technology professionals and ask your questions.