We value your feedback.
Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!
Course Of The Month
4 days, 5 hours left to enrollBecome a Premium Member and unlock a new, free course in leading technologies each month.
Solved
error C2146: syntax error : missing ';' before identifier 'value_type'
Posted on 2013-12-22
I'm trying to work on the C++ iterator example at https://secweb.cs.odu.edu/
#pragma once
class iterator
{
public:
typedef std::forward_iterator_tag iterator_category;
typedef T value_type;
typedef ptrdiff_t difference_type;
typedef T* pointer;
typedef T& reference;
iterator();
// Get the data element at this position
reference operator*() const;
pointer operator->() const;
// Move position forward 1 place
iterator& operator++();
iterator operator++(int);
// Comparison operators
bool operator== (const iterator&) const;
bool operator!= (const iterator&) const;
private:
};
error C2146: syntax error : missing ';' before identifier 'value_type'Is there an #include I need to add to make this work?
[X]
Welcome to Experts Exchange
Add your voice to the tech community where 5M+ people just like you are talking about what matters.
- Help others & share knowledge
- Earn cash & points
- Learn & ask questions
-
5
3
2
10 Comments
Active 3 days ago
>>Is there an #include I need to add to make this work?
Yes, you are most likely to need to add
You could as well try to only use 'xutility' (which introduces it), but that way it's IMHO safer.
Yes, you are most likely to need to add
#include <iterator>
You could as well try to only use 'xutility' (which introduces it), but that way it's IMHO safer.
Active 3 days ago
Sorry for not noting that right away, but that source snippet is pseudocode and is just meant to illustrate the concept. Just look at the lines 15 and 19, neither 'reference' nor 'pointer' are valid keywords in C++. You will find the actual implementation in <iterator>.
OK I started a new C++ window forms project, added a blank class Author, and a class Book.
(Also complains lines 48,49 about Name. Is there supposed to be a class named Name? I would think that would just be a string? Does it really need its own class? Or is there some sort of TypeDef thing I'm missing?)
#pragma once
#include <string>
#include "Author.h"
#include <iterator>
class Book
{
struct AuthorListNode {
Author data;
AuthorListNode* next;
};
public:
Book (std::string theTitle,
Author theAuthor,
std::string theIdentifier);
Book (std::string theTitle, int numberOfAuthors,
Author* theAuthors, std::string theIdentifier);
Book (const Book& b);
~Book();
Book& operator= (const Book&);
typedef AuthorIterator iterator;
typedef ConstAuthorIterator const_iterator;
std::string getTitle() const {return title;}
void putTitle(std::string theTitle) {title = theTitle;}
int getNumberOfAuthors() const {return numAuthors;}
void addAuthor (Author);
void removeAuthor (Author);
std::string getIdentifier() const {return identifier;}
void putIdentifier(std::string id) {identifier = id;}
iterator begin();
const_iterator begin() const;
iterator end();
const_iterator end() const;
iterator findAuthor (Name n);
const_iterator findAuthor (Name n) const;
private:
std::string title;
int numAuthors;
AuthorListNode* authors; // linked list of pointers to authors
std::string identifier;
friend class AuthorIterator;
friend class ConstAuthorIterator;
};
Book.h(27): error C2146: syntax error : missing ';' before identifier 'iterator'Also complains about lines 28, 42, 43, 45, 46, 48, 49.
(Also complains lines 48,49 about Name. Is there supposed to be a class named Name? I would think that would just be a string? Does it really need its own class? Or is there some sort of TypeDef thing I'm missing?)
Active 3 days ago
You will either have to add
(not recommended in a header file, though) or refer to these identifiers as 'std::iterator' etc.
using namespace std;
(not recommended in a header file, though) or refer to these identifiers as 'std::iterator' etc.
I changed line 27 to read
typedef AuthorIterator std::iterator;
error C2955: 'std::iterator' : use of class template requires template argument list
Ok I switched it around to read:
typedef std::iterator AuthorIterator;
error C2955: 'std::iterator' : use of class template requires template argument list
Active today
Generally typedef is used to define a type.For a longer syntax we prefer doing typedef.
Ex: if I want unsigned long int to be used as ULINT then my declaration should be as follows.
typedef unsigned long int ULINT;
For iterator, we need to define the type of container upon which it'll work.
Lets we have a vector of ints. I want to traverse using iterator, So I can do declaration of iterator as follows.
typedef std::vector<int>::iterator
But in your case what exactly u want, I don't know.
If possible, share the entire source code.
Ex: if I want unsigned long int to be used as ULINT then my declaration should be as follows.
typedef unsigned long int ULINT;
For iterator, we need to define the type of container upon which it'll work.
Lets we have a vector of ints. I want to traverse using iterator, So I can do declaration of iterator as follows.
typedef std::vector<int>::iterator
But in your case what exactly u want, I don't know.
If possible, share the entire source code.
Featured Post
An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.
One of a set of tools we're offering as a way of saying thank you for being a part of the community.
Question has a verified solution.
If you are experiencing a similar issue, please ask a related question
Errors will happen. It is a fact of life for the programmer. How and when errors are detected have a great impact on quality and cost of a product. It is better to detect errors at compile time, when possible and practical. Errors that make their wa…
Basic understanding on "OO- Object Orientation" is needed for designing a logical solution to solve a problem. Basic OOAD is a prerequisite for a coder to ensure that they follow the basic design of OO. This would help developers to understand the b…
The goal of the video will be to teach the user the concept of local variables and scope. An example of a locally defined variable will be given as well as an explanation of what scope is in C++. The local variable and concept of scope will be relat…
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.
Suggested Courses
Course of the Month4 days, 5 hours left to enroll
691 members asked questions and received personalized solutions in the past 7 days.
Join the community of 500,000 technology professionals and ask your questions.