Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 594
  • Last Modified:

VBA Date code returning error

I have the following code.  My workbook has multiple worksheets with dates as the names.  I am getting an error when testing this code in the immediate window to get the most recent date.  I can't figure out what is wrong.  Please help!

Function getMostRecentDate()
    Dim wsSheet As Worksheet
    Dim datMostRecent As Date
    Dim datTestDate As Date
   
    datMostRecent = 0
    For Each wsSheet In Worksheets
        datTestDate = CDate(wsSheet.Name)
        If datTestDate > datMostRecent Then
        datMostRecent = datTestDate
        End If
    Next wsSheet
    getMostRecentDate = datMostRecent
   
End Function
0
karaflanagan
Asked:
karaflanagan
1 Solution
 
karaflanaganAuthor Commented:
I am getting a Run-time error '13'
Type mismatch
0
 
Anthony BerenguelCommented:
What is the date format you're using in your worksheet names? Remember that value (worksheet.name) is a string so you need to keep that in mind when you use that value to populate a date variable.
0
 
karaflanaganAuthor Commented:
23-Aug-13
0
Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

 
byundtCommented:
I assume that the error occurs on the CDate statement. If so, what is the value of wsSheet.Name?

Just for grins, I tested CDate("2-29-14") in the Immediate pane--and got a Type 13 Type Mismatch error. But DateSerial(2014, 2, 29) returned March 1, 2014 (as it should in a non-Leap Year).
0
 
byundtCommented:
?CDate("23-Aug-13") is working in Excel 2013 (32-bit) for me in the Immediate pane.

Which version of Excel are you using?
0
 
karaflanaganAuthor Commented:
Excel 2010 not sure if it is 32 bit or 64 bit
0
 
Jesus RodriguezIT ManagerCommented:
You're declaring
Dim datMostRecent As Date
and then Assign the value of 0 here  datMostRecent = 0 ??
0
 
byundtCommented:
I also have 32-bit Excel 2010, and ?CDate("23-Aug-13") is working for me there, as well.

The statement flagged by Jesus Rodriguez is working fine in that test workbook.
0
 
karaflanaganAuthor Commented:
byundt, I am trying to actually run the GetMostRecentDate Function and have it return a value, not CDate.
0
 
karaflanaganAuthor Commented:
Jesus - Excel reads dates as serial numbers.
0
 
byundtCommented:
Could you post a workbook that demonstrates the problem? It doesn't need to have any data in the worksheets, and it doesn't need to include any code other than the function being discussed.
0
 
byundtCommented:
If one of the worksheet names is not a date, then CDate will fail. A worksheet formula referencing your function will return #VALUE! error, and the Immediate pane will return a Type 13.

Should this be a concern, you can add "On Error Resume Next" to handle the possibility of worksheet names that aren't dates.
Function getMostRecentDate()
    Dim wsSheet As Worksheet
    Dim datMostRecent As Date
    Dim datTestDate As Date
    
    On Error Resume Next
    datMostRecent = 0
    For Each wsSheet In Worksheets
        datTestDate = CDate(wsSheet.Name)
        If datTestDate > datMostRecent Then
            datMostRecent = datTestDate
        End If
    Next wsSheet
    On Error GoTo 0
    getMostRecentDate = datMostRecent
    
End Function

Open in new window

0
 
karaflanaganAuthor Commented:
Here is an example.  I am not done with the project yet but I don't want to continue with these functions still not working.
Test-Workbook.xlsm
0
 
byundtCommented:
You have a worksheet named Reports. This will cause a run-time error with CDate.  As a workaround, I added a test for the worksheet name beginning with a number.

You also put the functions in the code pane for a userform. I moved them to a regular module sheet (which I named modFunctions).

The function getEarliestDate referred to an undeclared variable datMostRecent. I changed that reference to datEarliest.
Function getMostRecentDate()
    Dim wsSheet As Worksheet
    Dim datMostRecent As Date
    Dim datTestDate As Date
    
    datMostRecent = 0
    For Each wsSheet In Worksheets
        If Val(wsSheet.Name) > 0 Then
            datTestDate = CDate(wsSheet.Name)
            If datTestDate > datMostRecent Then
                datMostRecent = datTestDate
            End If
        End If
    Next wsSheet
    getMostRecentDate = datMostRecent
    
End Function
Function getEarliestDate()
    Dim wsSheet As Worksheet
    Dim datEarliest As Date
    Dim datTestDate As Date
    
    datEarliest = 99999
    For Each wsSheet In Worksheets
        If Val(wsSheet.Name) > 0 Then
            datTestDate = CDate(wsSheet.Name)
            If datTestDate < datEarliest Then
                datEarliest = datTestDate
            End If
        End If
    Next wsSheet
    getEarliestDate = datEarliest
    
End Function

Open in new window

Test-WorkbookQ28335626.xlsm
0

Featured Post

How to Use the Help Bell

Need to boost the visibility of your question for solutions? Use the Experts Exchange Help Bell to confirm priority levels and contact subject-matter experts for question attention.  Check out this how-to article for more information.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now