Solved

converting a vector of unsigned char to unsigned short

Posted on 2014-01-12
6
722 Views
Last Modified: 2014-01-31
Hi

How can i convert a vector (in C++) of unsigned char to a vector of unsigned short? (it would take 2 bytes together and stuff them in the same index.

thanks
0
Comment
Question by:LuckyLucks
6 Comments
 
LVL 86

Expert Comment

by:jkr
ID: 39775647
Well, what about  just a 'for' loop'?

void vector_uchar_to_ushort(const std::vector<unsigned char>& v1, std::vector<unsigned short>& v2) {

  for (size_t sz = 0; sz != v1.lenght(); ++sz) 
      v2[sz] = (unsigned short) v1[sz];
}

Open in new window

0
 
LVL 32

Accepted Solution

by:
phoffric earned 500 total points
ID: 39775671
To stuff the two bytes together into one short, here is an expression to add to jkr's code
    static_cast<unsigned short>(v1[sz]) << 8 | v1[++sz]

Since you have only half the number of elements for the unsigned short vector, modify the for-condition:
       sz != v1.lenght()/2
You also need to deal with the case of having an odd number of chars.
0
 
LVL 40

Expert Comment

by:evilrix
ID: 39775833
You can just use memcpy to do this.

vector<unsigned char> ucvec;

// add stuff to ucvec
...

vector<unsigned short> usvec(ucvec.size()/2);
memcpy(&usvec[0], &ucvec[0], ucvec.size());

Open in new window


Some general caveats to consider...

1. the number of items in ucvec MUST be even
2. sizeof(short) must be equal to sizeof(char)/2
3. the value short represents depends on the endianess of your platform

In short, unless you know what you are doing copying one type to another, in this way, (ie stuffing two chars into a short) will result in non-portable code that, at best, will only work on the platform it is built and tested on. It is both platform and compiler dependent.
0
Efficient way to get backups off site to Azure

This user guide provides instructions on how to deploy and configure both a StoneFly Scale Out NAS Enterprise Cloud Drive virtual machine and Veeam Cloud Connect in the Microsoft Azure Cloud.

 
LVL 33

Expert Comment

by:sarabande
ID: 39776509
depending on the stl implementation (and endianess) of your platform you may even able to cast between the vectors (granted that you have an even number of elements in the char vector). the following compiles and runs on my system (vc10, win7):

std::vector<unsigned char>    vuc;
std::vector<unsigned char>  * pvuc = &vuc;
std::vector<unsigned short> * pvus;

 pvuc->push_back(0xa0);
 pvuc->push_back(0xa1);
 pvuc->push_back(0xa2);
 pvuc->push_back(0xa3);

 pvus = (std::vector<unsigned short> *)pvuc;
 unsigned short us1 = (*pvus)[0];
 unsigned short us2 = (*pvus)[1];
 size_t szvus = pvus->size();
 pvus->push_back(0xa5a4);
 size_t szvuc = pvuc->size();

Open in new window


the reason why it worked is that the vector has pointer members to the begin, last, and end (which is the address beyond array boundaries) of its internal array. those pointers are valid for both array types as long as there is no 'odd' index is involved. the size and number of elements are not stored in members but were deduced from those pointers and from template type.

Sara
0
 

Author Comment

by:LuckyLucks
ID: 39776651
@Sara:

what do 0xa0, 0xa1,0xa2,0xa3,0xa5a4  mean and how do you come up with those hex numbers ? thanks
0
 
LVL 33

Expert Comment

by:sarabande
ID: 39776691
it doesn't mean anything. they are some samples for unsigned char or unsigned short which easily could be verified in the debugger.

note, an unsigned char is an integer in the range 0 - 255 decimal or 0x00-0xff hexadecimal.

an unsigned short of 0xa5a4 would map to an array of two unsigned char of 0xa4 and 0xa5 if using the same address and the endianess is little-endian.

Sara
0

Featured Post

Back Up Your Microsoft Windows Server®

Back up all your Microsoft Windows Server – on-premises, in remote locations, in private and hybrid clouds. Your entire Windows Server will be backed up in one easy step with patented, block-level disk imaging. We achieve RTOs (recovery time objectives) as low as 15 seconds.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction This article is the first in a series of articles about the C/C++ Visual Studio Express debugger.  It provides a quick start guide in using the debugger. Part 2 focuses on additional topics in breakpoints.  Lastly, Part 3 focuses on th…
Many modern programming languages support the concept of a property -- a class member that combines characteristics of both a data member and a method.  These are sometimes called "smart fields" because you can add logic that is applied automaticall…
The goal of the video will be to teach the user the difference and consequence of passing data by value vs passing data by reference in C++. An example of passing data by value as well as an example of passing data by reference will be be given. Bot…
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.

773 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question