Link to home
Start Free TrialLog in
Avatar of Jagwarman
Jagwarman

asked on

VBA to open a file from a folder where year and date changes

Could an expert provide me with the code to open a file from a folder where year and date changes.

path is G:\Sales\Recon\Results\2014\dd.mm.yyyy.xls

where 2014 will become 2015 and the file will be yesterdays date.

Thanks
Avatar of Anthony Berenguel
Anthony Berenguel
Flag of United States of America image

This should help get you started. Let me know if you have questions.
Public Sub open_file()
    
    Const BASEPATH = "G:\Sales\Recon\Results\2014\dd.mm.yyyy.xls"
    
    Dim strGeneratedPath As String
    Dim strDay As String
    Dim strMonth As String
    Dim strYear As String
    
    'swap 2014 with 2015
    strGeneratedPath = Replace(BASEPATH, "\2014\", "\2015\")
    
    strDay = Day(Date)
    If Len(strDay) < 2 Then strDay = "0" & strDay
    strMonth = Month(Date)
    If Len(strMonth) < 2 Then strDay = "0" & strMonth
    strYear = Year(Date)
    
    strGeneratedPath = Replace(strGeneratedPath, "\dd.", "\" & strDay & ".")
    strGeneratedPath = Replace(strGeneratedPath, ".mm.", "." & strMonth & ".")
    strGeneratedPath = Replace(strGeneratedPath, ".yyyy.", "." & strYear & ".")
    
    Workbooks.Open (strGeneratedPath)
End Sub

Open in new window

Avatar of Rob Henson
Similar to above:

Sub OpenFile()

FileYear = Year(Date)
FileDate = Format(Date - 1,"dd.mm.yyyy")
FilePath = "G:\Sales\Recon\Results\" & FileYear & "\" & FileDate &".xls"

Workbooks.Open (FilePath)

End Sub
Avatar of fredvr666
fredvr666

Sub Openfile()
    Dim oExcel As Excel.Application
    Dim oWB As Workbook
    Dim strFile As String
   
    On Error GoTo Error_Openfile
    strFile = "o:\" & Format(Now(), "yyyy") & "\" & Format(Now() - 1, "dd.mm.yyyy") & ".xlsx"
    Set oExcel = New Excel.Application
    oExcel.Visible = True
    Set oWB = oExcel.Workbooks.Open(strFile)
   
    Exit Sub
Error_Openfile:
    If Not oWB Is Nothing Then oWB.Close
    Set oWB = Nothing
    Set oExcel = Nothing
End Sub
Avatar of Jagwarman

ASKER

All thanks for the replies:

aebea not sure why but yours returns strDay as 01.1.2014

One thing I did forget to say was that if there is a weekend, on the Monday I need the macro to open the file from the friday. Can they be amended to do this?

Thanks
Sorry, one more question/request.

The teams have thrown me a curveball and this may not be possible.

they save their files in folders by year by month and for each month they give it a number, so January folder is 01.Jan 2014 Feb is 02.Feb 2014 March is 03.Mar 2014 etc

so the path I originally gave needs amendment to

G:\Sales\Recon\Results\2014\01.Jan 2014\filename dd.mm.yyyy.xls

apologies
A curveball to throw back would be to suggest that the use of fullstops within file names and possibly folder names should be avoided.

In filenames some AV software don't like the us of Fullstops as it suggests multiple extensions.

For more reliable sort ordering I have found the use of naming convention of yyyymmdd to be more reliable. This files will always be in chronological order.

However, your current requirement includes fullstops so will owrk on that accordingly.

Thanks
Rob
Also, what happens on first day of month and/or first day of year?

I assume, first of month will require last day of previous month which will be in previous month folder.

Likewise, first of year will require last day of previous month which will be in December folder of previous year.

Thanks
Rob
I assume you are running this macro from within an existing Excel file.

Would it be feasible to construct a filename and path using a formula within that file and then use that as the location of the workbook to open?

Thanks
Rob H
See attached with formula calculation of filename and button that will then open the filename constructed.

Thanks
Rob H

Scratch this comment, didn't allow for all eventualities; working on that now.
ASKER CERTIFIED SOLUTION
Avatar of Rob Henson
Rob Henson
Flag of United Kingdom of Great Britain and Northern Ireland image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Or something like this:
Sub Openfile(strFilename As String)
    Dim oExcel As Excel.Application
    Dim oWB As Workbook
    Dim strFile As String
   
    On Error GoTo Error_Openfile
    strFile = "G:\Sales\Recon\Results\2014\" & Format(Now() - 1, "dd.mmm.yyyy") & "\" & strFilename & " " & _
                Format(Now(), "yyyy") & "\" & Format(Now() - 1, "dd.mm.yyyy") & ".xls"
    Set oExcel = New Excel.Application
    oExcel.Visible = True
    Set oWB = oExcel.Workbooks.Open(strFile)
   
    Exit Sub
Error_Openfile:
    If Not oWB Is Nothing Then oWB.Close
    Set oWB = Nothing
    Set oExcel = Nothing
End Sub
robhenson thye path it is opening is G\SalesaRecon\2014\14.01.2014.xls

It is missing the 01.Jan 2014

G:\Sales\Recon\Results\2014\01.Jan 2014\filename dd.mm.yyyy.xls
Which VBA Script are you looking at?

Script above or in attached file?

Script above was prior to Month folder requirement so can be ignored. In file there are 2 scripts, OpenFile or OpenFile2

Should be using the OpenFile2 script, or the button on the sheet.

Thanks
Rob
Must have been something I was doing the 'file' OpenFile2 script works fine. Thanks