• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 291
  • Last Modified:

Accessing div created dynamically with JS

Hi

I am using cycle2 to create a carousel of logos.

Seen on this page http://facilitiescollective.com/founding-partners.php
(alongside title "founding partners")

When clicked it drops down some information.

As the carousel loops cycle2 is creating duplicates. The duplicated logos don't drop down information and it appears i cant access them. Any ideas why?

(try clicking the 8th logo which is a duplicate of the 1st for an example of the problem)

Thanks
0
coolispaul
Asked:
coolispaul
  • 3
  • 2
  • 2
  • +1
1 Solution
 
Tom BeckCommented:
I can see one problem but I haven't determined if it's THE problem. Whatever code is duplicating the logo containers is also duplicating the ids of those containers causing multiple elements with the same id on the page. That will cause problems on a page where a script is trying to access elements by id.
0
 
GaryCommented:
You are targeting your dropdown by the class (item1,item2 etc)  but you have multiple elements with the same class - I'm surprised it's even working properly for the initial logos (before they are replicated)
Your dropdowns should probably have an ID using text1, text2 etc
Then in your js you can target a definitive element by changing
$("."+el).slideDown();
to
$("#"+el).slideDown();

You then should remove the ID from your slideshow logo's.
0
 
GaryCommented:
You should also target your logos with more specificity

Not this way which attaching itself to every div within the container
$("#partners div").on("click", function(){

But this way which only targets the logos
$("#partners .cycle-carousel-wrap .item").on("click", function(){
0
Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

 
Chris StanyonCommented:
Drop the item1, item2 classes etc. from the logo containers as well as the IDs. Add a data attribute to the logos themselves (call it panel for example) containing the class of the element you want to slide, and then bind the click event to the images rather than the DIVs. Because they're dynamically created you need to delegate the event to something that exists on page load (#partners for example)

<div class="item"><img data-panel="item1" src="/admin/resources/pgsfinal2.jpg" /></div>
<div class="item"><img data-panel="item2" src="/admin/resources/miltonabbeyfinal2.jpg" /></div>
<div class="item"><img data-panel="item3" src="/admin/resources/kimboltonfinal2.jpg" /></div>

Open in new window

Then your jQuery would just need to grab the panel data attribute from the clicked image

$("#partners").on("click", ".item img", function() {
   var el = $(this).data('panel');
   $("#partners .text").slideUp();
   $("."+el).slideDown();
   ...

Open in new window

0
 
coolispaulAuthor Commented:
thanks chris Stanyon this works great

Would you mind explaining why this works and mine didnt?

Thanks
0
 
Chris StanyonCommented:
Normally events are bound to the elements when the page first loads. When your page loaded, the click event was bound to your original logos. Once the carousel starts it duplicates the logos so they can cycle, but the event binding has already taken place, so the duplicated logos won't have the click event bound to them (because they didn't exist at the start).

This is why you need to bind the event to an element that already exists at the start (#partners) and then delegate to the img. That way the event will apply to any images inside #partners irrespective of when they were created.

Glad it worked - binding events to dynamically created elements can be a bit of a gotcha if you're not careful :)
0
 
coolispaulAuthor Commented:
perfect thanks for your help
0
 
coolispaulAuthor Commented:
great explanation also, helping my understanding
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: Microsoft Windows 7 Basic

This introductory course to Windows 7 environment will teach you about working with the Windows operating system. You will learn about basic functions including start menu; the desktop; managing files, folders, and libraries.

  • 3
  • 2
  • 2
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now