Access VBA SQL: Error Too few parameters. Expected 1

Posted on 2014-01-16
Last Modified: 2014-01-17

I am using some code syntax that worked for one table, but is not working for another. I think it is because the table that I am trying to insert the data into has a primary key that is automatically incremental. I want to inforamtion to be placed at the end of the table with the primary key (stoID) automatically entered with the next number in the order. Does that make sense?

Anyway, here is the code I have. It is taking information put into a form and inserting it into a table.

Private Sub Command47_Click()
Dim strSQL As String
strSQL = "INSERT INTO SubTaskOrders(TOID, StoNo, [StoName]) VALUES (" & Me.cmbTaskOrder & ", " & Me.SubNO & ", " & Me.SubName & ")"
CurrentDb.Execute strSQL, dbFailOnError

End Sub

Open in new window

Thank you, in advance, for you help!
Question by:Megin
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 2
  • 2
LVL 120

Expert Comment

by:Rey Obrero (Capricorn1)
ID: 39787108
check the name of the table and the names of the fields, make sure they match the names of the fields in table "SubTaskOrders" .

if you have included the AutoNumber field in your insert sql, remove it

Author Comment

ID: 39787191
I have included an AutoNumber field, but that is the primary key for the table and is connected to other forms and tables. I don't want/can't to remove it. Is there any other way to handle this error?

However, is there some way to get that number to automatically add the next number other than using AutoNumber?
LVL 84
ID: 39787196
Also, if those are Text fields you need to enclose them in single quotes:

strSQL = "INSERT INTO SubTaskOrders(TOID, StoNo, [StoName]) VALUES (" & Me.cmbTaskOrder & ", '" & Me.SubNO & "', '" & Me.SubName & "')"

This assumes that StoNo and StoName are TEXT fields, and that TOID is a Numeric field.

What rey means is that if TOID is an AutoNumber field, you should not write to that but instead let Access handle that value.
Back Up Your Microsoft Windows Server®

Back up all your Microsoft Windows Server – on-premises, in remote locations, in private and hybrid clouds. Your entire Windows Server will be backed up in one easy step with patented, block-level disk imaging. We achieve RTOs (recovery time objectives) as low as 15 seconds.


Author Comment

ID: 39787232
My whole form just starting thowing errors, so I am creating it over again. It is going to take me a little bit to get back to this. I might not be able to try it until tomorrow.

So, don't worry. I will answer this.

Author Comment

ID: 39787290
I am getting a syntax error for the Insert statement now.

Here is my code:

Private Sub btnAddRecord_Click()
Dim strSql As String
strSql = ("INSERT INTO SubTaskOrders(" & Me.cmbTaskOrder & ", " & Me.txtStoNo & ", " & Me.txtStoName & ")")
CurrentDb.Execute strSql, dbFailOnError

End Sub

Open in new window

Some of the names have changed because I am using a new form now, but I want it to do the same thing.
LVL 120

Assisted Solution

by:Rey Obrero (Capricorn1)
Rey Obrero (Capricorn1) earned 250 total points
ID: 39787311
you have to include the NAMES of the FIELDS in your Insert query

Dim strSql As String
strSql = "INSERT INTO SubTaskOrders(NameOffield, StoNo, stoName)  Values (" & Me.cmbTaskOrder & ", " & Me.txtStoNo & ", '" & Me.txtStoName & "')"
CurrentDb.Execute strSql, dbFailOnError

change "NameOffield" with the actual name of field for the TaskOrder
LVL 84

Accepted Solution

Scott McDaniel (Microsoft Access MVP - EE MVE ) earned 250 total points
ID: 39788100
And (again) if those fields are Text, you must enclose them in in single or double quotes:

strSql = "INSERT INTO SubTaskOrders(NameOffield, StoNo, stoName)  Values (" & Me.cmbTaskOrder & ", '  " & Me.txtStoNo & " '  , '   '" & Me.txtStoName & "  ' )"

I've added some whitespace so you can see what I'm talking about.

In your code, there is also an extra ) at the end ... cap fixed that for you.

Author Closing Comment

ID: 39788874
OMG! I am so embarrassed!  I can't believe I left that out of the code! I know better....I think I was just frustrated at the end of the day.

The code is working now.

Thank you for your help and your patience!

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Null or "" 28 52
Item not found in this collection 5 31
VBA Delete sql "Too Few Parameters" 8 23
ms/link form - subform field not recognised 3 11
Introduction The Visual Basic for Applications (VBA) language is at the heart of every application that you write. It is your key to taking Access beyond the world of wizards into a world where anything is possible. This article introduces you to…
In a multiple monitor setup, if you don't want to use AutoCenter to position your popup forms, you have a problem: where will they appear?  Sometimes you may have an additional problem: where the devil did they go?  If you last had a popup form open…
In Microsoft Access, learn different ways of passing a string value within a string argument. Also learn what a “Type Mis-match” error is about.
Polish reports in Access so they look terrific. Take yourself to another level. Equations, Back Color, Alternate Back Color. Write easy VBA Code. Tighten space to use less pages. Launch report from a menu, considering criteria only when it is filled…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question