• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 679
  • Last Modified:

What am I missing in this curl and unzip?

Here is a very simple program to download and unzip a file

<?PHP
$appNumber = "12102391";
$payload = file_get_contents('http://storage.googleapis.com/uspto-pair/applications/'.$appNumber.'.zip'); //grab the file from the remote server
$target = "."; // this is the destination for the unzipped files

openZip($payload,$appNumber); 

function openZip($file_to_open,$appNumber) { 
    global $target;
    $file = $appNumber.'.zip';
    $client = curl_init($file_to_open);
    curl_setopt($client, CURLOPT_RETURNTRANSFER, 1);  
    $fileData = curl_exec($client);

echo("---\n".$file."-".$fileData."\n---\n");

    file_put_contents($file, $fileData);

    @unlink($file);
    touch($file);
    $zip = new ZipArchive(); 
    $f = $zip->open($file);
    var_dump($f);
    $zip->extractTo($appNumber);
    $zip->close();
    var_dump(glob($appNumber.'/*'));
}
?>

Open in new window


It creates a file and a dir but the file is empty and so is the dir

If I echo $file_to_open I actually see the file contents but I want to write the zip - actually I do not need to write the zip, I just want the unzipped contents in a dir named after the file so if I can unzip without saving the file, I would be quite happy too.
0
Michel Plungjan
Asked:
Michel Plungjan
  • 5
  • 4
  • 2
1 Solution
 
Ray PaseurCommented:
Michel: PHP ZipArchive is full of gotchas.  I found it very buggy with cross-release failures.

If you can get the file downloaded to a Windows7 desktop, you can copy the contents of the zip file to another directory and Windows will unzip it for you in the process.

The comments on this page and the linked pages tell something of a tale of woe.
http://php.net/manual/en/class.ziparchive.php
0
 
GaryCommented:
The zip file has to be saved, you cannot use ZipArchive with an in memory object.
Here's a clue to why you have a blank file...
@unlink($file);
0
 
Michel PlungjanIT ExpertAuthor Commented:
Thanks for the reply

I need to download any zip on demand from that source. Later I will produce an HTML file with links to the pdfs in the zip

I can easily download and unzip using windows

The problem does not seem to be the unzipping (yet) but the download and saving.

I am doing something wrong in the Curl for now
0
Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

 
Michel PlungjanIT ExpertAuthor Commented:
I was suspicious of the unlink but I have now commented it out. No change to the results
0
 
Ray PaseurCommented:
Michel, please describe the app in layman's terms.  You read from USPTO, but what are you trying to do with cURL?
0
 
Ray PaseurCommented:
Have a look at the output from just this script.  It looks like some of the data is ZIP and some is clear text.

<?php // RAY_temp_mplungjan.php
error_reporting(E_ALL);

$appNumber = "12102391";
$payload = file_get_contents('http://storage.googleapis.com/uspto-pair/applications/'.$appNumber.'.zip'); //grab the file from the remote server
var_dump($payload);
die();

Open in new window

0
 
GaryCommented:
<?PHP
$appNumber = "12102391";
$payload = file_get_contents('http://storage.googleapis.com/uspto-pair/applications/'.$appNumber.'.zip');

$file = $appNumber.'.zip';
file_put_contents($file,$payload);

openZip($file,$appNumber);

function openZip($file_to_open,$appNumber) {
    $zip = new ZipArchive();
    $f = $zip->open($file_to_open);
    var_dump($f);
    $zip->extractTo($appNumber);
    $zip->close();
}
?>
0
 
Michel PlungjanIT ExpertAuthor Commented:
Perfect - thanks
0
 
Michel PlungjanIT ExpertAuthor Commented:
Ray: I thought I needed CURL to get the file. I was mixing my tiny knowledge of get_contents, thinking I needed curl for binary contents

The program is supposed to - given an application number, access the zipfiles from google, unzipping and presenting a clickable list of links to them
0
 
Ray PaseurCommented:
Where cURL is more useful than file_get_contents() is when you do not want to have a dependency on the remote resource.  If the remote resource hangs, your script hangs until PHP times out and produces a fatal error - maybe 30 seconds in the future.  With cURL you can set a much shorter timeout and you can add error handling to degrade gracefully.
0
 
Michel PlungjanIT ExpertAuthor Commented:
ah! thanks
0

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

  • 5
  • 4
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now