asked on

Illegal attempt to associate a collection with two open sessions

Hello there,

I am trying to update a record in one of the frames in my application and I get this error. Before it was working fine. I mean I could add and update the records in the frame. then I added the delete operation and the del is working but when I try to update I get this error. please help. I have attached my classes.

cheers
Zolf

org.hibernate.HibernateException: Illegal attempt to associate a collection with two open sessions
=== 2014-01-28 09:45:18,612 [l0-2] DEBUG RPCManager - Content type for RPC transaction: text/plain; charset=UTF-8
=== 2014-01-28 09:45:18,612 [l0-2] DEBUG RPCManager - DMI response, dropExtraFields: true
=== 2014-01-28 09:45:18,612 [l0-2] INFO Compression - /kaizenerpweb/sc/IDACall: 144 -> 132 bytes
      at org.hibernate.collection.AbstractPersistentCollection.setCurrentSession(AbstractPersistentCollection.java:432)
      at org.hibernate.event.def.OnUpdateVisitor.processCollection(OnUpdateVisitor.java:66)
      at org.hibernate.event.def.AbstractVisitor.processValue(AbstractVisitor.java:124)
      at org.hibernate.event.def.AbstractVisitor.processValue(AbstractVisitor.java:84)
      at org.hibernate.event.def.AbstractVisitor.processEntityPropertyValues(AbstractVisitor.java:78)
      at org.hibernate.event.def.AbstractVisitor.process(AbstractVisitor.java:146)
      at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.performUpdate(DefaultSaveOrUpdateEventListener.java:316)
      at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.entityIsDetached(DefaultSaveOrUpdateEventListener.java:246)
      at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.performSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:112)
      at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:93)
      at org.hibernate.impl.SessionImpl.fireSaveOrUpdate(SessionImpl.java:535)
      at org.hibernate.impl.SessionImpl.saveOrUpdate(SessionImpl.java:527)
      at org.hibernate.impl.SessionImpl.saveOrUpdate(SessionImpl.java:523)
      at com.kaizen.erp.server.bussinessLogic.supplier.SupplierOrderBussinessLogic.saveSupplierOrder(SupplierOrderBussinessLogic.java:134)
      at com.kaizen.erp.server.bussinessLogic.supplier.SupplierOrderBussinessLogic.add(SupplierOrderBussinessLogic.java:110)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
      at java.lang.reflect.Method.invoke(Unknown Source)
SupplierOrderBussinessLogic.java
SupplierOrder.hbm.xml

mccarl

Can you provide the code for your HibernateUtils class please?

Zolf

ASKER

Hi mccarl,

I have attached the file you mentioned.

cheers
Zolf
HibernateUtills.java

mccarl

Ok, I believe this error is due to the "supplierOrder" object being retrieved in the "getSupplierOrderFromRequest" method (line 108) under one session and then attempting to saveOrUpdate the same object in the "saveSupplierOrder" method (line 110) under a new session. And since your session handling seems "a bit odd" and you are only closing sessions when "session.isConnected()" is false (and I'm guessing that generally it isn't false) that the first session is still open when you are trying to manipulate your object in the second session.

So some potential fixes are... properly closing the session regardless if it is still connected may work (although that may introduce other problems, it's hard to tell with your code a bit all over the place). Otherwise, try and only open the one session for the entire request, rather than having that "add" method where you call additional methods that each opens its own session.

Zolf

ASKER

thanks for your comments. but It was working properly before when I added the one to many in the SupplierOrder.hbm.xml to be able to perform delete cascade, then this issue came up in the update process.

ASKER CERTIFIED SOLUTION

mccarl

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

Zolf

ASKER

also when I try to run a simple code like this too I get the error. I guess it has to do with this one to many which I added to my hbm.xml file

public static void main(String []args){
SupplierOrder supplierOrder = getInstance().getSupplierOrderById(1L);
if(supplierOrder!=null)
getInstance().saveSupplierOrder(supplierOrder);
else
System.out.println("null");
}