Solved

Query help needed

Posted on 2014-02-01
9
145 Views
Last Modified: 2014-02-01
I need help with the logic of this query.

I have two tables - customers and orders.

Customers
--------------------------------------
custid    name
1            Joe
2            Sam
3            Rick

Orders
-------------------------------------
orderid  custid  orderdate           status
1               1        01/01/2006       posted
2               1        10/10/2013       posted
3               1        01/14/2014       in process
4               2        02/02/2008       posted

I need the query to select all customers where the orderdate =>01/01/2012 AND the status is posted.

The criteria for the expected customer results is based on the values in orders. Currently the results I am getting include duplication of customers where there are more than one order that meets the criteria.

Example:
SELECT * from Customers
INNER JOIN    -- have tried other joins also
custid on customer.custid = orders.custid
WHERE
status = 'posted' and orderdate >= 01/01/2012

This results in two duplicate records in the results for custid 1

How do I need to properly construct the query to get the desired results?
0
Comment
Question by:ckelsoe
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 5
  • 3
9 Comments
 
LVL 61

Expert Comment

by:mbizup
ID: 39826643
What database platform are you using?

Access?  SQL Server?  ...?  (this makes a difference)

Try delimiting your dates:


status = 'posted' and orderdate >= #01/01/2012#       (MS Access)

status = 'posted' and orderdate >= '01/01/2012'       (SQL Server and others)


(Without the delimiters, 01/01/2012 is 1 divided by 1 divided by 2012)
0
 
LVL 45

Accepted Solution

by:
Kent Olsen earned 500 total points
ID: 39826659
Hi ckelsoe,

Probably the easiest to select the most recent when there are duplicates.

SELECT * 
FROM customers c
INNER JOIN order o
  ON c.customer_id = o.customer_id
WHERE order_date >= '01/'1/2-13'
  AND order_status = 'posted'
  AND order_id = (select max(order_id) from order o1 where o1.customer_id = o.customer_id and o1.order_status = 'posted')

Open in new window



That should work fine in SQL Server.


Good Luck,
Kent
0
 

Author Closing Comment

by:ckelsoe
ID: 39826701
Thanks - I think that should work perfectly for what I need.
0
Guide to Performance: Optimization & Monitoring

Nowadays, monitoring is a mixture of tools, systems, and codes—making it a very complex process. And with this complexity, comes variables for failure. Get DZone’s new Guide to Performance to learn how to proactively find these variables and solve them before a disruption occurs.

 

Author Comment

by:ckelsoe
ID: 39827107
Ok I now have this issue. The MAX(OrderID) does not work as there is a case where the highest order id does not have the date within the scope. An earlier orderid does have a date within scope. The code as written above drops that customer when it should be included in the results. I tried changing it to max(order_date) but that returns no results at all. Ideas?
0
 

Author Comment

by:ckelsoe
ID: 39827123
So this works:
SELECT
	MAX (PostedDate)
FROM
	ERCHistory
WHERE
	customerid = 394
AND ERCStatus = 'posted'

Open in new window


But this does not:
SELECT
	c.CustomerID,
	c.Business,
	c.BusName,
	c.NameLast,
	c.NameFirst,
	c.Address1,
	c.City,
	c.State,
	c.Zip,
	c.Phone,
	c.BusPhone,
	c.Cell,
	c.Email,
	c.Pager,
	c.ResaleNumber,
	c.TaxExemptParts,
	c.TaxExemptLabor,
	c.[TimeStamp]
FROM
	dbo.Customer c
INNER JOIN dbo.ERCHistory o ON c.CustomerID = o.CustomerID
WHERE
	o.ERCStatus = 'Posted'
AND o.PostedDate >= '01/01/2006'
AND o.ERCID = (
	SELECT
		MAX (PostedDate)
	FROM
		ERCHistory o1
	WHERE
		o1.CustomerID = o.CustomerID
	AND o1.ERCStatus = 'posted'
)
ORDER BY c.CustomerID ASC

Open in new window


The initial code at MAX (ERCID) which did work.

Here is the data that is causing the issue:
ERCID      CustomerID      ERCStatus      PostedDate
913              394      Posted      2004-09-15-00:00:00.000
1064      394      Posted      2005-03-09-00:00:00.000
1103      394      Posted      2005-04-26-00:00:00.000
1281      394      Posted      2006-01-10-00:00:00.000
1282      394      Posted      2005-12-30-00:00:00.000
0
 
LVL 45

Expert Comment

by:Kent Olsen
ID: 39827162
No problem.  With just need to include the data check in the inner filter.  I had assumed that the dates would increment as the ID value did...

SELECT *
FROM customers c
INNER JOIN order o
  ON c.customer_id = o.customer_id
WHERE order_date >= '01/01/2013'
  AND order_status = 'posted'
  AND order_id = (select max(order_id) from order o1 where o1.customer_id = o.customer_id and o1.order_status = 'posted' and order_date >= '01/01/2013')
                                           

Try that one.  :)
0
 

Author Comment

by:ckelsoe
ID: 39827170
Ok It is still not picking up the cases where the highest ercid does not have the latest posteddate. Here is the modified code looks like this:
SELECT
	c.CustomerID,
	c.Business,
	c.BusName,
	c.NameLast,
	c.NameFirst,
	c.Address1,
	c.City,
	c.State,
	c.Zip,
	c.Phone,
	c.BusPhone,
	c.Cell,
	c.Email,
	c.Pager,
	c.ResaleNumber,
	c.TaxExemptParts,
	c.TaxExemptLabor,
	c.[TimeStamp]
FROM
	dbo.Customer c
INNER JOIN dbo.ERCHistory o ON c.CustomerID = o.CustomerID
WHERE
	o.ERCStatus = 'Posted'
AND o.PostedDate >= '01/01/2006'
AND o.ERCID = (
	SELECT
		MAX (ERCID)
	FROM
		ERCHistory o1
	WHERE
		o1.CustomerID = o.CustomerID
	AND o1.ERCStatus = 'posted'
  AND o.PostedDate >= '01/01/2006'
)
ORDER BY c.CustomerID ASC

Open in new window

0
 
LVL 45

Expert Comment

by:Kent Olsen
ID: 39827184
Line 34.

It should read,

  AND o1.PostedDate >= '01/01/2006'
0
 

Author Comment

by:ckelsoe
ID: 39827212
Missed that - THANK YOU!!!!
0

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
SQL Recursion schedule 13 48
SQL Rewrite without the NULLIF 4 33
Problem with MySQL query - graph 3 46
Can a Trigger trigger a Trigger? 4 47
Occasionally there is a need to clean table columns, especially if you have inherited legacy data. There are obviously many ways to accomplish that, including elaborate UPDATE queries with anywhere from one to numerous REPLACE functions (even within…
Composite queries are used to retrieve the results from joining multiple queries after applying any filters. UNION, INTERSECT, MINUS, and UNION ALL are some of the operators used to get certain desired results.​
In an interesting question (https://www.experts-exchange.com/questions/29008360/) here at Experts Exchange, a member asked how to split a single image into multiple images. The primary usage for this is to place many photographs on a flatbed scanner…

738 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question