?
Solved

Close a file vba

Posted on 2014-02-04
4
Medium Priority
?
373 Views
Last Modified: 2014-02-05
Using the code below to open a file.  How would I close the file?


    DIV = Application.GetOpenFilename(FileFilter:="xls*.Files (*.xls*), *.xls*", Title:="Please select a file")
   

      'browse boxes may be on the main parm sheet i.e. Sheets("Main").VAR_DIV = DIV
 '    Application.EnableEvents = False
'Application.DisplayAlerts = False
Sheets("Variances").VAR_DIV = DIV


     Workbooks.Open (DIV)
0
Comment
Question by:leezac
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
4 Comments
 
LVL 22

Expert Comment

by:rspahitz
ID: 39834183
Have you tried something like this:

    ActiveWorkbook.Close
    application.Quit

Open in new window

0
 
LVL 81

Accepted Solution

by:
byundt earned 2000 total points
ID: 39834212
If you have been selecting cells or worksheets, the active workbook may not be the one that you want to close. It is better practice to specify the workbook by name, or by using a variable pointing to it. Both alternatives are shown in the snippet below.
Dim DIV As String, flName As String
Dim wb As Workbook
DIV = Application.GetOpenFilename(FileFilter:="xls*.Files (*.xls*), *.xls*", Title:="Please select a file")
flName = Mid(DIV, InStrRev(Application.PathSeparator & DIV, Application.PathSeparator))
      'browse boxes may be on the main parm sheet i.e. Sheets("Main").VAR_DIV = DIV
 '    Application.EnableEvents = False
'Application.DisplayAlerts = False
Sheets("Variances").VAR_DIV = DIV

Set wb = Workbooks.Open(DIV)

    'Close the workbook without displaying a warning about unsaved file. Two alternatives are shown.
Workbooks(flName).Close SaveChanges:=False      'Close the file using its name
wb.Close SaveChanges:=False      'Close the file using a workbook variable

Open in new window

0
 

Author Comment

by:leezac
ID: 39835931
Brad - this is in relation to last post you helped with

This is what I am using to close.  the close line did not work until I added the Set line.  Is that correct though?
__________________________________________________________
Lastrow = ActiveSheet.Cells(Rows.Count, 1).End(xlUp).row
 
    Range("G4:G7" & Lastrow).Select
    Application.CutCopyMode = False
    Selection.Copy
    Windows("Cap Gain Div Cust Variance Template.xlsm").Activate
     Range("L3").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
   'Close the workbook without displaying a warning about unsaved file. Two alternatives are shown.

Set wb = Workbooks.Open(DIV)
wb.Close SaveChanges:=False      'Close the file using a workbook
End Sub
0
 
LVL 22

Expert Comment

by:rspahitz
ID: 39836239
In VBA, "Set" is required whenever assigning objects (such as workbooks and Sheets) to variables.
It's not needed for lines like this:
Application.CutCopyMode = False
because the property is not an object.
0

Featured Post

VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

How to get Spreadsheet Compare 2016 working with the 64 bit version of Office 2016
This article describes how you can use Custom Document Properties to store settings and other information in your workbook so that they will be available the next time you open the workbook.
This Micro Tutorial demonstrate the bugs in Microsoft Excel for Mac with Pivot Charts.
This Micro Tutorial demonstrates using Microsoft Excel pivot tables, how to reverse engineer competitors' marketing strategies through backlinks.

765 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question