Solved

SQL query subselect

Posted on 2014-02-10
5
323 Views
Last Modified: 2014-02-20
I have a staging table with data that gets fed in from flat files.  I need to insert that data into another table, but my query is not working. It works, it just doesn't insert all the coorect records, so I need to fix the query.  
The staging table gets records inserted and then updated data causes duplicate records to be inserted.  I need the most current records.  Here is a sample of data to help illustrate my issue.  For this sample data I will need records 2 and 4 inserted, however, my query is now only selecting record 4.  Please help.  Thank you.  Here is my query.
INSERT INTO MY_TBL2
SELECT * FROM MY_TBL1 W
WHERE LOADDATE = (SELECT MAX(LOADDATE)
            FROM MY_TBL2 V
            WHERE W.BCODE = V.BCODE)
            order by BCODE

BCODE SAMPLEID  ACTIVITY  MEASUREMENT  ITEMNAME  LOADDATE
99999   1                  act1          meas1                 Item1           10/3/2012
99999   1                  act1          meas1                 Item1           10/4/2012
99999   2                  act2          meas2                 Item2           10/3/2012
99999   2                  act2          meas2                 Item2           10/4/2012
0
Comment
Question by:newtoperlpgm
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
5 Comments
 
LVL 74

Accepted Solution

by:
sdstuber earned 250 total points
ID: 39848588
I'm not sure why your subquery was against tbl2.  That seems to ensure that each time you load data, you'll reinsert the same data you already read before.

Instead, just read table1 one time and sort it to pick out the rows you need

INSERT INTO my_tbl2
    SELECT bcode,
           sampleid,
           activity,
           measurement,
           itemname,
           loaddate
      FROM (SELECT t.*, ROW_NUMBER() OVER(PARTITION BY bcode,sampleid ORDER BY loaddate DESC) rn
              FROM my_tbl1 t)
     WHERE rn = 1
order by bcode
0
 

Author Comment

by:newtoperlpgm
ID: 39848629
Hi, that was a typo, it should have said tbl1, but that doesn't matter anymore, because the query you supplied worked great.  Can you explain the query, though, what it does, because I spent many hours trying to find a query that would obtain the desired results, that is, the rows that were the most recently updated for the bcode and sampleid, but couldn't come up with one.  If I understand the query, I can apply that knowledge I just learned to subsequent sql tasks.
Thanks very much.
0
 
LVL 35

Assisted Solution

by:Mark Geerlings
Mark Geerlings earned 250 total points
ID: 39848660
I think you already identified the problem: "the rows that were the most recently updated for the bcode and sampleid", but your query only looked at: bcode.

If you adjust your original query like this, I think that will also work:

INSERT INTO MY_TBL2
SELECT * FROM MY_TBL1 W
WHERE LOADDATE = (SELECT MAX(LOADDATE)
            FROM MY_TBL1 V
            WHERE V.BCODE = W.BCODE
               AND V.SAMPLID = W.SAMPLEID)
            order by BCODE
0
 
LVL 74

Expert Comment

by:sdstuber
ID: 39848684
>>>> Can you explain the query, though, what it does, because I spent many hours trying to find a query

work it from the inside out..

This is the inner most query...


(SELECT t.*, ROW_NUMBER() OVER(PARTITION BY bcode,sampleid ORDER BY loaddate DESC) rn
              FROM my_tbl1 t)


this pulls everything from your table, but adds one new column to the results.  
This numbers your data in groups (partitions)

each bcode/sampleid  is taken as one group.
The rows within each group are numbered by date in descending order (so the latest is 1, next is 2 and so on)


BCODE SAMPLEID  ACTIVITY  MEASUREMENT  ITEMNAME  LOADDATE   RN
99999   1                  act1          meas1                 Item1           10/3/2012   2
99999   1                  act1          meas1                 Item1           10/4/2012   1
99999   2                  act2          meas2                 Item2           10/3/2012   2
99999   2                  act2          meas2                 Item2           10/4/2012    1


Then,  in the outer query, I keep only the rows that have rn=1,  so that's the latest for each group/partition.
0
 

Author Comment

by:newtoperlpgm
ID: 39861448
Thank you for the explanation.
0

Featured Post

On Demand Webinar: Networking for the Cloud Era

Did you know SD-WANs can improve network connectivity? Check out this webinar to learn how an SD-WAN simplified, one-click tool can help you migrate and manage data in the cloud.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Why doesn't the Oracle optimizer use my index? Querying too much data Most Oracle developers know that an index is useful when you can use it to restrict your result set to a small number of the total rows in a table. So, the obvious side…
This article started out as an Experts-Exchange question, which then grew into a quick tip to go along with an IOUG presentation for the Collaborate confernce and then later grew again into a full blown article with expanded functionality and legacy…
This video explains at a high level with the mandatory Oracle Memory processes are as well as touching on some of the more common optional ones.
This video shows information on the Oracle Data Dictionary, starting with the Oracle documentation, explaining the different types of Data Dictionary views available by group and permissions as well as giving examples on how to retrieve data from th…
Suggested Courses

632 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question