Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 384
  • Last Modified:

How to change a large complex Report query in code

The dates in this query begin as #1/1/2013# And #12/31/2013# and I need to change them with the dates in the text below.

Dim XbyAfrom as Date
Dim XbyAto as Date
Dim qdf As QueryDef

                XbyAfrom = #3/1/2013#
                XbyAto = #8/31/2013#


Set qdf = CurrentDb.QueryDefs("qy_DateToDateTransactionReport")
qdf.Parameters!TradeDate = "Between " & XbyAfrom & " And " & XbyAto
Reports![RpQtr-Transactions131231YTD by account].RecordSource = "qy_DateToDateTransactionReport"
                DoCmd.OpenReport "RpQtr-Transactions131231YTD by account", acViewPreview, "qy_DateToDateTransactionReport", "HHID = " & ClientNowPrinting

This compiles and runs ok, but doesn't work to change the date range.  Am I even close?

Some duplication here, but you get the idea.   What's wrong, please?

All I need to do is replace the dates in a huge query.  Not so simple using all this text in code, because of all the line breaks.  I'm considering just "finding" the dates by using Right and Left instructions and replacing them by manipulating the string.
0
David_W_R
Asked:
David_W_R
  • 6
  • 5
1 Solution
 
JimFiveCommented:
Where are your dates coming from?  If they are in a form you can use [Forms]![FormName]![FormField] as the query parameter.
0
 
David_W_RAuthor Commented:
Yes, they are coming from a form, so...

qdf.Parameters!TradeDate = "Between " & [Forms]![FormName]![txtbox1] & " And " & [Forms]![FormName]![txtbox2] should work?

Why don't the variables work just as well?   They were assigned the values from the same form controls.
0
 
JimFiveCommented:
Probably Not.  TradeDate as a parameter in the actual query probably makes the query look like "...WHERE SomeDate = [TradeDate]"  If that is true you need to change the query to say something like "...WHERE SomeDate BETWEEN [Forms]![FormName]![txtbox1] AND [Forms]![FormName]![txtbox2]  Then you need to do NOTHING in the vba code.
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
David_W_RAuthor Commented:
That's simple enough, and viable, but I had intended the Report to be used with or without the Form, so can I just replace the variables in my original code with the Form references when the Form is open?
0
 
David_W_RAuthor Commented:
I tried replacing the variables with Form control references, and it does not appear to work.  No errors thrown, but no effect on the Report date range.

qdf.Parameters!TradeDate = "Between " & Forms!fm_ReportPrinter!txtYtoYbyAcctFrom & " And " & Forms!fm_ReportPrinter!txtYtoYbyAcctTo

Does this need some kind of refresh or update command to take effect?
How can I print the parameter after the command is executed?

Debug.print qdf.Parameters!TradeDate    ??
0
 
JimFiveCommented:
How are you going to get the date range without the form?

Here's what I usually do.  I create the dialog form for the parameters and I create the query to reference that form.  Then, I put code in the Reports OnOpen Event to open the dialog to get the parameters.  On the Dialog form the "Display Report" button hides the dialog but keeps it open which allows the OnOpen event of the report to finish and keeps the form controls available for the query.  The "Cancel" button closes the dialog form.  The Reports OnOpen event checks for the form being open and if it is not then it cancels the report.  Then whenever you try to open the report the dialog pops up asking for the parameters and the form controls are available for the query.
If you want to be able to run the reports automatically you just need to pass the data you want to use to the form using the openarguments parameter and then use the forms OnOpen event to fill in the controls and automatically hide the dialog if openarguments is not null.
0
 
JimFiveCommented:
What does your actual query look like.  You can't set the parameter "TradeDate" = "Between Date1 and Date2" because that is not a parameter.  The parameter needs to be a single date.  The "Between" needs to be in the original query.
0
 
David_W_RAuthor Commented:
I like that.   Plenty of meat to digest.  Thanks a bunch!
0
 
David_W_RAuthor Commented:
So the Date1 and Date2 need to be separate variables?
0
 
JimFiveCommented:
Yes, Date1 and Date2 need to be separate.
0
 
David_W_RAuthor Commented:
Thanks again.   I have my homework assignment for tomorrow.
0

Featured Post

NEW Veeam Backup for Microsoft Office 365 1.5

With Office 365, it’s your data and your responsibility to protect it. NEW Veeam Backup for Microsoft Office 365 eliminates the risk of losing access to your Office 365 data.

  • 6
  • 5
Tackle projects and never again get stuck behind a technical roadblock.
Join Now