Solved

How to change a large complex Report query in code

Posted on 2014-02-20
11
369 Views
Last Modified: 2014-02-20
The dates in this query begin as #1/1/2013# And #12/31/2013# and I need to change them with the dates in the text below.

Dim XbyAfrom as Date
Dim XbyAto as Date
Dim qdf As QueryDef

                XbyAfrom = #3/1/2013#
                XbyAto = #8/31/2013#


Set qdf = CurrentDb.QueryDefs("qy_DateToDateTransactionReport")
qdf.Parameters!TradeDate = "Between " & XbyAfrom & " And " & XbyAto
Reports![RpQtr-Transactions131231YTD by account].RecordSource = "qy_DateToDateTransactionReport"
                DoCmd.OpenReport "RpQtr-Transactions131231YTD by account", acViewPreview, "qy_DateToDateTransactionReport", "HHID = " & ClientNowPrinting

This compiles and runs ok, but doesn't work to change the date range.  Am I even close?

Some duplication here, but you get the idea.   What's wrong, please?

All I need to do is replace the dates in a huge query.  Not so simple using all this text in code, because of all the line breaks.  I'm considering just "finding" the dates by using Right and Left instructions and replacing them by manipulating the string.
0
Comment
Question by:David_W_R
  • 6
  • 5
11 Comments
 
LVL 15

Expert Comment

by:JimFive
Comment Utility
Where are your dates coming from?  If they are in a form you can use [Forms]![FormName]![FormField] as the query parameter.
0
 

Author Comment

by:David_W_R
Comment Utility
Yes, they are coming from a form, so...

qdf.Parameters!TradeDate = "Between " & [Forms]![FormName]![txtbox1] & " And " & [Forms]![FormName]![txtbox2] should work?

Why don't the variables work just as well?   They were assigned the values from the same form controls.
0
 
LVL 15

Expert Comment

by:JimFive
Comment Utility
Probably Not.  TradeDate as a parameter in the actual query probably makes the query look like "...WHERE SomeDate = [TradeDate]"  If that is true you need to change the query to say something like "...WHERE SomeDate BETWEEN [Forms]![FormName]![txtbox1] AND [Forms]![FormName]![txtbox2]  Then you need to do NOTHING in the vba code.
0
 

Author Comment

by:David_W_R
Comment Utility
That's simple enough, and viable, but I had intended the Report to be used with or without the Form, so can I just replace the variables in my original code with the Form references when the Form is open?
0
 

Author Comment

by:David_W_R
Comment Utility
I tried replacing the variables with Form control references, and it does not appear to work.  No errors thrown, but no effect on the Report date range.

qdf.Parameters!TradeDate = "Between " & Forms!fm_ReportPrinter!txtYtoYbyAcctFrom & " And " & Forms!fm_ReportPrinter!txtYtoYbyAcctTo

Does this need some kind of refresh or update command to take effect?
How can I print the parameter after the command is executed?

Debug.print qdf.Parameters!TradeDate    ??
0
How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

 
LVL 15

Accepted Solution

by:
JimFive earned 500 total points
Comment Utility
How are you going to get the date range without the form?

Here's what I usually do.  I create the dialog form for the parameters and I create the query to reference that form.  Then, I put code in the Reports OnOpen Event to open the dialog to get the parameters.  On the Dialog form the "Display Report" button hides the dialog but keeps it open which allows the OnOpen event of the report to finish and keeps the form controls available for the query.  The "Cancel" button closes the dialog form.  The Reports OnOpen event checks for the form being open and if it is not then it cancels the report.  Then whenever you try to open the report the dialog pops up asking for the parameters and the form controls are available for the query.
If you want to be able to run the reports automatically you just need to pass the data you want to use to the form using the openarguments parameter and then use the forms OnOpen event to fill in the controls and automatically hide the dialog if openarguments is not null.
0
 
LVL 15

Expert Comment

by:JimFive
Comment Utility
What does your actual query look like.  You can't set the parameter "TradeDate" = "Between Date1 and Date2" because that is not a parameter.  The parameter needs to be a single date.  The "Between" needs to be in the original query.
0
 

Author Closing Comment

by:David_W_R
Comment Utility
I like that.   Plenty of meat to digest.  Thanks a bunch!
0
 

Author Comment

by:David_W_R
Comment Utility
So the Date1 and Date2 need to be separate variables?
0
 
LVL 15

Expert Comment

by:JimFive
Comment Utility
Yes, Date1 and Date2 need to be separate.
0
 

Author Comment

by:David_W_R
Comment Utility
Thanks again.   I have my homework assignment for tomorrow.
0

Featured Post

Highfive + Dolby Voice = No More Audio Complaints!

Poor audio quality is one of the top reasons people don’t use video conferencing. Get the crispest, clearest audio powered by Dolby Voice in every meeting. Highfive and Dolby Voice deliver the best video conferencing and audio experience for every meeting and every room.

Join & Write a Comment

Regardless of which version on MS Access you are using, one of the harder data-entry forms to create is one where most data from previous entries needs to be appended to new records, especially when there are numerous fields and records involved.  W…
Introduction The Visual Basic for Applications (VBA) language is at the heart of every application that you write. It is your key to taking Access beyond the world of wizards into a world where anything is possible. This article introduces you to…
With Microsoft Access, learn how to specify relationships between tables and set various options on the relationship. Add the tables: Create the relationship: Decide if you’re going to set referential integrity: Decide if you want cascade upda…
With Microsoft Access, learn how to start a database in different ways and produce different start-up actions allowing you to use a single database to perform multiple tasks. Specify a start-up form through options: Specify an Autoexec macro: Us…

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now