Solved

Calculator help

Posted on 2014-02-23
4
308 Views
Last Modified: 2014-02-23
I am getting errors on the line decimal result = Convert.ToDecimal(txtResult.Text);. It says input string is not in the correct format. I am new to C# so, any help would be appreciated. Thanks in advance.

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;

namespace Calculator
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
            this.Load += new EventHandler(Form1_Load);
        }
        private void btnExit_Click(object sender, EventArgs e)
        {
            this.Close();
        }

        private void btnCalculate_Click(object sender, EventArgs e)
        {
            decimal operand1 = Convert.ToDecimal(txtOperand1.Text);
            decimal operand2 = Convert.ToDecimal(txtOperand2.Text);
            decimal result = Convert.ToDecimal(txtResult.Text);
            
            string operator1 = txtOperator.Text;

            if (operator1 == "+")
            {
                result = operand1 + operand2;
                
            }

            else if (operator1 == "-")
	        {
		        result= operand1-operand2;
                
	        }
            else if (operator1 == "*")
	        {
                result = operand1 * operand2;
               
	        }
            else if (operator1 == "/")
            {
                result = operand1 / operand2;
             
            }

        }

        private void Form1_Load(object sender, EventArgs e)
        {

        }

    }
}

Open in new window

0
Comment
Question by:ryanbecker24
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
4 Comments
 
LVL 86

Expert Comment

by:Mike Tomlinson
ID: 39881290
The result is being calculated, so you should be outputting it, not reading it in from the form.

Change:
        private void btnCalculate_Click(object sender, EventArgs e)
        {
            decimal operand1 = Convert.ToDecimal(txtOperand1.Text);
            decimal operand2 = Convert.ToDecimal(txtOperand2.Text);
            decimal result = Convert.ToDecimal(txtResult.Text);
            
            string operator1 = txtOperator.Text;

            if (operator1 == "+")
            {
                result = operand1 + operand2;
                
            }

            else if (operator1 == "-")
	        {
		        result= operand1-operand2;
                
	        }
            else if (operator1 == "*")
	        {
                result = operand1 * operand2;
               
	        }
            else if (operator1 == "/")
            {
                result = operand1 / operand2;
             
            }

        }

Open in new window


To:
        private void btnCalculate_Click(object sender, EventArgs e)
        {
            decimal operand1 = Convert.ToDecimal(txtOperand1.Text);
            decimal operand2 = Convert.ToDecimal(txtOperand2.Text);            
            string operator1 = txtOperator.Text;

            decimal result;
            if (operator1 == "+")
            {
                result = operand1 + operand2;
                
            }

            else if (operator1 == "-")
	        {
		        result= operand1-operand2;
                
	        }
            else if (operator1 == "*")
	        {
                result = operand1 * operand2;
               
	        }
            else if (operator1 == "/")
            {
                result = operand1 / operand2;
             
            }

            txtResult.Text = result.ToString();
        }

Open in new window


*That error will occur for "operand1" and "operand2" if the value in the TextBox cannot be converted to a proper decimal.  To prevent that type of error, use Decimal.TryParse().
0
 

Author Comment

by:ryanbecker24
ID: 39881303
Thanks, but txtResult.Text = result.ToString() isn't working. It is saying use of unassigned local variable, but its being used though. Also, I don't understand what you mean with the asterisk. Sorry, for all the questions
0
 
LVL 86

Accepted Solution

by:
Mike Tomlinson earned 500 total points
ID: 39881311
Just give your result variable an initial value:

    decimal result = 0.0;
0
 

Author Comment

by:ryanbecker24
ID: 39881425
Thank you
0

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Go is an acronym of golang, is a programming language developed Google in 2007. Go is a new language that is mostly in the C family, with significant input from Pascal/Modula/Oberon family. Hence Go arisen as low-level language with fast compilation…
Exception Handling is in the core of any application that is able to dignify its name. In this article, I'll guide you through the process of writing a DRY (Don't Repeat Yourself) Exception Handling mechanism, using Aspect Oriented Programming.
This tutorial will introduce the viewer to VisualVM for the Java platform application. This video explains an example program and covers the Overview, Monitor, and Heap Dump tabs.
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.

691 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question