Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 311
  • Last Modified:

Calculator help

I am getting errors on the line decimal result = Convert.ToDecimal(txtResult.Text);. It says input string is not in the correct format. I am new to C# so, any help would be appreciated. Thanks in advance.

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;

namespace Calculator
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
            this.Load += new EventHandler(Form1_Load);
        }
        private void btnExit_Click(object sender, EventArgs e)
        {
            this.Close();
        }

        private void btnCalculate_Click(object sender, EventArgs e)
        {
            decimal operand1 = Convert.ToDecimal(txtOperand1.Text);
            decimal operand2 = Convert.ToDecimal(txtOperand2.Text);
            decimal result = Convert.ToDecimal(txtResult.Text);
            
            string operator1 = txtOperator.Text;

            if (operator1 == "+")
            {
                result = operand1 + operand2;
                
            }

            else if (operator1 == "-")
	        {
		        result= operand1-operand2;
                
	        }
            else if (operator1 == "*")
	        {
                result = operand1 * operand2;
               
	        }
            else if (operator1 == "/")
            {
                result = operand1 / operand2;
             
            }

        }

        private void Form1_Load(object sender, EventArgs e)
        {

        }

    }
}

Open in new window

0
ryanbecker24
Asked:
ryanbecker24
  • 2
  • 2
1 Solution
 
Mike TomlinsonMiddle School Assistant TeacherCommented:
The result is being calculated, so you should be outputting it, not reading it in from the form.

Change:
        private void btnCalculate_Click(object sender, EventArgs e)
        {
            decimal operand1 = Convert.ToDecimal(txtOperand1.Text);
            decimal operand2 = Convert.ToDecimal(txtOperand2.Text);
            decimal result = Convert.ToDecimal(txtResult.Text);
            
            string operator1 = txtOperator.Text;

            if (operator1 == "+")
            {
                result = operand1 + operand2;
                
            }

            else if (operator1 == "-")
	        {
		        result= operand1-operand2;
                
	        }
            else if (operator1 == "*")
	        {
                result = operand1 * operand2;
               
	        }
            else if (operator1 == "/")
            {
                result = operand1 / operand2;
             
            }

        }

Open in new window


To:
        private void btnCalculate_Click(object sender, EventArgs e)
        {
            decimal operand1 = Convert.ToDecimal(txtOperand1.Text);
            decimal operand2 = Convert.ToDecimal(txtOperand2.Text);            
            string operator1 = txtOperator.Text;

            decimal result;
            if (operator1 == "+")
            {
                result = operand1 + operand2;
                
            }

            else if (operator1 == "-")
	        {
		        result= operand1-operand2;
                
	        }
            else if (operator1 == "*")
	        {
                result = operand1 * operand2;
               
	        }
            else if (operator1 == "/")
            {
                result = operand1 / operand2;
             
            }

            txtResult.Text = result.ToString();
        }

Open in new window


*That error will occur for "operand1" and "operand2" if the value in the TextBox cannot be converted to a proper decimal.  To prevent that type of error, use Decimal.TryParse().
0
 
ryanbecker24Author Commented:
Thanks, but txtResult.Text = result.ToString() isn't working. It is saying use of unassigned local variable, but its being used though. Also, I don't understand what you mean with the asterisk. Sorry, for all the questions
0
 
Mike TomlinsonMiddle School Assistant TeacherCommented:
Just give your result variable an initial value:

    decimal result = 0.0;
0
 
ryanbecker24Author Commented:
Thank you
0

Featured Post

[Webinar] Database Backup and Recovery

Does your company store data on premises, off site, in the cloud, or a combination of these? If you answered “yes”, you need a data backup recovery plan that fits each and every platform. Watch now as as Percona teaches us how to build agile data backup recovery plan.

  • 2
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now