Solved

Closing a reader attached to a grid

Posted on 2014-02-27
14
355 Views
Last Modified: 2014-02-28
I have a grid which I populate by using a sqldatareader.

            grdSelector.DataSource = GetSource(blah)

Open in new window


My GetSource consists of this, which returns a SqlDataReader

         Dim dr As SqlDataReader = Nothing
         Dim sql As String = GetQuery(Blah)
         Dim con As New SqlConnection(Name.GetConnectionString)
         Dim cmd As New SqlCommand(sql.ToString(), con)
         cmd.CommandType = CommandType.Text
         cmd.CommandTimeout = 600 
         con.Open()
         dr = cmd.ExecuteReader(CommandBehavior.CloseConnection) ' close the connection when the reader is closed
         Return dr

Open in new window


Okay, so I set my reader to CloseConnection when the reader is closed. But when is the reader closed?

I am populating my grid with it using the grid.DataSource, but when is the reader closed? Is it automatically closed when the user leaves the page? Or do I need to specifically close that reader somewhere? If so, where and how?

thanks!
0
Comment
Question by:BobCSD
  • 7
  • 4
  • 3
14 Comments
 
LVL 62

Assisted Solution

by:Fernando Soto
Fernando Soto earned 167 total points
ID: 39893349
Close it immediately after loading the grid.

Dim dr As SqlDataReader = GetSource(blah)
grdSelector.DataSource = dr
dr.Close()

Open in new window

0
 
LVL 83

Expert Comment

by:CodeCruiser
ID: 39894506
I know this is unrelated to your question but would mention this in case you are not aware. Data reader is usually used when you want to either load a single record or loop through records to do some processing. For grids, using a table adapter to populate a datatable is usually a preferred method as it downloads all data simultaneously as opposed to data reader which only downloads one row at a time.
0
 
LVL 1

Author Comment

by:BobCSD
ID: 39895232
Thank you CodeCruiser, I will change that. I assume that applies to populating comboboxes as well.
0
 
LVL 1

Author Comment

by:BobCSD
ID: 39895253
Also:

I don't define my datareader like this:
Dim dr As SqlDataReader = GetSource(blah)
grdSelector.DataSource = dr
dr.Close() 

Open in new window


I call a method that returns a data reader like this:
 Dim daOrm As DataAccess.CustomDepartment = New DataAccess.CustomDepartment()
            grdSelector.DataSource = daOrm.GetDepartmentByClientIdSqlCommandReader(ClientId)

Open in new window



Here is the gist of the method:
            Dim dr As SqlDataReader = Nothing
            Dim con As New SqlConnection(Name.GetConnectionString)
            Dim cmd As New SqlCommand(sql.ToString(), con)
            cmd.CommandType = CommandType.Text
            con.Open()
            dr = cmd.ExecuteReader(CommandBehavior.CloseConnection) ' close the connection when the reader is closed
            Return dr

Open in new window


If I somehow use a using block around that, will it close the datareader or just the connection?

I believe I remember trying to put a using block around it before and when it loaded into my grid it had no values in it and was empty. I'd have to try again to see what happened, but pretty sure.

Any ideas for me rather than totally redoing all my grids? I guess I can, but would like to see if there's something I can do to salvage what I have. I already have to change to datatables.

thanks!
0
 
LVL 83

Expert Comment

by:CodeCruiser
ID: 39895333
Even dislike passing datareaders around even more as it creates risk of open connections and readers over time. If you do not have a lot of code at this stage, I would suggest change it.
0
 
LVL 1

Author Comment

by:BobCSD
ID: 39895363
I saw this example which fills the DataTable and closes the connection. Is it necessary to close the datatable of the grid? or just the connection?

Public Function GetDataTable() As DataTable

            Dim query As String = "SELECT CustomerID, CompanyName, ContactName, ContactTitle, Address, PostalCode FROM Customers"

 

            Dim ConnString As [String] = ConfigurationManager.ConnectionStrings("NorthwindConnectionString").ConnectionString

            Dim conn As New SqlConnection(ConnString)

            Dim adapter As New SqlDataAdapter()

            adapter.SelectCommand = New SqlCommand(query, conn)

 

            Dim myDataTable As New DataTable()

 

            conn.Open()

            Try

                adapter.Fill(myDataTable)

            Finally

                conn.Close()

            End Try

 

            Return myDataTable

        End Function

Open in new window

0
 
LVL 1

Author Comment

by:BobCSD
ID: 39895478
0
How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

 
LVL 62

Expert Comment

by:Fernando Soto
ID: 39895550
Hi BobCSD;

To your question, "I saw this example which fills the DataTable and closes the connection. Is it necessary to close the datatable of the grid? or just the connection?", no you just close the reader, there is nothing to close on the DataGrid or DataTable.
0
 
LVL 1

Author Comment

by:BobCSD
ID: 39895601
>>no you just close the reader

We are talking about my new scenario. I have been told not to use a reader and to use a DataTable instead. Plus, my scenario doesn't create the DataTable (or Reader) in the codebehind, it creates it in another library and passes it in. So I came up with a new change.

So looking at the suggested change from my last post, what do I need to make sure I do besides closing the connection? I do not close the DataTable anywhere. Nor do I close the Adapter.

ID: 39895363

thanks!
0
 
LVL 62

Expert Comment

by:Fernando Soto
ID: 39895619
In connection to this post, "ID: 39895363", the way you are doing it there is correct.
0
 
LVL 83

Assisted Solution

by:CodeCruiser
CodeCruiser earned 333 total points
ID: 39895631
DataTable is disconnected so there is no need to "close" it.
0
 
LVL 1

Author Comment

by:BobCSD
ID: 39895872
>>DataTable is disconnected so there is no need to "close" it.

Conversely, is a SQLDataReader not disconnected, so there is a need to close it?
0
 
LVL 83

Accepted Solution

by:
CodeCruiser earned 333 total points
ID: 39895928
Yes SQLDataReader keeps the connection to database open and occupied until it is closed. It will become apparent if you try to execute another command using the same connection (you will get an error that an open reader is already attached to this connection).
0
 
LVL 1

Author Closing Comment

by:BobCSD
ID: 39895947
Thanks both of you! And thanks CC for the "not related to question" because evidentally it is, since a DataTable doesn't need closing and that's what I'm looking for. Something I don't have to close.

thanks!
0

Featured Post

Top 6 Sources for Identifying Threat Actor TTPs

Understanding your enemy is essential. These six sources will help you identify the most popular threat actor tactics, techniques, and procedures (TTPs).

Join & Write a Comment

Wouldn’t it be nice if you could test whether an element is contained in an array by using a Contains method just like the one available on List objects? Wouldn’t it be good if you could write code like this? (CODE) In .NET 3.5, this is possible…
A long time ago (May 2011), I have written an article showing you how to create a DLL using Visual Studio 2005 to be hosted in SQL Server 2005. That was valid at that time and it is still valid if you are still using these versions. You can still re…
Get a first impression of how PRTG looks and learn how it works.   This video is a short introduction to PRTG, as an initial overview or as a quick start for new PRTG users.
In this tutorial you'll learn about bandwidth monitoring with flows and packet sniffing with our network monitoring solution PRTG Network Monitor (https://www.paessler.com/prtg). If you're interested in additional methods for monitoring bandwidt…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now