Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 266
  • Last Modified:

c# geting value from string from end despite the length

having a string that will increase its length over time,

therefore substring(thestring.Length - 6, 1);

wont actually work

is there a method in c# similar to vb's Strings.Right, or a regex?
0
doramail05
Asked:
doramail05
  • 4
  • 3
  • 2
  • +1
1 Solution
 
AndyAinscowCommented:
What do you mean, won't work?
If the string is 10 chars long then Length is 10, if 20 then Length is 20, if 12345 then length is 12345.
0
 
doramail05Author Commented:
"1119991234123"; = 13 in length    

(thestring - 6, 1)

= getting 2


if

"11199912341234"; = 14 in length

(thestring - 6, 1)

= getting 3
0
 
AndyAinscowCommented:
Yes, so what is the problem?  The VB right function would behave the same way and you say you want something from the end of the string.
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
frankhelkCommented:
If you need Right(), you can simply use it right away (no pun intended :) in C# ....
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using Microsoft.VisualBasic;

namespace TestClass
{
    class Program
    {
        static void Main(string[] args)
        {
            String s,t;
            s = "This is a string !";
            t = Strings.Right(s, 3);
            Console.WriteLine(t);
        }
    }
}

Open in new window

That would write

g !

to the console.

Bsides of using Microsoft.VisualBasic you'll need to add a reference to Microsoft.VisualBasic to your project.

Have fun ...
0
 
Minh Võ CôngCommented:
Do you want get 6th from right of string?

char[] getRight(string str,int postfromright)
{
   if (postfromright>=str.Length) return 0;
   else return str[str.Length-postfromright-1];
}
string getRight(string str,int postfromright,int count)
{
   if (postfromright>=str.Length+count) return "";
   else return str.SubString([str.Length-Post-1],count);
}

Open in new window

0
 
doramail05Author Commented:
guess this works fine for me

String s, t;
s = "111999123412301";
t = Strings.Right(s, 3);
char c = t.FirstOrDefault();
Response.Write(c);

Open in new window

0
 
AndyAinscowCommented:
Odd.
In your 'self posted answer' you specify the final 3 chars of the string, in the question you were posting code that retrieved a string of length 1 part way in from the end and stating it didn't work because the string was growing in length.
If you always wanted the final 3 characters as a string then I would have told you how to do it in my very first post.
In future it will help you if you ask a question about what you want.

(If you don't understand a function - eg. substring - it is always useful to look it up in the help files, then you may not need to waste time even asking a question, it is clear there that the second parameter is the length of the string to return AND not supplying one will return everything until the end of the string)
0
 
frankhelkCommented:
@AndyAinscow:

Hmmmm- despite of the fact that his substring() example was not perfectly chosen (although he said that it won't work for him), he explicitly asked if there was a similar function to VB's Strings.Right() in C#. That was completely clear from my view, wasn't it ?
0
 
AndyAinscowCommented:
@frankhelk
I'm not criticizing you.  It is just that the substring function will do do everything the Right function will do and more.  No need for any extra imports and quite possibly fewer lines of code as well depending on if there is a requirement for the 'and more'.  The reason that substring didn't work given was that the string was growing.  If substring wouldn't work in that case then Right should have even more problems.
0
 
frankhelkCommented:
@AndyAinscow:

I didn't take that as critic ... no need to apologize.

For clarification (no critc, too): I recommended that solution because it has some advantages:

Maybe faster: substring() has some more flexible options and therefore is more complex. That leads (possibly) to a bigger performance footprint ... which (i admit) might be neglectible depending on usage frequency. Besides of that, substring() needs some  extra math with "length-n" on the caller side, which is obsolete with Right() that does it internal.
Readability of code: If someone reads the code, the substring() variant would cause the reader to stumble a little bit, with the need for meditating about "what's done here" - If I had the need for Right() at many places, as the next best solution after importing the VB  version I would have encapsulated the substring() into a custom right() just to clarify my coding.

And the only extra code needed is the "using ..." directive at the beginning of the code. Not much of a sacrifice in my opinion, measured by at least the gain in readability. And when using Visual Studio, Strings.Right() is part of the package ... isn't it ?
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 4
  • 3
  • 2
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now