Help with Update Query

Gordon Hughes
Gordon Hughes used Ask the Experts™
on
What is wrong with this:-

PURREQH, COSTCTR
update PURREQH
set PURREQH.COSTCENTER = PURREQH.[DESTID]
where PURREQH.COSTCENTER is null
and PURREQH.DESTID in COSTCTR.COSTCENTER

get the following error message:-#

Msg 102, Level 15, State 1, Line 1
Incorrect syntax near ','.
Msg 102, Level 15, State 1, Line 5
Incorrect syntax near 'COSTCTR'.
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
Kyle AbrahamsSenior .Net Developer

Commented:
update p
set p.CostCenter = p.DestID
from PURREQH p
join COSTCTR c on p.DESTID  = c.CostCenter
where p.CostCenter is null
The table names don't go at the top like that.  You should have:

update PURREQH
set PURREQH.COSTCENTER = PURREQH.[DESTID]
FROM PURREQH
where PURREQH.COSTCENTER is null
and PURREQH.DESTID in (SELECT COSTCENTER FROM COSTCTR)
Gordon HughesDirector

Author

Commented:
Hi

Have tried dkrollCTN solution
The query runs but have an error as I did not take account of null
this is where there are nulls in the PURREQH.[DESTID]

so get the following:

Msg 515, Level 16, State 2, Procedure PURREQ_A, Line 87
Cannot insert the value NULL into column 'SESSIONID', table 'MP2LIVE.dbo.MP2TRIGGER'; column does not allow nulls. INSERT fails.
The statement has been terminated.

How do I change the query

Gordon
Build an E-Commerce Site with Angular 5

Learn how to build an E-Commerce site with Angular 5, a JavaScript framework used by developers to build web, desktop, and mobile applications.

update PURREQH
set PURREQH.COSTCENTER = PURREQH.[DESTID]
FROM PURREQH
where PURREQH.COSTCENTER is null
and PURREQH.DESTID in (SELECT COSTCENTER FROM COSTCTR WHERE COSTCENTER IS NOT NULL)
Gordon HughesDirector

Author

Commented:
Hi

Tried that, but still get

Msg 515, Level 16, State 2, Procedure PURREQ_A, Line 87
Cannot insert the value NULL into column 'SESSIONID', table 'MP2LIVE.dbo.MP2TRIGGER'; column does not allow nulls. INSERT fails.
The statement has been terminated.

I think the issue is where the PURREQH.DESTID has a null value, but I may be wrong!

Gordon
Can you post the code from the MP2TRIGGER in table MP2LIVE?
Kyle AbrahamsSenior .Net Developer

Commented:
What if you just disabled the trigger?
Gordon HughesDirector

Author

Commented:
Couple of things
Firstly I think i need to update the table PURREQ rather than the view PURREQH

so tried this
update PURREQ
set PURREQ.COSTCENTER = PURREQ.[DESTID]
FROM PURREQ
where PURREQ.COSTCENTER is null
and PURREQ.DESTID in (SELECT COSTCENTER FROM COSTCTR WHERE COSTCENTER IS NOT NULL)

but still get the same error message

MP2LIVE.dbo.MP2TRIGGER' is a table, cannot see any trigger code

Not sure what to do next, apart from give up today and go and have my dinner!!

Gordon
The error you're getting is coming from MP2TRIGGER.  We need to see what's going on in there.
Gordon HughesDirector

Author

Commented:
Hi
How do I disable the trigger?
Gordon
Kyle AbrahamsSenior .Net Developer

Commented:
Actually the issue is here:
PURREQ_A

Is there that trigger on the table?
Gordon HughesDirector

Author

Commented:
Hi
PURREQ_A is the trigger on PURREQ table
Do you know how I could temporary disable it?
Gordon
Senior .Net Developer
Commented:
disable trigger dbo.PURREQ_A on Purreq

-- code

enable trigger dbo.Purreq_A on purreq


or
you can just right click and disabled the trigger manually.

be sure to enable it when you're done.
Gordon HughesDirector

Author

Commented:
Hi
Will try the code, but when you right. Click there is not an option to disable the trigger

Gordon
Kyle AbrahamsSenior .Net Developer

Commented:
You may not have permissions.

What account are you using?
Gordon HughesDirector

Author

Commented:
Hi
Am using the sa account

Gordon
Kyle AbrahamsSenior .Net Developer

Commented:
Are you sure you're clicking on the trigger?
disable
Gordon HughesDirector

Author

Commented:
Hi
I used the disaable command, worked OK and then I could run

update PURREQ
set PURREQ.COSTCENTER = PURREQ.[DESTID]
FROM PURREQ
where PURREQ.COSTCENTER is null
and PURREQ.DESTID in (SELECT COSTCENTER FROM COSTCTR WHERE COSTCENTER IS NOT NULL)

It worked OK then enabled the trigger

Job Done
Gordon HughesDirector

Author

Commented:
Was a little challenging, but got there with the help
Top Expert 2012

Commented:
I used the disaable command, worked OK and then I could run
There are two problems with this approach:
1. Security:  The user must have ALTER permissions on the table .
2. Global scope:  Disabling a TRIGGER not only affects your session, but also affects all sessions for all users.
Gordon HughesDirector

Author

Commented:
Hi
I used it only to run an update script
I then ran the enable code
Is this ok?
Gordon
Top Expert 2012

Commented:
So long as you are OK with the security (or lack of) and no one else is using that table at that time you should be fine.

Mind you those are big ifs.

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial