Solved

Why Doesn't this regex return a positive result?

Posted on 2014-03-07
10
275 Views
Last Modified: 2014-03-07
I'm not familiar with regex and a temp programmer used this code.
        $pattern = '^[AD]([HF][12]|[Z][1])([0][1234569]|[1][0-9]|[2][123]|[3][34]|[4][0]|[5][1346])([0][12345679]|[1][0])([0][12345]|[1][03]|[2][03679]|[3][2389]|[4][01]|[5][1]|[9][5])([0][0123458]|[1][8]|[2][68]|[3][8]|[4][8]|[H][B])*^';
        
        //check if the product code matches a valid code pattern
        if(!preg_match($pattern, $pc)){
            $error = 'Please enter a valid product code';
        }

Open in new window

$pc is equal to "AF141020100"

I'm wondering if someone could explain how this code does not match the pattern specified.
0
Comment
Question by:dmleves49
  • 4
  • 3
10 Comments
 
LVL 34

Expert Comment

by:Dan Craciun
ID: 39913593
Because it expects to be AF140, not AF141

HTH,
Dan
0
 
LVL 34

Accepted Solution

by:
Dan Craciun earned 500 total points
ID: 39913604
Try this pattern to match:
$pattern='^[AD]([HF][12]|[Z][1])([0][1234569]|[1][0-9]|[2][123]|[3][34]|[4][01]|[5][1346])([0][12345679]|[1][0])([0][12345]|[1][03]|[2][03679]|[3][2389]|[4][01]|[5][1]|[9][5])([0][0123458]|[1][8]|[2][68]|[3][8]|[4][8]|[H][B])*$'

Open in new window

0
 
LVL 109

Expert Comment

by:Ray Paseur
ID: 39913722
http://xkcd.com/1171/

Try writing down the rules for the product code.  I'll bet the regular expression could be a LOT simpler.
0
Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 

Author Comment

by:dmleves49
ID: 39913751
Thanks Dan. I was able to aquaint myself with regex enough to figure it out. The first two characters could only equal 33 or 34 if they started with a 3 or 40 if they started with a 4, etc.
0
 
LVL 34

Expert Comment

by:Dan Craciun
ID: 39913758
OK. So what was deficient in my answer?
See here for the grading guide: http://support.experts-exchange.com/customer/portal/articles/481419-what-grade-should-i-award-

In case of any other grade than A you are required to explain what was deficient about the solution.

Thank you.
0
 

Author Comment

by:dmleves49
ID: 39913944
I'm new here so I don't want to cause any problems as I appreciated everyone's help. I do however feel that getting the answer correct isn't actually what I requested.

I would have expected something like what I originally discovered. For Example:

The reason that your product code does not match the regex is because each set of parentheses is testing 2 digits. The first set of digits that do not match in your regex are "41" because [4][0] will only match "40". If you used [4][01] then it would match 40 or 41.

I'll upgrade your mark though. I just thought it required a bit of explanation since I said I wasn't familiar with regex.
0
 

Author Closing Comment

by:dmleves49
ID: 39913950
Sorry Dan , I only saw your code comment, not your explanation. My bad.
0
 
LVL 34

Expert Comment

by:Dan Craciun
ID: 39914167
No worries, mate. Thanks for the points and welcome to EE.

Dan
0

Featured Post

Active Directory Webinar

We all know we need to protect and secure our privileges, but where to start? Join Experts Exchange and ManageEngine on Tuesday, April 11, 2017 10:00 AM PDT to learn how to track and secure privileged users in Active Directory.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

This article will show, step by step, how to integrate R code into a R Sweave document
Password hashing is better than message digests or encryption, and you should be using it instead of message digests or encryption.  Find out why and how in this article, which supplements the original article on PHP Client Registration, Login, Logo‚Ķ
The viewer will learn how to dynamically set the form action using jQuery.
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.

831 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question