Solved

If..Then or Case Else

Posted on 2014-03-24
4
224 Views
Last Modified: 2014-03-24
Folks,
I am using the code below in a command button click event. It works. So my question is there a better way to do this - like using the Case...Else which I am not "yet" comfortable with?


 Dim QtrTotal As Integer							
     QtrTotal = 1571							
     If Range("B7") <> QtrTotal Then							
        MsgBox "1st Qtr Total Hamburgers is incorrect!", vbOKOnly, "Incorrect Answer"							
        Worksheets("2DLine").Range("B7").ClearContents							
        Range("B7").Select							
Exit Sub							
End If							
     QtrTotal = 1271							
     If Range("C7") <> QtrTotal Then							
        MsgBox "1st Qtr Total Milk Shakes is incorrect!", vbOKOnly, "Incorrect Answer"							
        Worksheets("2DLine").Range("C7").ClearContents							
        Range("C7").Select							
Exit Sub							
End If							
     QtrTotal = 238							
     If Range("D7") <> QtrTotal Then							
        MsgBox "1st Qtr Total Salads is incorrect!", vbOKOnly, "Incorrect Answer"							
        Worksheets("2DLine").Range("D7").ClearContents							
        Range("D7").Select							
Exit Sub							
End If							
     QtrTotal = 642		              					
     If Range("E7") <> QtrTotal Then							
        MsgBox "1st Qtr Total Drinks is incorrect!", vbOKOnly, "Incorrect Answer"							
        Worksheets("2DLine").Range("E7").ClearContents							
        Range("E7").Select							
Exit Sub							
End If							

Open in new window

0
Comment
Question by:Frank Freese
  • 2
4 Comments
 
LVL 35

Accepted Solution

by:
Kimputer earned 500 total points
ID: 39952129
You keep testing different cells with different qrtotals.
On first sight, one might think a case of qrtotals would be sufficient, but it's actually not.
Your code should be as it is. You could put it all in an if then, elseif, elseif, elseif else, but it doesn't help that much for coding or readability reasons.
0
 

Author Closing Comment

by:Frank Freese
ID: 39952151
thanks...I wasn't heading to la-la land
0
 
LVL 3

Expert Comment

by:englanddg
ID: 39952157
I agree with Kimputer.

I mean, you could use a Case...but then you'd have to update some variable for the cell reference...probably not worth it (and over-complicating things).
0
 

Author Comment

by:Frank Freese
ID: 39952225
thanks for the affirmation
appreciate it
0

Featured Post

Optimizing Cloud Backup for Low Bandwidth

With cloud storage prices going down a growing number of SMBs start to use it for backup storage. Unfortunately, business data volume rarely fits the average Internet speed. This article provides an overview of main Internet speed challenges and reveals backup best practices.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Some code to ensure data integrity when using macros within Excel. Also included code that helps secure your data within an Excel workbook.
When you see single cell contains number and text, and you have to get any date out of it seems like cracking our heads.
This Micro Tutorial will demonstrate in Microsoft Excel how to add style and sexy appeal to horizontal bar charts.
This Micro Tutorial demonstrates in Microsoft Excel how to consolidate your marketing data by creating an interactive charts using form controls. This creates cool drop-downs for viewers of your chart to choose from.

773 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question