Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people, just like you, are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
Solved

If..Then or Case Else

Posted on 2014-03-24
4
227 Views
Last Modified: 2014-03-24
Folks,
I am using the code below in a command button click event. It works. So my question is there a better way to do this - like using the Case...Else which I am not "yet" comfortable with?


 Dim QtrTotal As Integer							
     QtrTotal = 1571							
     If Range("B7") <> QtrTotal Then							
        MsgBox "1st Qtr Total Hamburgers is incorrect!", vbOKOnly, "Incorrect Answer"							
        Worksheets("2DLine").Range("B7").ClearContents							
        Range("B7").Select							
Exit Sub							
End If							
     QtrTotal = 1271							
     If Range("C7") <> QtrTotal Then							
        MsgBox "1st Qtr Total Milk Shakes is incorrect!", vbOKOnly, "Incorrect Answer"							
        Worksheets("2DLine").Range("C7").ClearContents							
        Range("C7").Select							
Exit Sub							
End If							
     QtrTotal = 238							
     If Range("D7") <> QtrTotal Then							
        MsgBox "1st Qtr Total Salads is incorrect!", vbOKOnly, "Incorrect Answer"							
        Worksheets("2DLine").Range("D7").ClearContents							
        Range("D7").Select							
Exit Sub							
End If							
     QtrTotal = 642		              					
     If Range("E7") <> QtrTotal Then							
        MsgBox "1st Qtr Total Drinks is incorrect!", vbOKOnly, "Incorrect Answer"							
        Worksheets("2DLine").Range("E7").ClearContents							
        Range("E7").Select							
Exit Sub							
End If							

Open in new window

0
Comment
Question by:Frank Freese
  • 2
4 Comments
 
LVL 35

Accepted Solution

by:
Kimputer earned 500 total points
ID: 39952129
You keep testing different cells with different qrtotals.
On first sight, one might think a case of qrtotals would be sufficient, but it's actually not.
Your code should be as it is. You could put it all in an if then, elseif, elseif, elseif else, but it doesn't help that much for coding or readability reasons.
0
 

Author Closing Comment

by:Frank Freese
ID: 39952151
thanks...I wasn't heading to la-la land
0
 
LVL 3

Expert Comment

by:englanddg
ID: 39952157
I agree with Kimputer.

I mean, you could use a Case...but then you'd have to update some variable for the cell reference...probably not worth it (and over-complicating things).
0
 

Author Comment

by:Frank Freese
ID: 39952225
thanks for the affirmation
appreciate it
0

Featured Post

Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

How to quickly and accurately populate Word documents with Excel data, charts and images (including Automated Bookmark generation) David Miller (dlmille) Synopsis In this article you’ll learn how to use ExcelToWord! to copy data,charts, shapes …
Workbook link problems after copying tabs to a new workbook? David Miller (dlmille) Intro Have you either copied sheets to a new workbook, and after having saved and opened that workbook, you find that there are links back to the original sou…
The viewer will learn how to use a discrete random variable to simulate the return on an investment over a period of years, create a Monte Carlo simulation using the discrete random variable, and create a graph to represent the possible returns over…
This Micro Tutorial will demonstrate how to use longer labels with horizontal bar charts instead of the vertical column chart.

839 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question