Solved

Need help with VB Script coding

Posted on 2014-04-03
7
370 Views
Last Modified: 2014-04-03
I'm a C# programmer and haven't done vbscript for years hence needing help here.  I have a script that reboots the pc .  It pops up a dialog that has a Yes and a No buttons that does the following.  
1.  I have a error in the syntax which I uploaded the error screen.  I can't see what the error is so appreciate help with this.  I'm using NotePad++ to edit this file.
2.  Would the code in Sub RebootPC work?  I got this code after googling online.
3.  This program will be run on Windows 7 PCs
Thank you.
 
If they click Yes then restart, if they click No, delay for 10 minutes, then prompt again.  
 
If they hit No a second time, delay 10 minutes, and then prompt again.
 
If they hit No a third time, delay 10 minutes and then prompt again.
 
On the 4th time, give them with a message that the computer will restart in 5 minutes with a count down, and then restart the box.
pcReboot.vbs
vb-err.jpg
0
Comment
Question by:lapucca
  • 4
  • 3
7 Comments
 
LVL 51

Expert Comment

by:Bill Prew
ID: 39976190
The error message doesn't make sense with that code, since there is no line 49 in it, are you sure you pasted the entire script you ran to produce that error?

~bp
0
 
LVL 51

Expert Comment

by:Bill Prew
ID: 39976234
Found several syntax errors, here are some changes that should get past those.  Haven't checked the actual logic, didn't want to reboot at the moment...

'Give users 60 seconds to respond
const TIMEOUT = 60
dim numOfDelays
numOfDelays = 0
strComputer = "."
Set objShell = WScript.CreateObject("WScript.Shell")

SUB RebootPc()	
			Set objFSO = CreateObject("Scripting.FileSystemObject")
			Set objWMIService = GetObject("winmgmts:" _
				& "{impersonationLevel=impersonate}!\\" & strComputer & "\root\cimv2")
			Set colProcessList = objWMIService.ExecQuery _
				("SELECT * FROM Win32_Process WHERE Name = 'explorer.exe'")
			For Each objProcess in colProcessList
				objProcess.Terminate()
			Next
			Set OpSysSet = GetObject("winmgmts:{(Shutdown)}//./root/cimv2").ExecQuery("select * from Win32_OperatingSystem where Primary=true")
			for Each OpSys in OpSysSet
				OpSys.Reboot( )
			NEXT
End SUB
	
SUB DelayOrReboot()
		if(numOfDelays < 3) then
			WScript.Sleep(1000*60*10)
			numOfDelays = numOfDelays + 1
		else 
			Call RebootPc()	
		end if
End SUB	

do while iRetVal < 3
	iRetVal = objShell.Popup("Your computer will restart momentarily.  To restart immediately, click Yes. You can delay the reboot by 10 minutes each time you click the No button with a maximum of 3 delays.", TIMEOUT, "IT Maintenance", vbExclamation+vbYesNo+vbDefaultButton3)

	Select Case iRetVal
	 Case vbYes 
		Call RebootPc()	
	 Case vbNo
		Call DelayOrReboot()
	 Case Else	
		Call DelayOrReboot()
	End Select
Loop

Open in new window

~bp
0
 

Author Comment

by:lapucca
ID: 39976239
Yes, you're absolutely correct!  I removed company heaader comments so that doesn't match up.  Please see the new screen shot.  Thank you.
ErrScreen.jpg
0
How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

 
LVL 51

Expert Comment

by:Bill Prew
ID: 39976306
See my post right above yours...

http:#a39976234

~bp
0
 

Author Comment

by:lapucca
ID: 39976357
Great!  that does get rid of the error and the program is running.  I see the change in "call" sub.  Anything else you change to fix this?   Doesn't seem like change at line 33, iRetval = ....   Or is there changes needed?
Thank you.
0
 
LVL 51

Accepted Solution

by:
Bill Prew earned 500 total points
ID: 39976424
There were several changes.  

Needed parens around the parms on the .Popup call.

Changed several "sub" to "call" where you were calling (rather than defining) subs.

Added "do" before the "while".

~bp
0
 

Author Closing Comment

by:lapucca
ID: 39976439
I google for VB script syntax to put this together and those were what I found.  Thank you so much for the help.  I have another problem with the same code and appreciate it if you can help out.  http://www.experts-exchange.com/Programming/Languages/Visual_Basic/VB_Script/Q_28404636.html
0

Featured Post

Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

Join & Write a Comment

It is becoming increasingly popular to have a front-page slider on a web site. Nearly every TV website,  magazine or online news has one on their site, and even some e-commerce sites have one. Today you can use sliders with Joomla, WordPress or …
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
Learn the basics of if, else, and elif statements in Python 2.7. Use "if" statements to test a specified condition.: The structure of an if statement is as follows: (CODE) Use "else" statements to allow the execution of an alternative, if the …
In this fourth video of the Xpdf series, we discuss and demonstrate the PDFinfo utility, which retrieves the contents of a PDF's Info Dictionary, as well as some other information, including the page count. We show how to isolate the page count in a…

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now