Go Premium for a chance to win a PS4. Enter to Win

  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 327
  • Last Modified:

help with sql syntax

I have the following sql statement that doesn't quite work for me.  I want to list the records from table a join a couple of more, for the records that do not include the same propertyid,bldgid,unitid,resiid from the collections table.   I do not want to include the resident in the list if there is already a record in table2 with the same propertyid,bldgid,unitid,resiid.

Select a.propertyid+a.bldgid+a.unitid+cast(a.resiid as char(5))as residentID,a.propertyid,a.bldgid,a.unitid,a.resiid,a.transamt,a.GLPeriod,b.ResiFirstName,b.ResiLastName,b.ResiStatus,b.moveindate,c.MoveOutDate,c.MoveOutCode	 from tag_esite.dbo.TransactionHeader  a
right outer join lease b on a.PropertyId=b.PropertyId and a.BldgId=b.BldgId and a.UnitId=b.UnitId and a.ResiId=b.Resiid
right outer join leasemoveout c on b.PropertyId=c.PropertyId and b.BldgId=c.BldgId and b.UnitId=c.UnitId and b.ResiId=c.ResiId
where a.sourcecode='wo' and a.propertyid='cl' and a.propertyid+a.bldgid+a.unitid+cast(a.resiid as CHAR(5)) not in (select propertyid+bldgid+unitid+cast(resiid as char(5)) as residentid from aptgallery.dbo.Collections_Master)

order by a.PropertyId,a.BldgId,a.UnitId,a.resiid

Open in new window

thanks in advance
  • 3
  • 3
1 Solution
Brian CroweCommented:
Can you be more specific about why "it doesn't quite work" for you?  You'll get a better answer if you're more specific about your desired output and provide some CREATE TABLE and INSERT sample data statements.

Select a.propertyid+a.bldgid+a.unitid+cast(a.resiid as char(5))as residentID,
from tag_esite.dbo.TransactionHeader  a
right outer join lease b
      on a.PropertyId=b.PropertyId
      and a.BldgId=b.BldgId
      and a.UnitId=b.UnitId
      and a.ResiId=b.Resiid
right outer join leasemoveout c
      on b.PropertyId=c.PropertyId
      and b.BldgId=c.BldgId
      and b.UnitId=c.UnitId
      and b.ResiId=c.ResiId
LEFT OUTER JOIN aptgallery.dbo.Collections_Master AS collections
      ON a.PropertyId=collections.PropertyId
      and a.BldgId=collections.BldgId
      and a.UnitId=collections.UnitId
      and a.ResiId=collections.Resiid
where a.sourcecode='wo'
      and a.propertyid='cl'
      and collections.PropertyId IS NULL
order by a.PropertyId,a.BldgId,a.UnitId,a.resiid
My interpretation, show me records from TransactionHeader, except for residents in:
1. Collections_Master
2. lease
select	a.propertyid+a.bldgid+a.unitid+cast(a.resiid as char(5)) as residentID
,	a.propertyid
,	a.bldgid
,	a.unitid
,	a.resiid
,	a.transamt
,	a.GLPeriod
,	b.ResiFirstName
,	b.ResiLastName
,	b.ResiStatus
,	b.moveindate
,	c.MoveOutDate
,	c.MoveOutCode
from	tag_esite.dbo.TransactionHeader		a
join	lease					b	on	a.PropertyId = b.PropertyId
							and	a.BldgId = b.BldgId
							and	a.UnitId = b.UnitId
							and	a.ResiId = b.ResiId
join	leasemoveout				c	on	a.PropertyId = c.PropertyId
							and	a.BldgId = c.BldgId
							and	a.UnitId = c.UnitId
							and	a.ResiId = c.ResiId
join	aptgallery.dbo.Collections_Master	d	on	a.PropertyId = d.PropertyId
							and	a.BldgId = d.BldgId
							and	a.UnitId = d.UnitId
							and	a.ResiId = d.ResiId
where	a.sourcecode = 'wo'
and	a.propertyid = 'cl'
and	b.ResiId IS NULL
and	d.ResiId IS NULL
by	a.PropertyId
,	a.BldgId
,	a.UnitId
,	a.resiid

Open in new window

mgmhicksAuthor Commented:
what isn't working is that I get all records from transaction Header with a WO sourcecode, but I only want all records from transactionheader with a WO sourcecode, that doesn't  exist in the collections_master table.  What makes the records exist is the propertyid,bldgid, unitid, and resiid all being the same.

Windows Server 2016: All you need to know

Learn about Hyper-V features that increase functionality and usability of Microsoft Windows Server 2016. Also, throughout this eBook, you’ll find some basic PowerShell examples that will help you leverage the scripts in your environments!

Brian CroweCommented:
Why did you choose to use RIGHT OUTER JOINs for lease and leasemoveout?
mgmhicksAuthor Commented:
I only want a single record from the transactionheader and then a join so that I can keep just a single record.  See Ideally is I get the sum of the 'WO' sourcecode amount for each individual propertyid,bldgid,unitid, and resiid.  So know I have the property,bldgid,unitid and resiid as a single record and the 'WO' transaction sum as a column in that single record.  Then I need to join the lease table to receive a little data and the leasemoveout for yet a little more data, all pertaining to the unique property,bldgid,unitid,resiid.  

So a resident may have multiple 'WO' transactions I need the sum for each individual record, and then joining by property,bldging,unitid,resiid to other tables get the other bit of information like moveout date and stuff.

Hope that clears it up more rather than making it worse.
Brian CroweCommented:
I think you are misusing the RIGHT join.  Change them to LEFT joins.  Also, you mention a "sum for each individual record".  Are you referring to the concatenation of the propertyid, bldgid, unitid, and resiid?  Typically a sum is an aggregate calculation requiring grouping which I don't see any indication of.

Try the query below:

Select T.propertyid + T.bldgid + T.unitid + CAST(T.resiid AS CHAR(5)) AS residentID,
	T.propertyid, T.bldgid, T.unitid, T.resiid, T.transamt, T.GLPeriod,
	L. ResiFirstName, L.ResiLastName, L.ResiStatus, L.moveindate,
	M.MoveOutDate, M.MoveOutCode
from tag_esite.dbo.TransactionHeader AS T
	ON T.PropertyId = L.PropertyId
	AND T.BldgId = L.BldgId
	AND T.UnitId = L.UnitId
	AND T.ResiId = L.Resiid
LEFT OUTER JOIN leasemoveout AS M
	ON T.PropertyId = M.PropertyId
	AND T.BldgId = M.BldgId
	AND T.UnitId = M.UnitId
	AND T.ResiId = M.ResiId
LEFT OUTER JOIN aptgallery.dbo.Collections_Master AS C
	ON T.PropertyId = C.PropertyId
	AND T.BldgId = C.BldgId
	AND T.UnitId = C.UnitId
	AND T.ResiId = C.Resiid
WHERE T.sourcecode = 'wo'
	AND T.propertyid = 'cl'
	AND C.PropertyId IS NULL	-- Only include records that have not entered collections
ORDER BY T.PropertyId, T.BldgId, T.UnitId, T.resiid

Open in new window

mgmhicksAuthor Commented:
Thank you

Featured Post

Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

  • 3
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now