Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 445
  • Last Modified:

PowerShell

Any idea what's wrong for the script below ? Is it possible to disable the warning when I run the script ? Tks


$body =  Get-WmiObject Win32_LogicalDisk -filter "DriveType=3' -Computer (Get-Content .\computer.csv) | select SystemName, DeviceID, @{Name="Free (%)";Expression={"{0:N0}" -f (($_.freespace /1gb) / ($_.size /1gb) * 100) }}, @{Name="Size (GB)";Expression={"{0:N1}" -f($_.size/1gb)}},@{Name="Free (GB)";Expression={"{0:N1}" -f($_.freespace/1gb)}} | ConvertTo-Html                          
 
 Send-MailMessage -SmtpServer exdag.abc.com.hk -From dc02.abc.com.hk -To admin@abcl.com.hk -Subject 'Disk Space' -Body ($body -join "`n") -BodyAsHtml
DiskSpace.png
0
AXISHK
Asked:
AXISHK
  • 6
  • 4
  • 4
2 Solutions
 
becraigCommented:
Wasn't this previously answered with :
http://www.experts-exchange.com/Programming/Languages/Scripting/Powershell/Q_28412669.html


If I recall the requirement was the same:
To not capture the error on servers you did not have access to then send only the correct info in the email:


$body = @()
(Get-Content .\computer.csv) | % {
Try {
$body += Get-WmiObject Win32_LogicalDisk -filter “DriveType=3" -computer $_ | Select SystemName,DeviceID, @{Name=”Free (%)”;Expression={“{0:N0}” -f (($_.freespace /1gb) / ($_.size /1gb) * 100) }}, @{Name=”Size (GB)”;Expression={“{0:N1}” -f($_.size/1gb)}},@{Name=”Free (GB)”;Expression={“{0:N1}” -f($_.freespace/1gb)}} |
  ConvertTo-Html
	}
	Catch {
		write-host "$_ failed !!" -fore RED
	}
}

Send-MailMessage -SmtpServer exdag.abc.com.cn -From dc02@abc.com.cn -To cngit-admin@abc.com.cn -Subject 'Servers Disk Space Analysis' -Body ($body -join "`n") -BodyAsHtml 

Open in new window

0
 
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
The error is in the very first double quote. Change that to a tick (single quote), and all should be fine. You can also change the first tick to a double quote - doesn't matter which one you take (here), but they need to match.
0
 
becraigCommented:
Ok so I updated the script I gave you originally I see it was creating multiple html files:
I added an option to verify access first then run the wmi query )

$ErrorActionPreference= 'silentlycontinue'
$servers = @()
(Get-Content .\serverlist.txt) | % {
$error.clear()
$gwmival = Get-WmiObject Win32_LogicalDisk -computer $_
if ($error -ne $null)
{write-host "$_ failed with errors" -fore RED}
else {$servers += $_; }
}
$servers | out-file validlist.txt
 Get-WmiObject Win32_LogicalDisk -filter "DriveType=3" -computer (gc validlist.txt) | Select SystemName,DeviceID, @{Name=”Free (%)”;Expression={“{0:N0}” -f (($_.freespace /1gb) / ($_.size /1gb) * 100) }}, @{Name=”Size (GB)”;Expression={“{0:N1}” -f($_.size/1gb)}},@{Name=”Free (GB)”;Expression={“{0:N1}” -f($_.freespace/1gb)}} | ConvertTo-Html

Send-MailMessage -SmtpServer exdag.abc.com.cn -From dc02@abc.com.cn -To cngit-admin@abc.com.cn -Subject 'Servers Disk Space Analysis' -Body ($body -join "`n") -BodyAsHtml 

Open in new window

0
Creating Active Directory Users from a Text File

If your organization has a need to mass-create AD user accounts, watch this video to see how its done without the need for scripting or other unnecessary complexities.

 
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
becraig,

Don't want to be disrespectful, but your code has several design flaws, is overly complicated, and performing bad because of some work done more than once. It will work, though.

Viewing this question isolated, you seem to miss the point here - there was a syntax error, no WMI error. Of course WMI issues will spit out error messages, but again the script would still work for servers not reporting errors.


AXISHK,

To make sure you get what I told you as correction, and further to show good code formatting style:
$body =  Get-WmiObject Win32_LogicalDisk -filter 'DriveType=3' -Computer (Get-Content .\computer.csv) |
  select SystemName, DeviceID,
    @{Name="Free (%)"; Expression={"{0:N0}" -f (($_.freespace /1gb) / ($_.size /1gb) * 100) }},
    @{Name="Size (GB)"; Expression={"{0:N1}" -f($_.size/1gb)}},
    @{Name="Free (GB)"; Expression={"{0:N1}" -f($_.freespace/1gb)}} |
  ConvertTo-Html

Send-MailMessage -SmtpServer exdag.abc.com.hk -From dc02.abc.com.hk -To admin@abcl.com.hk `
  -Subject 'Disk Space' -Body ($body -join "`n") -BodyAsHtml

Open in new window

0
 
becraigCommented:
No disrespect.

I accept the flaw in the additional overhead, I just whipped it together as a way to run the code and generate a clean server list for the OP.

Could you highlight for me as a part of my own learning what the other design flaws are, I am very new at this and excited to learn from those who know everything about PS.

That being said I check against ~800 servers for execution time just to see how much overhead was added and it was negligible, which was why I went ahead and posted it.

Thanks again for the critique.
0
 
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
First things first, the following code has the parens around Get-Content removed, and uses proper indenting:
$ErrorActionPreference= 'silentlycontinue'
$servers = @()
Get-Content .\serverlist.txt | % {
  $error.clear()
  $gwmival = Get-WmiObject Win32_LogicalDisk -computer $_
  if ($error -ne $null)
  {write-host "$_ failed with errors" -fore RED}
  else {$servers += $_; }
}
$servers | out-file validlist.txt
Get-WmiObject Win32_LogicalDisk -filter "DriveType=3" -computer (gc validlist.txt) |
  select SystemName, DeviceID,
    @{Name="Free (%)"; Expression={"{0:N0}" -f (($_.freespace /1gb) / ($_.size /1gb) * 100) }},
    @{Name="Size (GB)"; Expression={"{0:N1}" -f($_.size/1gb)}},
    @{Name="Free (GB)"; Expression={"{0:N1}" -f($_.freespace/1gb)}} |
  ConvertTo-Html

Send-MailMessage -SmtpServer exdag.abc.com.cn -From dc02@abc.com.cn -To cngit-admin@abc.com.cn -Subject 'Servers Disk Space Analysis' -Body ($body -join "`n") -BodyAsHtml 

Open in new window


One of the design flaws is the usage of result vars in a piped foreach, just to work with the result once. You can and shall push values directly to the pipe for that purpose:
$ErrorActionPreference= 'silentlycontinue'
$servers = @()
Get-Content .\serverlist.txt | % {
  $error.clear()
  $gwmival = Get-WmiObject Win32_LogicalDisk -computer $_
  if ($error) {write-host "$_ failed with errors" -fore RED} else { $_ }
} | out-file validlist.txt
Get-WmiObject Win32_LogicalDisk -filter "DriveType=3" -computer (gc validlist.txt) |
  select SystemName, DeviceID,
    @{Name="Free (%)"; Expression={"{0:N0}" -f (($_.freespace /1gb) / ($_.size /1gb) * 100) }},
    @{Name="Size (GB)"; Expression={"{0:N1}" -f($_.size/1gb)}},
    @{Name="Free (GB)"; Expression={"{0:N1}" -f($_.freespace/1gb)}} |
  ConvertTo-Html

Send-MailMessage -SmtpServer exdag.abc.com.cn -From dc02@abc.com.cn -To cngit-admin@abc.com.cn -Subject 'Servers Disk Space Analysis' -Body ($body -join "`n") -BodyAsHtml 

Open in new window

Next, I don't see a reason for creating the validlist.txt file, so the whole purpose of the first loop is questionable. Instead, if I want to know which PCs didn't respond, I would compare the result list (as non-HTML then of course) with the original server list to get the differences. But in fact, if I wanted to know and log the failures, I would assume the machines are not reachable (excluding any WMI/DCOM related other error cause), and just ping each with Test-Computer prior to trying to access them.
0
 
becraigCommented:
Thanks !!!!
 
I did this in notepad and was not really paying attention to indenting :(

On the second note DEFINITELY (I really had not looked at it from that perspective but that improves performance  :~) )

As for the reason to put the list together, the user had previously asked (on another question) about servers that have access denied errors.

The second point for sure I did not think about in whipping this together (GREAT CATCH)

You're awesome dude...
0
 
AXISHKAuthor Commented:
Tks. I still have problem schedule it under Window. If I test the script under DOS, it will asked me to reply with "R" before execution. Is it possible to run the script directly ?

Tks
ChkDisk.png
0
 
becraigCommented:
You can simply add
Set-executionpolicy bypass

In the first like of your script.
0
 
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
Better to switch off security for this call only (Set-ExecutionPolicy is a permanent change):
  powershell -ExecutionPolicy Unrestricted -file ...
0
 
AXISHKAuthor Commented:
Still receive the prompt. Actually, I have already set the "set-ExecutionPolicy" to "Unrestricted" but it doesn't help..

Tks
PowerShell.png
0
 
becraigCommented:
powershell.exe -ExecutionPolicy Bypass -NoLogo -NonInteractive -NoProfile -WindowStyle Hidden -File script.ps1

Would be a good way to call it if you need to keep execution policy restricted.
0
 
AXISHKAuthor Commented:
The schedule powershell can' t run. I have attached a error message for your reference.

Tks
Task-Scheduler.png
0
 
AXISHKAuthor Commented:
Tks
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

  • 6
  • 4
  • 4
Tackle projects and never again get stuck behind a technical roadblock.
Join Now