Zolf
asked on
Feedback on effectiveness and efficiency of code
Hello there,
I have this class which is implemented on the server side. I want to get help from experts and get their feedback/suggestions/recom mendations on this piece of code I have written and tell me if it has been written with proper standard. specially the hibernate section where I am querying the database. I will appreciate your help. I have attached my code.
cheers
Zolf
zz.txt
I have this class which is implemented on the server side. I want to get help from experts and get their feedback/suggestions/recom
cheers
Zolf
zz.txt
SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
thanks you all for your comments
by: girionis
can you please tell me which code you meant.actually I will be using it in a multi-threaded environment and that was my concern and the reason for posting my code here to get experts like you all to help me improve my code.
by: girionis
Your singleton is not thread-safe.
can you please tell me which code you meant.actually I will be using it in a multi-threaded environment and that was my concern and the reason for posting my code here to get experts like you all to help me improve my code.
SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
cheers
ASKER
thanks for your feedbacks. can you please tell me more about this comment of yours. I did not understand what you meant by test it twice
regarding the concatenation did you mean my sql queries