Solved

Excel VBA

Posted on 2014-07-22
8
247 Views
Last Modified: 2014-07-24
Hello,
I have a sub with:

  Dim lngRow As Long
  Dim timeVal As Date
  Dim HH, MM, SS As Integer
  lngRow = 2

 HH = Hour(Cells(lngRow, 7).Value)
    MM = Minute(Cells(lngRow, 7).Value)
    SS = Second(Cells(lngRow, 7).Value)

    timeVal = TimeSerial(HH, MM, SS)

    ***If timeVal > Mid(Names("Shift1_Start").Value, 2) And timeVal < Mid(Names("Shift1_End").Value, 2) Then
      Cells(lngRow, 45).Value = 1
    ElseIf timeVal > Mid(Names("Shift2_Start").Value, 2) And timeVal < Mid(Names("Shift2_End").Value, 2) Then
      Cells(lngRow, 45).Value = 2
    ElseIf timeVal > Mid(Names("Shift3_Start").Value, 2) And timeVal < Mid(Names("Shift3_End").Value, 2) Then
      Cells(lngRow, 45).Value = 3
    End If

getting this error:
"Run-time error '1004' application-defined or object-defined error" on the line *** (added *** for indication)

I do have Names defined under Name Manager in my sheet, six names
They look like this (one sample):
Name: Shift1_Start
Value: =0.6875 (this represents 7:45 AM)
Refers to:  =0.6875
Scope= Workbook

Any help on resolution, appreciated!

Thanks!
0
Comment
Question by:CABRLU63
  • 4
  • 3
8 Comments
 
LVL 48

Expert Comment

by:Rgonzo1971
ID: 40213805
Hi,

pls try

     If timeVal > Range("Shift1_Start").Value And timeVal < Range("Shift1_End").Value Then

Use Range not Names

why use the mid function?

If you use < or > do not  forget the equal or you will not catch all the data

Regards
0
 
LVL 10

Expert Comment

by:FamousMortimer
ID: 40214099
Hi,

You can replace Names("... with
ThisWorkbook.Names(" and it should work.

    If timeVal > Mid(ThisWorkbook.Names("Shift1_Start").Value, 2) And timeVal < Mid(ThisWorkbook.Names("Shift1_End").Value, 2) Then
        Cells(lngRow, 45).Value = 1
    ElseIf timeVal > Mid(ThisWorkbook.Names("Shift2_Start").Value, 2) And timeVal < Mid(ThisWorkbook.Names("Shift2_End").Value, 2) Then
        Cells(lngRow, 45).Value = 2
    ElseIf timeVal > Mid(ThisWorkbook.Names("Shift3_Start").Value, 2) And timeVal < Mid(ThisWorkbook.Names("Shift3_End").Value, 2) Then
        Cells(lngRow, 45).Value = 3
    End If

Open in new window


A few things...
This line Dim HH, MM, SS As Integer dimensions HH and MM as objects and SS as an integer so I imagine you wanted this: Dim HH As Integer, MM As Integer, SS As Integer

Why not timeVal = TimeValue(Cells(lngRow, 7).Value) instead of
    Dim HH, MM, SS As Integer
    lngRow = 2

    HH = Hour(Cells(lngRow, 7).Value)
    MM = Minute(Cells(lngRow, 7).Value)
    SS = Second(Cells(lngRow, 7).Value)

    timeVal = TimeSerial(HH, MM, SS)
?

Instead of using a defined name, you may just want to use variables in VBA unless you want a user to have the ability to changed the shift times, then you may want to use a name range rather than a defined name which will eliminate the need to use the MID function and clean up the code a bit.  A named range differs from a defined name in that the RefersTo would refer to a range rather than a value.

Let me know if you have any questions.
0
 

Author Comment

by:CABRLU63
ID: 40214743
Thanks for tips.
One more issue though:
Only First Shift got populated in column 45.
Value of 1.
2 and 3 got not populated... Dang.
Any tips?
0
 
LVL 10

Expert Comment

by:FamousMortimer
ID: 40214748
You are welcome.

It would be hard to tell without seeing it.  Any chance you can upload it?

I would start by checking the values of each cell/variable by stepping through the code line by line and try to see what it is (or isn't) doing properly.
0
What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

 

Author Comment

by:CABRLU63
ID: 40215340
OK, in debug mode my code runs  and inputs "1" in column 45.
Then it skips rows of code. It only runs first 3 rows, the ones that input "1", the "2" and "3" are just skipped! Dang.


If timeVal > Mid(Workbooks(ConstWorkBookAppName).Names("Shift1_Start").Value, 2) And timeVal < Mid(Workbooks(ConstWorkBookAppName).Names("Shift1_End").Value, 2) Then
      Cells(lngRow, 45).Value = 1
 ElseIf timeVal > Mid(Workbooks(ConstWorkBookAppName).Names("Shift2_Start").Value, 2) And timeVal < Mid (Workbooks(ConstWorkBookAppName).Names("Shift2_End").Value, 2) Then
      Cells(lngRow, 45).Value = 2
    ElseIf timeVal > Mid(Workbooks(ConstWorkBookAppName).Names("Shift3_Start").Value, 2) And timeVal < Mid(Workbooks(ConstWorkBookAppName).Names("Shift3_End").Value, 2) Then
      Cells(lngRow, 45).Value = 3
    End If
0
 
LVL 10

Accepted Solution

by:
FamousMortimer earned 500 total points
ID: 40216547
Ok I think I see what you mean.

You have all of the conditions in a single If statement.  You need to create an If for each comparison like so...

    If timeVal > Mid(ThisWorkbook.Names("Shift1_Start").Value, 2) And timeVal < Mid(ThisWorkbook.Names("Shift1_End").Value, 2) Then
        Cells(lngRow, 45).Value = 1
    End If
    
    If timeVal > Mid(ThisWorkbook.Names("Shift2_Start").Value, 2) And timeVal < Mid(ThisWorkbook.Names("Shift2_End").Value, 2) Then
        Cells(lngRow, 45).Value = 2
    End If
    
    If timeVal > Mid(ThisWorkbook.Names("Shift3_Start").Value, 2) And timeVal < Mid(ThisWorkbook.Names("Shift3_End").Value, 2) Then
        Cells(lngRow, 45).Value = 3
    End If

Open in new window

0
 

Author Comment

by:CABRLU63
ID: 40216726
It works now, thanks for help!
0
 
LVL 10

Expert Comment

by:FamousMortimer
ID: 40216730
No problem.  Glad we got it worked out!
0

Featured Post

Free Trending Threat Insights Every Day

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

Join & Write a Comment

Microsoft Office Picture Manager is not included in Office 2013. This comes as a shock to users upgrading from earlier versions of Office, such as 2007 and 2010, where Picture Manager was included as a standard application. This article explains how…
To stay competitive, modern businesses must adapt and stay innovative, and this is increasingly only possible by working with outside talent. Managers and executives have understood the power of outsourcing for quite some time, but traditional clien…
The viewer will learn how to edit text. This includes Font, Spacing, Resizing, Color, and other special text options.
This video shows and describes the main difference between both orientations in Microsoft Word. Viewers will understand when to use each orientation and how to get the most out of them.

760 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now