Solved

Java refactoring: removing duplicate code

Posted on 2014-07-24
7
237 Views
Last Modified: 2014-07-24
In the following scenario I have:

interface IClassA

abstract class ClassA implements IClassA

concrete classes ClassB1 and ClassB2 extend ClassA


ClassB1 and ClassB2 both have methods DoStuff()

The code for DoStuff() is identical in both ClassB1 and ClassB2

Is it possible to refactor this to get rid of the identical code?

public interface IClassA {

	public int DoStuff();
	public int ClassSpecific();
}



public abstract class ClassA implements IClassA {

	//public ClassA(){}
	
	public void aCommonMethod() {
	}
}



public class ClassB1 extends ClassA {
	
	public ClassB1(){}
	

	@Override
	public int DoStuff() 
	{
		return ClassSpecific();
	}


	@Override
	public int ClassSpecific()
	{
		return 9;
	}
}



public class ClassB2 extends ClassA {

	public ClassB2(){}

	
	@Override
	public int DoStuff() 
	{
		return ClassSpecific();
	}
	
	
	@Override
	public int ClassSpecific()
	{
		return 5;
	}
}

Open in new window

(Imagine DoStuff() is a lot more complicated than it is here, but it does have buried in it a call to ClassSpecific().)
0
Comment
Question by:deleyd
  • 3
  • 2
  • 2
7 Comments
 
LVL 26

Accepted Solution

by:
dpearson earned 500 total points
ID: 40217786
Can you not just move DoStuff() to classA?

Doug
0
 

Author Comment

by:deleyd
ID: 40217814
Here's my real doStuff() class:
    public double getValueAs(TemperatureUnits units) { 
		if (units == TemperatureUnits.FAHRENHEIT) {
            return asFahrenheit().doubleValue();
        }
        else if (units == TemperatureUnits.CELSIUS) {
            return asCelsius().doubleValue();
        }
        else if (units == TemperatureUnits.KELVIN) {
            return asKelvin().doubleValue();
        }
        else
        {
            throw new InvalidParameterException("Unhanded Temperature Unit " + units.toString());
        }
    }

Open in new window

methods asFahrenheit(), asCelsius(), asKelvin() are the Class Specific methods.

Moving the code to the abstract superclass (ClassA), it complains, because the superclass doesn't define asFahrenheit, asCelsius, asKelvin.
0
 
LVL 16

Expert Comment

by:krakatoa
ID: 40217835
Make the methods static in the abstract class then.
0
DevOps Toolchain Recommendations

Read this Gartner Research Note and discover how your IT organization can automate and optimize DevOps processes using a toolchain architecture.

 

Author Comment

by:deleyd
ID: 40217900
I get:

"Cannot make a static reference to the non-static method ClassSpecific() from type IClassA."
0
 
LVL 26

Expert Comment

by:dpearson
ID: 40217967
In that case I think you'll want to define
asFahrenheit, asCelsius, asKelvin
in the interface/abstract class as well.

You'll need a common "something" (abstract class/interface) for the shared code to be able to call common methods like "asCelsius" and have them execute the right specific implementation.

As you say, since the code is identical this should be solvable with the right hierarchy.  But the interface (or abstract class) will need to include all of the methods that are shared between the two concrete classes.

Doug
0
 

Author Closing Comment

by:deleyd
ID: 40218106
I was missing the keyword 'abstract' !

I had public class AbstractClass

Now it works great once I noticed that. Thank you!
0
 
LVL 16

Expert Comment

by:krakatoa
ID: 40218260
Well done Doug! ;)
0

Featured Post

Back Up Your Microsoft Windows Server®

Back up all your Microsoft Windows Server – on-premises, in remote locations, in private and hybrid clouds. Your entire Windows Server will be backed up in one easy step with patented, block-level disk imaging. We achieve RTOs (recovery time objectives) as low as 15 seconds.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Application launch issue with Apache Tomcat 5 44
JList custom Cell Renderer refresh 15 57
session migration servlets 2 36
ejb on wildfly 5 20
INTRODUCTION Working with files is a moderately common task in Java.  For most projects hard coding the file names, using parameters in configuration files, or using command-line arguments is sufficient.   However, when your application has vi…
Java functions are among the best things for programmers to work with as Java sites can be very easy to read and prepare. Java especially simplifies many processes in the coding industry as it helps integrate many forms of technology and different d…
Viewers will learn about arithmetic and Boolean expressions in Java and the logical operators used to create Boolean expressions. We will cover the symbols used for arithmetic expressions and define each logical operator and how to use them in Boole…
The viewer will learn how to implement Singleton Design Pattern in Java.

773 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question