MemoryLeak on QueryServiceStatus

Hi

for tests I wrote a program with the following code (timerinterval is 1 second):
function ServiceGetStatus(sMachine, sService: string): DWORD;
 var
   SCManHandle, SvcHandle: SC_Handle;
   SS: TServiceStatus;
   dwStat: DWORD;
begin
   dwStat := 0;
   // Open service manager handle.
   SCManHandle := OpenSCManager(pChar(sMachine), nil, SC_MANAGER_CONNECT);
   if (SCManHandle > 0) then
   begin
     SvcHandle := OpenService(SCManHandle, pChar(sService), SERVICE_QUERY_STATUS);
     // if Service installed
     if (SvcHandle > 0) then
     begin
       // SS structure holds the service status (TServiceStatus);
       if (QueryServiceStatus(SvcHandle, SS)) then
       begin
         dwStat := ss.dwCurrentState;
       end;
    end;
   end;
   Result := dwStat;
end;

procedure TForm13.Timer1Timer(Sender: TObject);
begin
  timer1.enabled := false;
  ServiceGetStatus('','myService');
  timer1.enabled := true;
end;

Open in new window

If I execute this program the used memory increases more and more so there seems to be a memory leak. But where? Thanks for your help, Peter
formiAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

ZoppoCommented:
Hi formi,

I'm not sure but I guess the problem is you don't close the handle returned by OpenService, you should close each aquired handle with a call to CloseServiceHandle.

Hope that helps,

ZOPPO
0
Sinisa VukSoftware architectCommented:
Both OpenSCManager and OpenService must be closed using CloseServiceHandle:
function ServiceGetStatus(sMachine, sService: string): DWORD;
 var
   SCManHandle, SvcHandle: SC_Handle;
   SS: TServiceStatus;
   dwStat: DWORD;
begin
   dwStat := 0;
   // Open service manager handle.
   SCManHandle := OpenSCManager(pChar(sMachine), nil, SC_MANAGER_CONNECT);
   if (SCManHandle > 0) then
   begin
     SvcHandle := OpenService(SCManHandle, pChar(sService), SERVICE_QUERY_STATUS);
     // if Service installed
     if (SvcHandle > 0) then
     begin
       // SS structure holds the service status (TServiceStatus);
       if (QueryServiceStatus(SvcHandle, SS)) then
       begin
         dwStat := ss.dwCurrentState;
       end;
       CloseServiceHandle(SvcHandle);
    end;
    CloseServiceHandle(SCManHandle);
   end;
   Result := dwStat;
end;

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
formiAuthor Commented:
of course that was the Problem. Thanks!
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Delphi

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.