mysql sanitisation example from book

Hi

Here is the example

function sanitiseString($var) {
$var = stripslashes($var);
$var = striptags($var);
$var = htmlentities($var); }

function sanitiseMySQL($conn, $var) {

$var= $conn->realeascapestring($var)
$var = sanitiseString($var);
return $var;
}

$var = sanitiseMySQL, $_POST['input'];
 
This is based on a mysqli connection object. I am asking out of curiosity as i use prepared statements anyway but if my understanding is correct wouldnt stripSlashes in first function the undo the work of realeascapestring in the second function?

Or does stripslashes leave things alone that are escaped? I know it leaves alone escaped backslashes but if you had escaped an apostrophe wouldnt this code just undo that?.

I know this could open a whole sanitisation debate. That is not my point of asking. I dont understand the example so I asssume I am missing or overlooking something about stripslahes

Thanks
andiejeAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Ray PaseurCommented:
The example is wrong, full stop.  Don't use it.

Correct examples are given in this article.
http://www.experts-exchange.com/Web_Development/Web_Languages-Standards/PHP/PHP_Databases/A_11177-PHP-MySQL-Deprecated-as-of-PHP-5-5-0.html
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
andiejeAuthor Commented:
Glad its not just me :)
0
andiejeAuthor Commented:
Actually i see i posted the question wrong it should be

$var = sanitiseMySQL(conn, $_POST['input']);

I use PDO but I was still curious to understand what the author was doing.
0
Ray PaseurCommented:
curious to understand what the author was doing
I have no earthly idea!  It does not make sense to me.

You might want to be aware of the background on Magic Quotes, but that alone does not explain what the author was thinking.  The code just looks wrong, as if the instructions were out of order.
http://www.experts-exchange.com/Web_Development/Web_Languages-Standards/PHP/A_6630-Magic-Quotes-a-bad-idea-from-day-one.html

The general design that I follow is this:

1. Filter and sanitize the external input data by verifying that it makes sense (expected integers are, in fact, integers, string lengths are appropriate, etc.)

2. Escape the data with a real_escape_string() function

3. Store in the data base

4. Upon retrieval from the data base, use htmlentities() before echo.

This process ensures that you stored a true representation of what your script received and also protects the clients who see the stored data.  HTMLentities() will prevent malicious Javascript from being executed in the client browser, so it's important to use it before echoing any browser output.

In any case, thanks for the points, ~Ray
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
PHP

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.