Having trouble running easy Get-ADGroupMember script.

Here is my script:

$groups = Get-Content C:\Scripts\Adgroups.txt
            
foreach($Group in $Groups) {            

Get-ADGroupMember -Id $Group | select  @{Expression={$Group};Label="Group Name"},Name | Export-CSV C:\Scripts\GroupMembersProd.CSV -NoTypeInformation

}

Open in new window


When I run it I either get:

Get-ADGroupMember : Cannot bind parameter 'Identity' to the target. Exception setting "Identity": "Cannot validate argument on parameter: 'Identity'. The argument is null or empty. Supply an argument that is not null or empty and then try the command
again."

Or my CSV only has the members to the last group in my text file.
LVL 6
Chad FranksSenior System EngineerAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

SubsunCommented:
Probably your input file will have empty lines.. Change first line of code to following..
$groups = Get-Content C:\Scripts\Adgroups.txt | ?{$_ -ne $null -and $_.trim()  -ne ""}

Open in new window

Also Export-csv should be outside the foreach loop, updated code follows..
Get-Content C:\Scripts\Adgroups.txt | ?{$_ -ne $null -and $_.trim() -ne ""} | %{
 $Group = $_ 
 Get-ADGroupMember -Id $Group | 
 select  @{Expression={$Group};Label="Group Name"},Name
} | Export-CSV C:\Scripts\GroupMembersProd.CSV -NoTypeInformation

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Chad FranksSenior System EngineerAuthor Commented:
That worked perfectly.  Thanks!
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Powershell

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.