Solved

MS-Access error 2501 when saving a record

Posted on 2014-09-02
6
164 Views
Last Modified: 2016-06-15
Starting form is Activity/Command and goes to Equipment form.  Equipment form is filtered by the Activity, and has a subform for Locks (but for now lets ignore it).

I can create an Equipment record (and tblActivityEquipXref record) manually using just the Equipment form's underlying query (see below).   tblEquipment and tblActivityEquipXref records are created at the same time (actually tblActivityEquipXref is created first as it is the parent).  tblEquipment and tblActivityEquipXref are related but I do not enforce referential integrity.  I set tblActivityEquipXref.Activity_FK in Form_BeforeInsert from a global variable (set in the Activity form).  And yes, the global variable is valid when the Equipment form loads.

I can create a record using the "Add" button (uses DoCmd.RunCommand acCmdRecordsGoToNew) in the Equipment form after an Equpment record has been created for the same Activity.  I tested this by creating a record using the form's query datasource, then loading the Equipment form for that same Activity and creating a second equipment record.  Records are saved in the Equipment form using "DoCmd.RunCommand acCmdSaveRecord" (cmdSave_Click).

The problem occurs (I get Error 2501 executing DoCmd.RunCommand acCmdSaveRecord) when there are no Equipment records (for a given Activity) so I am entering equipment data for the first time for a given Activity and the Equipment form loads in insert/add mode.

It seems Access makes a distinction between a form loading in "Insert/Add" mode and using "DoCmd.RunCommand acCmdRecordsGoToNew".  Why does my form behave differently in these two contexts?  This is the crux of the issue and what I need an expert explain to me.

Query (qFrmEquipment) for the Equipment form is:

SELECT tblActivityEquipXref.Activity_FK
, tblActivityEquipXref.Equipment_FK
, tblActivityEquipXref.BuildingNumber
, tblEquipment.Equipment_PK
, tblEquipment.Model_FK
, tblEquipment.Manufacturer_FK
, tblEquipment.SerialNumber
, tblEquipment.Comments
, tblEquipment.RoomNumber
, tblManufacturer.ManufacturerAbbrev
, tblModelNumber.EquipmentType_FK
, tblModelNumber.ModelNumber
, tblEquipmentType.EquipmentType
, tblContainerLockConfig.NumberOperator
, tblContainerLockConfig.NumberOfLocks
FROM tblEquipmentType INNER JOIN
  ((tblContainerLockConfig RIGHT JOIN
    (tblModelNumber INNER JOIN
      (tblManufacturer INNER JOIN tblEquipment ON tblManufacturer.Manufacturer_PK = tblEquipment.Manufacturer_FK)
    ON tblModelNumber.Model_PK = tblEquipment.Model_FK)
   ON tblContainerLockConfig.LockConfig_FK = tblModelNumber.ContainerLockConfig_FK)
     INNER JOIN tblActivityEquipXref ON tblEquipment.Equipment_PK = tblActivityEquipXref.Equipment_FK)
     ON tblEquipmentType.EquipmentType_PK = tblModelNumber.EquipmentType_FK;


I tried eliminating all tables in the query above, except for tblActivityEquipXref and tblEquipment, but still error 2501.

I tried moving Me.Activity_FK = g_lActivityPK to just before "DoCmd.RunCommand acCmdSaveRecord" (in cmdSave_Click), but still error 2501.

I tried changing the "DoCmd.RunCommand acCmdSaveRecord" statement to "Me.Dirty = False", it doesn't make a difference (other than a different error msg), the record still won't save.
0
Comment
Question by:Asteroid_Miniic
6 Comments
 
LVL 84
ID: 40300687
Error 2501 is "The DoCmd Action is canceled". This can occur for a variety of reasons, and does not always mean that the user clicked Cancel - the Access codebase can, apparently, generate a "Cancel" event of it's own, and the downstream code acts accordingly.

Your question is somewhat rambling, and without a sample database is hard to follow. From what I can tell, you have a form you're opening in "Insert/Add mode", which I assume means you've set DataEntry = Yes, or something to that effect, and at some point you get a 2501 error. If you could distill this down to a concrete question or two, we might be able to provide better help.

That said, I think it's your query causing the troubles. In general, trying to add Parent and Child records at the same time (which, I believe, is what you're trying to do) is troublesome at best, and should generally be avoided. Access expects to find a valid Parent record before it can add a Child record, and using a JOIN query in that manner does not allow you (or Access) the luxury of checking before you add it. In general, a Form in Access should act on ONE and ONLY ONE entity at a time. Use Subforms if you must show Parent/Child relationships.
0
 
LVL 34

Accepted Solution

by:
PatHartman earned 500 total points
ID: 40301039
This error should be trapped and usually ignored.  I find it most frequently when I have a procedure that forces a save with DoCmd.RunCommand acCmdSaveRecord.  If the BeforeUpdate event is cancelled because of some validation error, then the calling procedure receives the 2501 error.  Normally, the user has already gotten an appropriate error message from the BeforeUpdate event so the calling procedure simply traps for the error and then resumes next.  Another common place for this error is when opening a report.  If you have code in the NoData event that cancels opening the report, the calling procedure will get the 2501 error which can be ignored.

PS - if you use the Me.Dirty = False trick to force a save and the BeforeUpdate event is cancelled preventing the save, you will also get an error but it won't be 2501, it will be something else but the exact number escapes me at the moment.
0
 

Author Comment

by:Asteroid_Miniic
ID: 40301944
Gents, thank you for your comments.  I'll simplify:

1) I can manually create records using my query qFrmEquipment, no problem

2) My form frmEquipment uses query qFrmEquipment as it's data source

3) If frmEquipment opens with existing equipment records (for a given Activty), I can create new equipment records

4) When no Equipment records exist (for a given Activity), frmEquipment loads empty.  I enter data to create a new equipment record and when "DoCmd.RunCommand acCmdSaveRecord" executes (in cmdSave_Click), I get error 2501

Why are actions 3 and 4 different?  

I apologize for lack of code, but the application exists on a secure private network and I'm not allowed to export code.
0
Highfive Gives IT Their Time Back

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

 

Author Comment

by:Asteroid_Miniic
ID: 40302008
Thank you PatHartman!

You were right, after double-checking my BeforeUpdate event, there was a line of code Canceling the event if action 4 conditions are met.  It always seems the simplest answer is the solution.  I must have stared at that code hundreds of times in the past 2 days and just didn't recognize it.  The disadvantage of being the only IT guy in the dept (in the building)-- no one to bounce ideas off.
0
 
LVL 34

Expert Comment

by:PatHartman
ID: 40302329
My programmers used to think I was Karnack the Magnificent (from the Johnny Carson show if you are to young to recognize the name).  They would explain their symptoms and I would tell them what was wrong with the code.  You have to make a lot of mistakes to get to the point of debugging from afar.  My curse is remembering most of them:)
0
 
LVL 26

Expert Comment

by:MacroShadow
ID: 41655167
No comment has been added to this question in more than 21 days, so it is now classified as abandoned.

I have recommended this question be closed as follows:

Accept: PatHartman (https:#a40301039)

If you feel this question should be closed differently, post an objection and the moderators will review all objections and close it as they feel fit. If no one objects, this question will be closed automatically the way described above.

MacroShadow
Experts-Exchange Cleanup Volunteer
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

In the previous article, Using a Critera Form to Filter Records (http://www.experts-exchange.com/A_6069.html), the form was basically a data container storing user input, which queries and other database objects could read. The form had to remain op…
In Debugging – Part 1, you learned the basics of the debugging process. You learned how to avoid bugs, as well as how to utilize the Immediate window in the debugging process. This article takes things to the next level by showing you how you can us…
Get people started with the utilization of class modules. Class modules can be a powerful tool in Microsoft Access. They allow you to create self-contained objects that encapsulate functionality. They can easily hide the complexity of a process from…
With Microsoft Access, learn how to specify relationships between tables and set various options on the relationship. Add the tables: Create the relationship: Decide if you’re going to set referential integrity: Decide if you want cascade upda…

708 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now