Link to home
Start Free TrialLog in
Avatar of prologic08
prologic08

asked on

Trouble getting VBS code to work

I am having trouble getting a VBS to run. Can someone take a look at line 8 and let me know how its supposed to be written? It doesn't error out but it doesn't run either.. Thank you.

Dim WshShell, fso
Set fso = CreateObject("Scripting.FileSystemObject")
Set WshShell = WScript.CreateObject("WScript.Shell") 
GetTheParent = fso.GetParentFolderName(Wscript.ScriptFullName)
REM WshShell.Run "msiexec.exe /i ""SQLSERVER2012_AMO11x86.msi""", 0, True
REM WshShell.Run "msiexec.exe /i ""SQLSERVER2012_ASADOMD11x86.msi""", 0, True
REM WshShell.Run "cmd /c ""vstor40_x64.exe""", 0, True
WshShell.Run "msiexec.exe /i GetTheParent & ""\"" & ""name of.msi""", 0, True

Open in new window

Avatar of Randy Poole
Randy Poole
Flag of United States of America image

You have to replace 'name of.msi' with the msi you want it to load
ASKER CERTIFIED SOLUTION
Avatar of ChloesDad
ChloesDad
Flag of United Kingdom of Great Britain and Northern Ireland image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
What is GetTheParent? Is it a separate function in your script or is it a variable?  In either case, it seems to be part of the string and that's probably why nothing happens as expected.

Try this:

WshShell.Run "msiexec.exe /i " & getTheParent & "\" & """name of.msi""", 0, True
What you are looking for is a command like this

WshShell.Run msiexec.exe /i "myfolderpath\myfilename.msi" , 0, True

Where myfolderpath is the full path to the file and myfilename is the file that you want to run.

In my initial post, this is what each bit does.

"msiexec.exe /i "  - start of command

""" - puts the " at the start of the filename

GetTheParent  - your variable that is the full path to the file. NB check that this is just the path and not the whole file name and does not end with a \. If it does the next bit is not needed.

"\" - Adds the backslash between the folder path and the filename

"name of.msi""" - Enter your actual file name. The """ at the end puts a final " in the whole string

, 0, True  - The end of the command.
Avatar of zalazar
zalazar

You might want to change the GetTheParent line because if the script runs from the root of the drive it will return an extra backslash e.g. C:\   which will result in two times a "\" in the .Run command.
Using:
GetTheParent = Mid(Wscript.ScriptFullName, 1, InstrRev(Wscript.ScriptFullName, "\") - 1)

Open in new window

will return only e.g. C:  without a "\" for all script locations.