Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 498
  • Last Modified:

Why does my Excel VBA file system object procedure return a 'rogue' file.

Hi All,

I have an Excel VBA procedure which checks a folder to see if there is any file residing there. If there is then it copies the file to a destination folder.

However, because the file check is in a For Next loop, and even though I only have one file in the folder, it processes an 'invisible' file before exiting the loop. I know this because when I put it in Debug and test the values it shows the second time around the loop that the 'filename' is "Thumbs.db". God knows where this file has come from because it doesn't display in Windows Explorer.

Consequently it is affecting my processing because my filename variable changes to this value.

Any clue as to what this might be ? How can I test the folder without having to loop, as I'll only ever have either no files in the folder or only one file in the folder.

My code is enclosed...

' Check if a file has been moved into the Input folder
    Set fs = CreateObject("Scripting.FileSystemObject")

    strSourceFolder = "C:\Users\Toco\Status Report\Data\Input"
    strDestinationFolder = "C:\Users\Toco\Status Report\Data\Archive"
    Set r = fs.GetFolder(strSourceFolder)

    For Each f In r.Files
       fs.CopyFile strSourceFolder & "\" & f.Name, strDestinationFolder & "\" & f.Name
       strFileName = f.Name
    Next

Open in new window

0
Tocogroup
Asked:
Tocogroup
  • 10
  • 5
1 Solution
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
Thumbs.db is an internal file, created when you look at the folder in Windows Explorer, and it stores thumbnail views of the files. You can't easily delete it.

Therefore, you should test for its existence, and take appropriate actions, i.e.

For Each f In r.Files
    If UCase(f.Name) <> "THUMBS.DB" then
       fs.CopyFile strSourceFolder & "\" & f.Name, strDestinationFolder & "\" & f.Name
       strFileName = f.Name
    End If
    Next
0
 
TocogroupAuthor Commented:
Well how about that !  A hidden file.

Returning to my loop, I have a number of issues with it as it doesn't seem to allow me to assign the file to a variable which I can then use to open/copy/save as/delete the file in subsequent processing.

Everytime i try to assign it as per the code below I get a 'Run-time error 9 Subscript out of range', which from my experience has nothing to do with arrays.

     For Each f In r.Files
        If UCase(f.Name) <> "THUMBS.DB" Then
           fs.CopyFile strSourceFolder & "\" & f.Name, strDestinationFolder & "\" & f.Name
           strFileName = f.Name
        End If
     Next

     Set wbInput = Workbooks.Open(strSourceFolder & "\" & strFileName)

Open in new window


I'm sure there must be a simpler way of managing files than using FileSystemObject ??
0
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
Have you tried FileCopy (instead of CopyFile)?

How about an ON ERROR RESUME NEXT command as well?

If you want to check for hidden files, then you can always catalogue the folder first, using something like the programme in www.filecats.co.uk - that shows hidden files (as well as system files etc).
0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
TocogroupAuthor Commented:
I've requested that this question be closed as follows:

Accepted answer: 0 points for Tocogroup's comment #a40325194

for the following reason:

Thanks for your assistance. You've been more than helpful.
Toco
0
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
I have solved the problem.
0
 
TocogroupAuthor Commented:
Ah ok
0
 
TocogroupAuthor Commented:
I've requested that this question be closed as follows:

Accepted answer: 0 points for Tocogroup's comment #a40325194

for the following reason:

Much obliged
0
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
Please award the points.
0
 
TocogroupAuthor Commented:
But I've awarded the points...twice
0
 
TocogroupAuthor Commented:
I've requested that this question be closed as follows:

Accepted answer: 0 points for Tocogroup's comment #a40325194

for the following reason:

I've now awarded three lots of 500 points. I think there's a problem with the system !
0
 
Phillip BurtonDirector, Practice Manager and Computing ConsultantCommented:
:-)
0
 
TocogroupAuthor Commented:
Well yes.....that's what I'm doing. I have been using EE for many years now so I do know how to award points.
I've attached a screenshot of when I accept Philip's solution. I then select the A radio button and then the Submit button.

?? Strange
Capture.PNG
0
 
TocogroupAuthor Commented:
I'm not selecting my own comments !
0
 
TocogroupAuthor Commented:
Hah...nice one !

Just a thought though....I'm running this in Internet Explorer 8 and it renders awfully. Unfortunately my employees are not so sympathetic and won't allow me to download the latest version of IE or, even better, Firefox.

Will be interesting to see if this reoccurs.

Regards
Toco
0
 
TocogroupAuthor Commented:
Thanks, but like Nectar points I'm not sure I'd know what to do with them.      :-)
0

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

  • 10
  • 5
Tackle projects and never again get stuck behind a technical roadblock.
Join Now