Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 328
  • Last Modified:

Help with AFTER INSERT trigger

Gurus,

I wrote a before insert trigger that isn't working.

create or replace
TRIGGER katvf7c_to_katimpc before
insert on KAT for each row
begin
:new.KATIMPC := :new.KATPF7C;
end;

What is the best way to convert this to an AFTER INSERT trigger as I can use the :new option?  Thanks in advance!
0
xbox360dp
Asked:
xbox360dp
  • 4
  • 3
  • 2
2 Solutions
 
sdstuberCommented:
you can use :new in a before row trigger

your syntax is valid, what isn't working about it?

what are you trying to do?
0
 
slightwv (䄆 Netminder) Commented:
Instead of changing it, fix what isn't working.

This works for me:
drop table tab1 purge;
create table tab1(col1 char(1), col2 char(1));


create or replace trigger tab1_trig
before insert on tab1
for each row
begin
	:new.col2 := :new.col1;
end;
/

show errors

insert into tab1(col1) values('a');
commit;

select * from tab1;

Open in new window

0
 
xbox360dpAuthor Commented:
It's something funky through our application. If I insert the record directly through the database the trigger works fine.
0
Get your Disaster Recovery as a Service basics

Disaster Recovery as a Service is one go-to solution that revolutionizes DR planning. Implementing DRaaS could be an efficient process, easily accessible to non-DR experts. Learn about monitoring, testing, executing failovers and failbacks to ensure a "healthy" DR environment.

 
slightwv (䄆 Netminder) Commented:
Inserting into a table with a trigger and not having the trigger fire is not a feature of a 'funky application'.  It is a pretty huge bug/hole in the database.

The trigger as written will work.  Something isn't right.  I would dig deeper.
0
 
sdstuberCommented:
The trigger is fine "as is" - what is the application doing  that makes you think the trigger is not working?

Is the application doing direct path inserts? or updating the table after an insert so as to override the trigger's data change?


Just to follow up on your original question - trying to use an AFTER ROW trigger to change a value won't work.  You can reference the new value, but you can't change it - because it's too late at that point.

By definition of an AFTER trigger: the insert is already done, so the value is fixed.
0
 
xbox360dpAuthor Commented:
Made the following change and it works now. We must be doing an update as well!

create or replace
TRIGGER katvf7c_to_katimpc before
insert or update on KAT for each row
begin
:new.KATIMPC := :new.KATPF7C;
end;
0
 
sdstuberCommented:
if you have 2 columns that must always be equal, you might want to consider simply dropping the KATIMPC column and then recreating it as a virtual column.

Of course that will mean rearranging the order of columns in your table, so it might not be feasible.

Another option but a bit more cumbersome:  change the name of the table and create a view with the table's original name.  This will let you drop the physical column but recreate the logical column in its original position within the table.
0
 
xbox360dpAuthor Commented:
I've requested that this question be closed as follows:

Accepted answer: 0 points for xbox360dp's comment #a40328681

for the following reason:

This worked for me.
0
 
sdstuberCommented:
Shouldn't a split be in order since you changed your trigger based on my comment about updates?
0

Featured Post

VIDEO: THE CONCERTO CLOUD FOR HEALTHCARE

Modern healthcare requires a modern cloud. View this brief video to understand how the Concerto Cloud for Healthcare can help your organization.

  • 4
  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now