Solved

Problem with sql query and variable in access

Posted on 2014-09-20
3
633 Views
Last Modified: 2014-09-20
Hi,
   I have written some code which basically takes the value of a query from a dropdown, as well as values from 2 listboxes which contain the start range and end range for an ID.....  This is the code I have:

Dim rs As DAO.Recordset
    Dim xlApp As Object
    Dim xlWb As Object
    Dim xlWs As Object
    Dim Counter As Long
    Dim QueryName As String
    Dim SaveToPath As String
    Dim TemplatePath As String
    Dim firstidnum As String
    Dim secondidnum As String
    
    firstidnum = firstid.Value
    secondidnum = secondid.Value
    
    QueryName = template_dropdown.Value
    SaveToPath = "\\server\share\Database\Generated Reports\" & QueryName & "_"
    
    If QueryName = "DCC" Then
        TemplatePath = "\\server\share\Database\comments-template-modified.xlsx"
    ElseIf QueryName = "DCC Adult" Then
        TemplatePath = "\\server\share\Database\comments-template-modified.xlsx"
    ElseIf QueryName = "Healthcare Report" Then
        TemplatePath = "\\server\share\Database\comments-template-modified.xlsx"
    Else
        TemplatePath = "\\server\share\Database\comments-template.xlsx"
    End If  
    
    Set rs = CurrentDb.OpenRecordset("SELECT * FROM " & QueryName & " WHERE ID BETWEEN " & firstidnum & " AND " & secondidnum & "")
 
    Set xlApp = CreateObject("Excel.Application")
    xlApp.DisplayAlerts = False
    Set xlWb = xlApp.Workbooks.Add(TemplatePath)
    Set xlWs = xlWb.ActiveSheet
   With xlWs
        For Counter = 0 To rs.Fields.Count - 1
            .Cells(2, 1).CopyFromRecordset rs
        Next
 '       .Cells(2, 1).CopyFromRecordset rs
    End With
    xlWb.SaveAs SaveToPath & Format(Now, "yyyymmdd") & ".xlsx"
    xlWb.Close False
    xlApp.DisplayAlerts = True
    Set xlWs = Nothing
    Set xlWb = Nothing
    xlApp.Quit
    Set xlApp = Nothing
    rs.Close
    Set rs = Nothing
 
    MsgBox "The select report has been generated..."

Open in new window

The problem is with this line here:

Set rs = CurrentDb.OpenRecordset("SELECT * FROM " & QueryName & " WHERE ID BETWEEN " & firstidnum & " AND " & secondidnum & "")

It keeps giving me a "Syntax error in FROM clause"

Basically the value QueryName is from a dropdown listbox which contains all the queries, I then want to do a BETWEEN statement, so only the ID's selected via firstidnum and secondidnum are output...

Can anyone help?

Cheers

Damian
0
Comment
Question by:damianb123
  • 2
3 Comments
 
LVL 120

Accepted Solution

by:
Rey Obrero (Capricorn1) earned 500 total points
ID: 40334344
test this, wrap the variable "QueryName" in brackets

Set rs = CurrentDb.OpenRecordset("SELECT * FROM  [" & QueryName & "]  WHERE ID BETWEEN " & firstidnum & " AND " & secondidnum & "")
0
 

Author Comment

by:damianb123
ID: 40334352
WELL DONE!  Perfect, just what I needed my friend.

Damian
0
 

Author Closing Comment

by:damianb123
ID: 40334353
WELL DONE!  Perfect, just what I needed my friend.

Damian
0

Featured Post

Enterprise Mobility and BYOD For Dummies

Like “For Dummies” books, you can read this in whatever order you choose and learn about mobility and BYOD; and how to put a competitive mobile infrastructure in place. Developed for SMBs and large enterprises alike, you will find helpful use cases, planning, and implementation.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

JSON is being used more and more, besides XML, and you surely wanted to parse the data out into SQL instead of doing it in some Javascript. The below function in SQL Server can do the job for you, returning a quick table with the parsed data.
Preparing an email is something we should all take special care with – especially when the email is for somebody you may not know very well. The pressures of everyday working life stacked with a hectic office environment can make this a real challen…
Viewers will learn how to use the UPDATE and DELETE statements to change or remove existing data from their tables. Make a table: Update a specific column given a specific row using the UPDATE statement: Remove a set of values using the DELETE s…
With Secure Portal Encryption, the recipient is sent a link to their email address directing them to the email laundry delivery page. From there, the recipient will be required to enter a user name and password to enter the page. Once the recipient …

810 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question