Solved

Is there a way to only code to format once and have that apply to many cells?

Posted on 2014-09-25
14
117 Views
Last Modified: 2014-10-07
I have some code that moves data from an access database to an excel spreadsheet. Right now I am moving the data and then going back to each cell based on their content and formatting them. It works, but it is really bulky and I am thinking that there must be a better way to do this.
This is the code that loops through the data in access and puts it into the spreadsheet:

Do Until rs.EOF

    If rs!to = TheTO Then
        If rs!STO = TheSTOname Then
            If TheStaffName = rs!TeamName Then
                If theActDesc = rs!ActDesc Then
                    rs.MoveNext
                Else
                    theRow = theRow + 1
                    oSheet.Cells(theRow, 3).Value = rs!ActDesc
                    rs.MoveNext
                End If
            Else
                'theRow = theRow + 1
                oSheet.Cells(theRow, 2).Value = rs!TeamName
                TheStaffName = rs!TeamName
                
                rs.MoveNext
            End If
        Else
            theRow = theRow + 1
            oSheet.Cells(theRow, 1).Value = rs!STO
            TheSTOname = rs!STO
            TheStaffName = ""
            
            rs.MoveNext
        End If
    Else
        theRow = theRow + 1
        oSheet.Cells(theRow, 1).Value = rs!to
        TheTO = rs!to
        rs.MoveNext
    End If
skip:
Loop

Open in new window




I need all of the cells that were populated with TheTO to be formatted a particular way. Right now I have code that looks for the specific words in the cells and formats those cells. Here is an example:

With oSheet.Range("A1:" & Chr(iNumCols + 64) & rs.RecordCount + 1)
For Each C In oSheet.Range("A1:" & Chr(iNumCols + 64) & rs.RecordCount + 1).Cells
   If C.Value = "Thing number 1 it looks for" Then
    With C
        .Font.Name = "Arial"
        .Font.Bold = True
        .Font.Size = 12
        .Interior.ColorIndex = 15
        .Borders(xlEdgeTop).LineStyle = xlContinuous
        .Borders(xlEdgeTop).Weight = xlThin
        .Borders(xlEdgeTop).ColorIndex = xlAutomatic
        .Borders(xlEdgeBottom).LineStyle = xlContinuous
        .Borders(xlEdgeBottom).Weight = xlThin
        .Borders(xlEdgeBottom).ColorIndex = xlAutomatic
        .Borders(xlEdgeRight).LineStyle = xlContinuous
        .Borders(xlEdgeRight).Weight = xlThin
        .Borders(xlEdgeRight).ColorIndex = xlAutomatic
        .Borders(xlEdgeLeft).LineStyle = xlContinuous
        .Borders(xlEdgeLeft).Weight = xlThin
        .Borders(xlEdgeLeft).ColorIndex = xlAutomatic
        .Borders(xlInsideVertical).LineStyle = xlContinuous
        .Borders(xlInsideVertical).Weight = xlThin
        .Borders(xlInsideVertical).ColorIndex = xlAutomatic
        .Borders(xlInsideHorizontal).LineStyle = xlContinuous
        .Borders(xlInsideHorizontal).Weight = xlThin
        .Borders(xlInsideHorizontal).ColorIndex = xlAutomatic
            


     End With
    End If
Next C

Open in new window


The problem is that, if I continue to find all of these cells individually based on their content, I will have to repeat it about 40 times.  

I am willing to do that, but it seems like this is excessive. I would love to just tell it to format every cell that was populated with TheTO.

Is there a way to do this?
0
Comment
Question by:Megin
  • 6
  • 3
  • 2
  • +2
14 Comments
 
LVL 35

Expert Comment

by:PatHartman
ID: 40344584
call the format procedure from the initial loop where you populate a cell.  Pass in the cell reference so it is not hard-coded in the format procedure.
0
 
LVL 24

Expert Comment

by:Phillip Burton
ID: 40344677
You could use a style. They are underused in Excel, but might work in this case"
0
 

Author Comment

by:Megin
ID: 40344695
Unfortunately, it all has to be done from Access and all has to be coded.

PatHartman: I am not sure if this is what you meant at all.

What have done now is set up a public procedure called "FormatTO"

It is this:
Public Sub FormatTO()
Dim C As Object
 With C
        .Font.Name = "Arial"
        .Font.Bold = True
        .Font.Size = 12
        .Interior.ColorIndex = 15
        .Borders(xlEdgeTop).LineStyle = xlContinuous
        .Borders(xlEdgeTop).Weight = xlThin
        .Borders(xlEdgeTop).ColorIndex = xlAutomatic
        .Borders(xlEdgeBottom).LineStyle = xlContinuous
        .Borders(xlEdgeBottom).Weight = xlThin
        .Borders(xlEdgeBottom).ColorIndex = xlAutomatic
        .Borders(xlEdgeRight).LineStyle = xlContinuous
        .Borders(xlEdgeRight).Weight = xlThin
        .Borders(xlEdgeRight).ColorIndex = xlAutomatic
        .Borders(xlEdgeLeft).LineStyle = xlContinuous
        .Borders(xlEdgeLeft).Weight = xlThin
        .Borders(xlEdgeLeft).ColorIndex = xlAutomatic
        .Borders(xlInsideVertical).LineStyle = xlContinuous
        .Borders(xlInsideVertical).Weight = xlThin
        .Borders(xlInsideVertical).ColorIndex = xlAutomatic
        .Borders(xlInsideHorizontal).LineStyle = xlContinuous
        .Borders(xlInsideHorizontal).Weight = xlThin
        .Borders(xlInsideHorizontal).ColorIndex = xlAutomatic
     End With
     
    End Sub

Open in new window




Then I added the name of that procedure here:

    Else
        theRow = theRow + 1
        oSheet.Cells(theRow, 1).Value = rs!to
        TheTO = rs!to
        FormatTO
        rs.MoveNext
    End If
skip:
Loop

Open in new window


This isn't working at all. In fact, it stops everything so that the data doesn't transfer completely.

Please forgive my being so dense. I am still really new to vba.
0
Ransomware-A Revenue Bonanza for Service Providers

Ransomware – malware that gets on your customers’ computers, encrypts their data, and extorts a hefty ransom for the decryption keys – is a surging new threat.  The purpose of this eBook is to educate the reader about ransomware attacks.

 
LVL 35

Expert Comment

by:PatHartman
ID: 40344725
I don't do Excel or I would show you how to do it.  When you call FormatTo, you need to tell it what cell it is supposed to format so you need to add an argument that is a cell reference.

Call FormatTo(somecellreference)

Also,

Public Sub FormatTO(somecellreference)
in the code, format somecellreference
0
 
LVL 33

Expert Comment

by:Norie
ID: 40344746
Have you considered using Excel's conditional formatting?

That can be used to format based on criteria,  and it can be applied through code.
0
 
LVL 31

Expert Comment

by:Helen_Feddema
ID: 40346197
Your FormatTO procedure needs a Cell or Range argument -- then you can call it, giving it a cell or range to work with.  That may be all you need.
0
 

Author Comment

by:Megin
ID: 40346512
Imnorie: How would that work?
0
 

Author Comment

by:Megin
ID: 40346515
Helen: The thing is that the cell will probably change every time the report is run. I need the cell to be formatted based either on the text in the cell, which would require I code the formatting about 40 different times, or attached to the loop that adds the data to the document (every cell that is populated with TheTO).

At least, those are what I think are my options.
0
 
LVL 35

Expert Comment

by:PatHartman
ID: 40346532
If you will refer back to my first response, that is exactly what I told you to do.  then in 40344725 I gave you pseudo code.  If the formatting is different for each cell, they you will need 40 different procedures.  If you can tell from the cell contents what the format should be, then you can determine it in the formatting procedure.  If you have a general format such as for dates, numbers, text, then in the calling routine where you know what you are putting into the cell, you can pass an additional argument to the format routine.
0
 
LVL 31

Expert Comment

by:Helen_Feddema
ID: 40346564
Perhaps you could create a procedure with a Select Case statement to apply the appropriate formatting depending on the contents of the cell.
0
 

Author Comment

by:Megin
ID: 40352892
I am sorry I am not catching on to any of this. I am not sure how to do what you all have suggested.
I would like my code to format those cells populated with TheTO. TheTO is going to be different every time. So I would like the code to format the cell when it puts that information in. I think that what I need is something to go in here:
            theRow = theRow + 1
            oSheet.Cells(theRow, 1).Value = rs!STO
            TheSTOname = rs!STO
            TheStaffName = ""
            
            rs.MoveNext

Open in new window


That is where it will add TheTO data to a cell. If it can just format the cell every time TheTO is added to it, I think that would fix everything. But when I try to add that, it stops the code or errors.

Again, I apologize for not understanding how to the other things.
0
 

Accepted Solution

by:
Megin earned 0 total points
ID: 40357781
I figured this out.

I had to put the code in like this:
        theRow = theRow + 1
        oSheet.Cells(theRow, 1).Value = rs!to
       'FormatTO (oSheet.Cells(theRow,1),"Arial")
        Set C = oSheet.Cells(theRow, 1)
        With C
            .Font.Name = "Arial"
            .Font.Bold = True
            .Font.Size = 12
            .Interior.ColorIndex = 15
            .Borders(xlEdgeTop).LineStyle = xlContinuous
            .Borders(xlEdgeTop).Weight = xlThin
            .Borders(xlEdgeTop).ColorIndex = xlAutomatic
            .Borders(xlEdgeBottom).LineStyle = xlContinuous
            .Borders(xlEdgeBottom).Weight = xlThin
            .Borders(xlEdgeBottom).ColorIndex = xlAutomatic
            .Borders(xlEdgeRight).LineStyle = xlContinuous
            .Borders(xlEdgeRight).Weight = xlThin
            .Borders(xlEdgeRight).ColorIndex = xlAutomatic
            .Borders(xlEdgeLeft).LineStyle = xlContinuous
            .Borders(xlEdgeLeft).Weight = xlThin
            .Borders(xlEdgeLeft).ColorIndex = xlAutomatic
            .Borders(xlInsideVertical).LineStyle = xlContinuous
            .Borders(xlInsideVertical).Weight = xlThin
            .Borders(xlInsideVertical).ColorIndex = xlAutomatic
            .Borders(xlInsideHorizontal).LineStyle = xlContinuous
            .Borders(xlInsideHorizontal).Weight = xlThin
            .Borders(xlInsideHorizontal).ColorIndex = xlAutomatic
Range(C, C.Offset(0, 1)).Merge
         End With
        TheTO = rs!to
        rs.MoveNext
        
    End If


skip:
Loop

Open in new window


Thank you for all of the suggestions. I am sorry I had so much trouble understanding.
0
 
LVL 33

Expert Comment

by:Norie
ID: 40358478
That code looks fine to me, and I don't think you have any reason to apologise to anyone.
0
 

Author Closing Comment

by:Megin
ID: 40365543
I am choosing my answer because I got this solved outside of EE.
0

Featured Post

Gigs: Get Your Project Delivered by an Expert

Select from freelancers specializing in everything from database administration to programming, who have proven themselves as experts in their field. Hire the best, collaborate easily, pay securely and get projects done right.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This article is a continuation or rather an extension from Cascading Combos (http://www.experts-exchange.com/A_5949.html) and builds on examples developed in detail there. It should be understandable alone, but I recommend reading the previous artic…
When you are entering numbers in a speadsheet, and don't remember what 6×7 is, you just type “=6*7" instead. It works in every cell! This is not so in Access. To enter the elusive 42 in a text box, you have to find a calculator, and then copy the re…
In Microsoft Access, learn how to “cascade” or have the displayed data of one combo control depend upon what’s entered in another. Base the dependent combo on a query for its row source: Add a reference to the first combo on the form as criteria i…
In Microsoft Access, learn different ways of passing a string value within a string argument. Also learn what a “Type Mis-match” error is about.

805 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question