# boolean program

Hi,

I was trying below program challenge
http://codingbat.com/prob/p165701

``````public boolean loneTeen(int a, int b) {
if(a>=13&a<=19){
return true;
}

if(b>=13&b<=19){
return true;
}

return false;

}
``````
i wrote as above.

I have four test scenario cases failing

Expected      Run
loneTeen(13, 99) → true      true      OK
loneTeen(21, 19) → true      true      OK
loneTeen(13, 13) → false      true      X
loneTeen(14, 20) → true      true      OK
loneTeen(20, 15) → true      true      OK
loneTeen(16, 17) → false      true      X
loneTeen(16, 9) → true      true      OK
loneTeen(16, 18) → false      true      X
loneTeen(13, 19) → false      true      X
loneTeen(13, 20) → true      true      OK
loneTeen(6, 18) → true      true      OK
loneTeen(99, 13) → true      true      OK
loneTeen(99, 99) → false      false      OK
Correct for more than half the tests

Please advise on why they are failing and how to fix it
LVL 7
###### Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Commented:

It's just not handling the case where both a and b are teens.  In that case, the instructions say to return false.

Since your code tests to see if a is a teen and if it is, immediately returns true, it gets the case wrong where both a and b are teens.

You may want to consider something like this instead?

``````public boolean loneTeen(int a, int b) {
boolean aTeen = (a >= 13 && a <= 19) ;
boolean bTeen = (b >= 13 && b <= 19) ;

if(aTeen && !bTeen){
return true;
}

if(!aTeen && bTeen){
return true;
}

return false;

}
``````

Experts Exchange Solution brought to you by

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Sr. Software engineerCommented:
Or in short:

``````public boolean loneTeen(int a, int b) {
return (isTeen(a) && !isTeen(b)) || (isTeen(b) && !isTeen(a));
}

private boolean isTeen(int value) {
return value >= 13 && value <=19;
}
``````
Commented:
//or
return isTeen(a) ^ isTeen(b);
Sr. Software engineerCommented:
Right you are :-)
Author Commented:
I wonder is there is a way i can modify and make my program to work without introducing aTeen and bTeen.
Why we need extra valraibles called aTeen and bTeen in this case.

if(13<=b<=19){
return true;

}

If i give both conditions together as above i am getting error below. Why i am getting below error. what it means. I thought it should work fine. Please advise

Error:      if(13<=b<=19){
^^^^^^^^^
The operator <= is undefined for the argument type(s) boolean, int

see Example Code to help with compile problems
Author Commented:
I tried like below but lot of test cases are failing
``````public boolean loneTeen(int a, int b) {
if(13<=a & a <=19){
return true;

}

if(13<=b & b<=19){
return true;

}

if((13<=a & a <=19)&!(13<=b & b<=19)){
return false;
}

if(!(13<=a & a <=19)&!(13<=b & b<=19)){
return false;
}

return false;
}
``````

Expected      Run
loneTeen(13, 99) → true      true      OK
loneTeen(21, 19) → true      true      OK
loneTeen(13, 13) → false      true      X
loneTeen(14, 20) → true      true      OK
loneTeen(20, 15) → true      true      OK
loneTeen(16, 17) → false      true      X
loneTeen(16, 9) → true      true      OK
loneTeen(16, 18) → false      true      X
loneTeen(13, 19) → false      true      X
loneTeen(13, 20) → true      true      OK
loneTeen(6, 18) → true      true      OK
loneTeen(99, 13) → true      true      OK
loneTeen(99, 99) → false      false      OK

Author Commented:
``````public boolean loneTeen(int a, int b) {
if(13<=a & a <=19){
return true;

}

if(13<=b & b<=19){
return true;

}

if((13<=a & a <=19)&!(13<=b & b<=19)){
return false;
}

if(!(13<=a & a <=19)&!(13<=b & b<=19)){
return false;
}

return false;
}
``````

I wrote as above base on comment ID: 40358663
How is above program differenmt from program in comment ID: 40358663

``````public boolean loneTeen(int a, int b) {
if(13<=a & a <=19){
return true;

}

if(13<=b & b<=19){
return true;

}

if((13<=a & a <=19)&!(13<=b & b<=19)){
return false;
}

if(!(13<=a & a <=19)&!(13<=b & b<=19)){
return false;
}

return true;
}
``````

If i change the last method return staement from false to true more than half test cases are failing. I wonder why. I though i covered all the 3 major challenge issues in 3 if loops. So i thought method return type either true or false does not matter. But my results prove that i am wrong in my assumption. Please advise

Expected      Run
loneTeen(13, 99) → true      true      OK
loneTeen(21, 19) → true      true      OK
loneTeen(13, 13) → false      true      X
loneTeen(14, 20) → true      true      OK
loneTeen(20, 15) → true      true      OK
loneTeen(16, 17) → false      true      X
loneTeen(16, 9) → true      true      OK
loneTeen(16, 18) → false      true      X
loneTeen(13, 19) → false      true      X
loneTeen(13, 20) → true      true      OK
loneTeen(6, 18) → true      true      OK
loneTeen(99, 13) → true      true      OK
loneTeen(99, 99) → false      false      OK
Commented:
loneTeen(13, 13) → false      true      X
in this case, you should be returning false, but this code immediately returns true
if(13<=a & a <=19){
return true;
Author Commented:
``````public boolean loneTeen(int a, int b) {
if(13<=a & a <=19){
return true;

}

if(13<=b & b<=19){
return true;

}

if((13<=a & a <=19)&!(13<=b & b<=19)){
return false;
}

if(!(13<=a & a <=19)&!(13<=b & b<=19)){
return false;
}

return false;
}
``````

How do i fix above code so that it returns false when both a and b are teens. I do not want to introduce aTeen and bTeen if possible. Please advise
Author Commented:
``````public boolean loneTeen(int a, int b) {
if((13<=a & a <=19)&!(13<=b & b<=19)){
return true;
}

if(!(13<=a & a <=19)&(13<=b & b<=19)){
return true;
}

return false;
}
``````

I wrote as above and passed all the test cases

Expected      Run
loneTeen(13, 99) → true      true      OK
loneTeen(21, 19) → true      true      OK
loneTeen(13, 13) → false      false      OK
loneTeen(14, 20) → true      true      OK
loneTeen(20, 15) → true      true      OK
loneTeen(16, 17) → false      false      OK
loneTeen(16, 9) → true      true      OK
loneTeen(16, 18) → false      false      OK
loneTeen(13, 19) → false      false      OK
loneTeen(13, 20) → true      true      OK
loneTeen(6, 18) → true      true      OK
loneTeen(99, 13) → true      true      OK
loneTeen(99, 99) → false      false      OK

Does it look fine?
Commented:
Yes this is fine.  You should be using "&&" instead of just "&" but that's all.

Can you see how this code is the same as this code (using the variables) except you've written out the test (a >= 13 && a <= 19) each place where the variable would go?

public boolean loneTeen(int a, int b) {
boolean aTeen = (a >= 13 && a <= 19) ;
boolean bTeen = (b >= 13 && b <= 19) ;

if(aTeen && !bTeen){
return true;
}

if(!aTeen && bTeen){
return true;
}

return false;
}

So yes, what you wrote is fine.

Doug
Commented:
If the goal is to pass the test cases, then it is looks fine for that.
Author Commented:
Can you see how this code is the same as this code (using the variables) except you've written out the test (a >= 13 && a <= 19) each place where the variable would go?

yes i see it
Information Technology SpecialistCommented:
>>Why we need extra valraibles<<
Sometimes they can simplify coding and make it easier to understand. The following passes the test only using three lines of code employing two variables:
public static boolean loneTeen(int a, int b) {
boolean aVal = a >= 13 && a <= 19;
boolean bVal = b >= 13 && b <= 19;

return aVal && !bVal || !aVal && bVal ? true : false;
}
Commented:
//or,
return (a >= 13 && a <= 19) ^ (b >= 13 && b <= 19);

//or,
return (a >= 13 && a <= 19) != (b >= 13 && b <= 19);

//or,
return a >= 13 ^ a <= 19 ^ b >= 13 ^ b <= 19;

//or,
return a < 13 ^ b < 13 ^ a > 19 ^ b > 19;

//or even
return (a-13 ^ b-13 ^ 19-a ^ 19-b)<0;
###### It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Java

From novice to tech pro — start learning today.